Re: Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64951/
---
(Updated Січ. 5, 2018, 1:20 після полудня)
Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, and Dmytro Sen.
Bugs: AMBARI-22724
https://issues.apache.org/jira/browse/AMBARI-22724
Repository: ambari
Description
---
Issue discovered alongside with another bugs which leads upgrade to fail in the
middle with partially applying changes to DB. It leads to exception in code:
{code}
private void renameServiceDeletedColumn() throws AmbariException,
SQLException {
if (dbAccessor.tableHasColumn(CLUSTER_CONFIG_TABLE,
SERVICE_DELETED_COLUMN)) {
dbAccessor.renameColumn(CLUSTER_CONFIG_TABLE, SERVICE_DELETED_COLUMN, new
DBAccessor.DBColumnInfo(UNMAPPED_COLUMN, Short.class, null, 0, false));
}
}
{code}
Exception: ERROR: column "unmapped" of relation "clusterconfig" already exists
(err.png)
Table generated DDL from current state:
{code}
-- auto-generated definition
CREATE TABLE clusterconfig
(
config_id INT8(19) NOT NULL
CONSTRAINT pk_clusterconfig
PRIMARY KEY,
version_tagVARCHAR(255) NOT NULL,
versionINT8(19) NOT NULL,
type_name VARCHAR(255) NOT NULL,
cluster_id INT8(19) NOT NULL
CONSTRAINT fk_clusterconfig_cluster_id
REFERENCES clusters,
stack_id INT8(19) NOT NULL
CONSTRAINT fk_clusterconfig_stack_id
REFERENCES stack,
config_dataTEXT(max) NOT NULL,
config_attributes TEXT(max),
create_timestamp INT8(19) NOT NULL,
unmapped INT2(5) DEFAULT 0 NOT NULL,
selected INT2(5) DEFAULT 0 NOT NULL,
selected_timestamp INT8(19) DEFAULT 0 NOT NULL,
service_deletedINT2(5) DEFAULT 0 NOT NULL
);
CREATE UNIQUE INDEX uq_config_type_tag
ON clusterconfig (cluster_id, type_name, version_tag);
CREATE UNIQUE INDEX uq_config_type_version
ON clusterconfig (cluster_id, type_name, version);
{code}
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
e6a7829
Diff: https://reviews.apache.org/r/64951/diff/2/
Changes: https://reviews.apache.org/r/64951/diff/1-2/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Review Request 64951: Idempotent issue on Ambari Upgrade, renameServiceDeletedColumn failed with column already exists exception
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64951/
---
Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, and Dmytro Sen.
Bugs: AMBARI-22724
https://issues.apache.org/jira/browse/AMBARI-22724
Repository: ambari
Description
---
Issue discovered alongside with another bugs which leads upgrade to fail in the
middle with partially applying changes to DB. It leads to exception in code:
{code}
private void renameServiceDeletedColumn() throws AmbariException,
SQLException {
if (dbAccessor.tableHasColumn(CLUSTER_CONFIG_TABLE,
SERVICE_DELETED_COLUMN)) {
dbAccessor.renameColumn(CLUSTER_CONFIG_TABLE, SERVICE_DELETED_COLUMN, new
DBAccessor.DBColumnInfo(UNMAPPED_COLUMN, Short.class, null, 0, false));
}
}
{code}
Exception: ERROR: column "unmapped" of relation "clusterconfig" already exists
(err.png)
Table generated DDL from current state:
{code}
-- auto-generated definition
CREATE TABLE clusterconfig
(
config_id INT8(19) NOT NULL
CONSTRAINT pk_clusterconfig
PRIMARY KEY,
version_tagVARCHAR(255) NOT NULL,
versionINT8(19) NOT NULL,
type_name VARCHAR(255) NOT NULL,
cluster_id INT8(19) NOT NULL
CONSTRAINT fk_clusterconfig_cluster_id
REFERENCES clusters,
stack_id INT8(19) NOT NULL
CONSTRAINT fk_clusterconfig_stack_id
REFERENCES stack,
config_dataTEXT(max) NOT NULL,
config_attributes TEXT(max),
create_timestamp INT8(19) NOT NULL,
unmapped INT2(5) DEFAULT 0 NOT NULL,
selected INT2(5) DEFAULT 0 NOT NULL,
selected_timestamp INT8(19) DEFAULT 0 NOT NULL,
service_deletedINT2(5) DEFAULT 0 NOT NULL
);
CREATE UNIQUE INDEX uq_config_type_tag
ON clusterconfig (cluster_id, type_name, version_tag);
CREATE UNIQUE INDEX uq_config_type_version
ON clusterconfig (cluster_id, type_name, version);
{code}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
e6a7829
Diff: https://reviews.apache.org/r/64951/diff/1/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 64863: Implement resolving dependencies for each service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64863/ --- (Updated Січ. 2, 2018, 2:57 після полудня) Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. Bugs: AMBARI-22707 https://issues.apache.org/jira/browse/AMBARI-22707 Repository: ambari Description --- Resolve dependencies for services. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 73a2c93 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java e19e6e3 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 38e1233 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java d12e8cd ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java dcc8433 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 7f1daa7 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java a811c5e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProviderTest.java bed3689 Diff: https://reviews.apache.org/r/64863/diff/2/ Changes: https://reviews.apache.org/r/64863/diff/1-2/ Testing --- UT will be added soon Thanks, Vitalyi Brodetskyi
Review Request 64863: Implement resolving dependencies for each service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64863/ --- Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. Bugs: AMBARI-22707 https://issues.apache.org/jira/browse/AMBARI-22707 Repository: ambari Description --- Resolve dependencies for services. Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java 73a2c93 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java e19e6e3 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 38e1233 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java d12e8cd ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java dcc8433 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 7f1daa7 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java a811c5e Diff: https://reviews.apache.org/r/64863/diff/1/ Testing --- UT will be added soon Thanks, Vitalyi Brodetskyi
Re: Review Request 64710: UI hangs on step 2 of security wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64710/#review194573 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 19, 2017, 2:04 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64710/ > --- > > (Updated Гру. 19, 2017, 2:04 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-22673 > https://issues.apache.org/jira/browse/AMBARI-22673 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/properties/krb5_conf.j2 > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64710/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64693: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64693/ --- (Updated Гру. 21, 2017, 11:07 після полудня) Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Chnaged adding service group dependency by name, not by id. Fixed add/get/delete requests. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java 9389f0c ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java 9f4eea3 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java 1a4b4ed ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java aac7102 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java ee0beeb ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 914b65a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProviderTest.java PRE-CREATION Diff: https://reviews.apache.org/r/64693/diff/2/ Changes: https://reviews.apache.org/r/64693/diff/1-2/ Testing --- Thanks, Vitalyi Brodetskyi
Review Request 64782: Add service dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64782/ --- Review request for Ambari, Dmytro Sen and Madhuvanthi Radhakrishnan. Bugs: AMBARI-22345 https://issues.apache.org/jira/browse/AMBARI-22345 Repository: ambari Description --- Add service dependencies Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java ace7098 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java 6cf46b4 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java b6d40e3 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java dd48875 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 02ea294 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProviderTest.java PRE-CREATION Diff: https://reviews.apache.org/r/64782/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 64709: Stack unit tests fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64709/#review194140 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 19, 2017, 12:02 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64709/ > --- > > (Updated Гру. 19, 2017, 12:02 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Sid > Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22671 > https://issues.apache.org/jira/browse/AMBARI-22671 > > > Repository: ambari > > > Description > --- > > Fix ~100 UT. > > Before: > > > > Total run:1210 > Total errors:195 > Total failures:44 > > > After: > > > > Total run:1210 > Total errors:83 > Total failures:67 > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 21aeec7200 > ambari-server/src/test/python/common-services/configs/hive_default.json > 45af84788d > > ambari-server/src/test/python/common-services/configs/hive_unsupported_jdbc_type.json > 76759c1d58 > ambari-server/src/test/python/common-services/configs/pxf_default.json > 384ca40614 > > ambari-server/src/test/python/common-services/configs/ranger_admin_default.json > 4702d65177 > > ambari-server/src/test/python/common-services/configs/ranger_admin_unsupported_db_flavor.json > d7abe6b156 > ambari-server/src/test/python/common-services/configs/sqoop_default.json > 0c74006f37 > > ambari-server/src/test/python/common-services/configs/sqoop_unsupported_jdbc_driver.json > b571b9a7a3 > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > 62ce5f1910 > > ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json > 84bc64d743 > > ambari-server/src/test/python/custom_actions/configs/remove_previous_stacks.json > ec28e05558 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > e153225f55 > ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json > f1d1944fcf > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > a112b64652 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json > 2ec7f519b0 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json d5c676e8b5 > > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json > b65d3c0743 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json > dabedf7cc3 > ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json > b6a97b9311 > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json > 9bac43f386 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json > da46ad3b04 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json > 04fc65259d > ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json > cb026da863 > ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json > 919a7cf564 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json > 8e33fce1ab > ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json > 7a6da349df > > ambari-server/src/test/python/stacks/2.0.6/configs/default_yarn_include_file_dont_manage.json > 10c0827d3f > > ambari-server/src/test/python/stacks/2.0.6/configs/default_yarn_include_file_manage.json > d896d8ea1b > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json > 06ed171cd9 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_active_node.json > c90b6b2558 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node.json > 65b2907cb1 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start.json > d9ecd86ae4 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_standby_node_initial_start_dfs_nameservices.json > c02aa2f946 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_default.json > c50ddb6f74 > ambari-server/src/test/python/stacks/2.0.6/configs/ha_secure
Review Request 64693: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64693/ --- Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Chnaged adding service group dependency by name, not by id. Fixed add/get/delete requests. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java 9389f0c ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java 9f4eea3 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java 1a4b4ed ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java aac7102 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java ee0beeb ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 914b65a Diff: https://reviews.apache.org/r/64693/diff/1/ Testing --- Thanks, Vitalyi Brodetskyi
Re: Review Request 64682: Fix unit test failures caused by old json format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64682/#review194067 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 18, 2017, 1:32 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64682/ > --- > > (Updated Гру. 18, 2017, 1:32 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Sid > Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22664 > https://issues.apache.org/jira/browse/AMBARI-22664 > > > Repository: ambari > > > Description > --- > > This fixes around 100 of failed unit tests due to old format of input json > files. > > Before the fix: > > > > Total run:1206 > Total errors:281 > Total failures:41 > > > After the fix: > > > > Total run:1210 > Total errors:195 > Total failures:44 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 3e86347b2d > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py > 8690be6da9 > ambari-server/src/test/python/common-services/configs/hive_default.json > 2cd0d11a0e > > ambari-server/src/test/python/common-services/configs/hive_unsupported_jdbc_type.json > d85dbfe6e6 > ambari-server/src/test/python/common-services/configs/pxf_default.json > 90d8e7c10e > > ambari-server/src/test/python/common-services/configs/ranger_admin_default.json > 2e66c62c43 > > ambari-server/src/test/python/common-services/configs/ranger_admin_unsupported_db_flavor.json > aa620a4d2f > > ambari-server/src/test/python/common-services/configs/ranger_kms_default.json > b6de743319 > > ambari-server/src/test/python/common-services/configs/ranger_kms_unsupported_db_flavor.json > 22a3a44179 > ambari-server/src/test/python/common-services/configs/sqoop_default.json > 73a810dddb > > ambari-server/src/test/python/common-services/configs/sqoop_unsupported_jdbc_driver.json > dc76fbbc94 > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > 8029959732 > > ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json > e7abedd7d2 > > ambari-server/src/test/python/custom_actions/configs/remove_previous_stacks.json > cc4a626ef0 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py > 86b0782ec3 > ambari-server/src/test/python/stacks/2.0.6/configs/altfs_plus_hdfs.json > f928073f4a > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > 3dfcb27756 > ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json > adab92fb88 > > ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json > e81fe9ea30 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json > f3e8dc36a2 > ambari-server/src/test/python/stacks/2.0.6/configs/default_client.json > 8c17e869b1 > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha.json > 7b0f78da47 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_nn_ha_2.json > 01f0efc814 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json > 0cbd3222ce > ambari-server/src/test/python/stacks/2.0.6/configs/default_no_install.json > cfcf5e1cca > ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json > 7db73ab1f7 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json > f50a207da8 > ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json > c1eb86882c > > ambari-server/src/test/python/stacks/2.0.6/configs/default_yarn_include_file_dont_manage.json > ac3f86dc28 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_yarn_include_file_manage.json > aa2d3d5cce > ambari-server/src/test/python/stacks/2.0.6/configs/flume_22.json c99d10b625 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json > 1a4d676bd8 > ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json > b197fded94 > > ambari-server/src/test/python/stacks/2.0.6/configs/ha_bootstrap_active_node.json > 841
Re: Review Request 64606: Fix unit tests in feature branch to make them workable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64606/ --- (Updated Гру. 14, 2017, 1:46 після полудня) Review request for Ambari, Attila Doroszlai and Dmytro Sen. Bugs: AMBARI-22614 https://issues.apache.org/jira/browse/AMBARI-22614 Repository: ambari Description --- Fix unit tests in feature branch to make them workable Diffs (updated) - ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 62ff3d3 ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java 96f80b1 ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148 ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java c79e761 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java f2ee106 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 3e4baed ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 0f99b08 ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java 3ce6686 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 7ccdadd ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 4b5d6c0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java a6fc919 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java efa351a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 6611c55 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e23ad79 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 6bc8b95 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 4593409 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 91c048b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java 1bc8776 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java a38e44d ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 9df236f ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java dafc5e8 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 4dac019 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 933743f ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 658ba84 ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java fafeaff ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 8546a9b Diff: https://reviews.apache.org/r/64606/diff/2/ Changes: https://reviews.apache.org/r/64606/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 64606: Fix unit tests in feature branch to make them workable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64606/ --- Review request for Ambari, Attila Doroszlai and Dmytro Sen. Bugs: AMBARI-22614 https://issues.apache.org/jira/browse/AMBARI-22614 Repository: ambari Description --- Fix unit tests in feature branch to make them workable Diffs - ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 9be79e7 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java ea082c6 ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java 62ff3d3 ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java 96f80b1 ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java 782f148 ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java c79e761 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java f2ee106 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e584322 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 3e4baed ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 0f99b08 ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java 3ce6686 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java 7ccdadd ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 4b5d6c0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java a6fc919 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java efa351a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 6611c55 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java e23ad79 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 6bc8b95 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java ce3656c ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java 4593409 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java 91c048b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java 1bc8776 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java a38e44d ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 9df236f ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java dafc5e8 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java 4dac019 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 933743f ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 658ba84 ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java fafeaff ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 8546a9b Diff: https://reviews.apache.org/r/64606/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 64420: Fix unit tests in feature branch to make them workable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64420/ --- Review request for Ambari, Attila Doroszlai and Jayush Luniya. Bugs: AMBARI-22614 https://issues.apache.org/jira/browse/AMBARI-22614 Repository: ambari Description --- Fix unit tests in feature branch to make them workable Diffs - ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java fc49a24 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java 69eb21d ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 0b38b36 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 19f940f ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionSchedulerThreading.java 22f23c8 ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java 8a6025f ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 50d4733 ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java 4f8c423 ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java fc24d2c ambari-server/src/test/java/org/apache/ambari/server/api/resources/ServiceResourceDefinitionTest.java 75319ea ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java 2fe8ee0 ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java 040b571 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 21cf518 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 5c6f374 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java aee1952 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 9e6b98b ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 387fa45 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java 8e968cc ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/state/GeneralServiceCalculatedStateTest.java 0b6c3f3 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java a86d125 ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java a03d7cc ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java 158c47d ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 4e1c139 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 5e5395a ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java a52f438 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 4ce7387 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java be4a907 ambari-server/src/test/resources/cluster-settings.xml PRE-CREATION Diff: https://reviews.apache.org/r/64420/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 64374: Ambari Builds Are Failing With Python Test Errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64374/#review192978 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 6, 2017, 12:13 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64374/ > --- > > (Updated Гру. 6, 2017, 12:13 після полудня) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22596 > https://issues.apache.org/jira/browse/AMBARI-22596 > > > Repository: ambari > > > Description > --- > > Ambari builds have been failing for a long time: > <https://builds.apache.org/job/Ambari-branch-2.6> > > Looks like some Python problems: > > > > > == > ERROR: test_check_database_name_property > (TestAmbariServer.TestAmbariServer) > -- > Traceback (most recent call last): > File > "/home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/src/test/python/TestAmbariServer.py", > line 7997, in test_check_database_name_property > args = parser.parse_args() > File "/usr/lib/python2.7/optparse.py", line 1402, in parse_args > self.error(str(err)) > File "/usr/lib/python2.7/optparse.py", line 1584, in error > self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg)) > File "/usr/lib/python2.7/optparse.py", line 1574, in exit > sys.exit(status) > SystemExit: 2 > > -- > Ran 276 tests in 7.423s > > FAILED (errors=1) > -- > Failed tests: > ERROR: test_check_database_name_property > (TestAmbariServer.TestAmbariServer) > -- > Traceback (most recent call last): > File > "/home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/src/test/python/TestAmbariServer.py", > line 7997, in test_check_database_name_property > args = parser.parse_args() > File "/usr/lib/python2.7/optparse.py", line 1402, in parse_args > self.error(str(err)) > File "/usr/lib/python2.7/optparse.py", line 1584, in error > self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg)) > File "/usr/lib/python2.7/optparse.py", line 1574, in exit > sys.exit(status) > SystemExit: 2 > > > Diffs > - > > ambari-server/src/test/python/TestAmbariServer.py a53d274809 > > > Diff: https://reviews.apache.org/r/64374/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 64066: Fix validators tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64066/ --- (Updated Лис. 24, 2017, 8:35 після полудня) Review request for Ambari, Attila Magyar, Jayush Luniya, and Swapan Shridhar. Bugs: AMBARI-22515 https://issues.apache.org/jira/browse/AMBARI-22515 Repository: ambari Description --- Fix validators tests. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ebb0362 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 424ed63 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java e3eca17 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java cfa3af1 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java e63ff45 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/UnitValidatorTest.java 95e539e ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java d7ad7f2 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 03219bf Diff: https://reviews.apache.org/r/64066/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 64066: Fix validators tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64066/ --- Review request for Ambari, Attila Magyar, Jayush Luniya, and Swapan Shridhar. Bugs: AMBARI-22493 https://issues.apache.org/jira/browse/AMBARI-22493 Repository: ambari Description --- Fix validators tests. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java ebb0362 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 424ed63 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/HiveServiceValidatorTest.java e3eca17 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java cfa3af1 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java e63ff45 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/UnitValidatorTest.java 95e539e ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java d7ad7f2 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 03219bf Diff: https://reviews.apache.org/r/64066/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 64005: Fix build for test classes in feature branch
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java 4853a4d ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java a807b42 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/UnitValidatorTest.java 334ee4b ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 066ec34 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog252Test.java d936c6d ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java cc58988 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 25e9dbf ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a28d419 Diff: https://reviews.apache.org/r/64005/diff/2/ Changes: https://reviews.apache.org/r/64005/diff/1-2/ Testing --- Just mvn rpm:rpm. Thanks, Vitalyi Brodetskyi
Review Request 64005: Fix build for test classes in feature branch
/topology/validators/RequiredConfigPropertiesValidatorTest.java 4853a4d ambari-server/src/test/java/org/apache/ambari/server/topology/validators/StackConfigTypeValidatorTest.java a807b42 ambari-server/src/test/java/org/apache/ambari/server/topology/validators/UnitValidatorTest.java 334ee4b ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java 066ec34 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog252Test.java d936c6d ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java cc58988 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java 25e9dbf ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a28d419 Diff: https://reviews.apache.org/r/64005/diff/1/ Testing --- Just mvn rpm:rpm. Thanks, Vitalyi Brodetskyi
Re: Review Request 63872: NFSGateway start failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63872/#review191166 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 16, 2017, 10:21 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63872/ > --- > > (Updated Лис. 16, 2017, 10:21 до полудня) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22460 > https://issues.apache.org/jira/browse/AMBARI-22460 > > > Repository: ambari > > > Description > --- > > Initializing privileged NFS client socket... > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243) > Caused by: java.net.ConnectException: Call From > ctr-e134-1499953498516-310520-01-02.hwx.site/172.27.26.203 to > ctr-e134-1499953498516-310520-01-07.hwx.site:8020 failed on connection > exception: java.net.ConnectException: Connection refused; For more details > see: http://wiki.apache.org/hadoop/ConnectionRefused > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native > Method) > at > sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at java.lang.reflect.Constructor.newInstance(Constructor.java:423) > at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:801) > at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:732) > at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1558) > at org.apache.hadoop.ipc.Client.call(Client.java:1498) > at org.apache.hadoop.ipc.Client.call(Client.java:1398) > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233) > at com.sun.proxy.$Proxy13.getFileInfo(Unknown Source) > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:823) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:291) > at > org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:203) > at > org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:185) > at com.sun.proxy.$Proxy14.getFileInfo(Unknown Source) > at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:2165) > at > org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1442) > at > org.apache.hadoop.hdfs.DistributedFileSystem$26.doCall(DistributedFileSystem.java:1438) > at > org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) > at > org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1454) > at org.apache.hadoop.fs.FileSystem.resolvePath(FileSystem.java:770) > at > org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.addExports(RpcProgramMountd.java:107) > at > org.apache.hadoop.hdfs.nfs.mount.RpcProgramMountd.(RpcProgramMountd.java:94) > at org.apache.hadoop.hdfs.nfs.mount.Mountd.(Mountd.java:37) > at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.(Nfs3.java:47) > at org.apache.hadoop.hdfs.nfs.nfs3.Nfs3.startService(Nfs3.java:67) > at > org.apache.hadoop.hdfs.nfs.nfs3.PrivilegedNfsGatewayStarter.start(PrivilegedNfsGatewayStarter.java:71) > ... 5 more > Caused by: java.net.ConnectException: Connection refused > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > at > sun.ni
Review Request 63819: Ambari Infra, AMS, LogSearch are missing from list of services to be installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63819/ --- Review request for Ambari and Jayush Luniya. Bugs: AMBARI-22447 https://issues.apache.org/jira/browse/AMBARI-22447 Repository: ambari Description --- Ambari Infra service is missing from list of services to be installed, This is one of the necessary services for Atlas and Ranger, other-wise need to setup Solr manually. Diffs - ambari-server/src/main/resources/stacks/HDP/3.0/services/AMBARI_INFRA/metainfo.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/3.0/services/AMBARI_METRICS/metainfo.xml PRE-CREATION ambari-server/src/main/resources/stacks/HDP/3.0/services/LOGSEARCH/metainfo.xml PRE-CREATION Diff: https://reviews.apache.org/r/63819/diff/1/ Testing --- Thanks, Vitalyi Brodetskyi
Review Request 63742: Add service dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63742/ --- Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar. Bugs: AMBARI-22345 https://issues.apache.org/jira/browse/AMBARI-22345 Repository: ambari Description --- Second part of patch. Did some code cleanup. Also reimplemented API and BE to use sevice dependency id. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java afdfcc4 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java 97fe502 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java d8d89da ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java 0eeb19b ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 976bb67 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDependencyEntity.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 27d37e3 ambari-server/src/main/java/org/apache/ambari/server/state/Service.java c4c2d84 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java bfb04be ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 755a80f ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e1e7c9e ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b438e69 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql aab7f95 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8832818 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 135707b ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 7d93aad ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 Diff: https://reviews.apache.org/r/63742/diff/1/ Testing --- Thanks, Vitalyi Brodetskyi
Re: Review Request 63701: Upstart is not able to stop the ambari-agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63701/#review190586 --- Ship it! Ship It! - Vitalyi Brodetskyi On Ноя. 9, 2017, 2:08 п.п., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63701/ > --- > > (Updated Ноя. 9, 2017, 2:08 п.п.) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22398 > https://issues.apache.org/jira/browse/AMBARI-22398 > > > Repository: ambari > > > Description > --- > > While starting ambari-agent using "service ambari-agent start" it works fine > but when we used try to check status using "start ambari-agent" (upstart > command) facing issue. But when we start ambari agent using "start ambari- > agent" it's works but at this time when we checked status using service > command facing issue. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/AmbariAgent.py 28b9528e47 > > > Diff: https://reviews.apache.org/r/63701/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63464/#review190585 --- Ship it! Ship It! - Vitalyi Brodetskyi On Ноя. 1, 2017, 12:43 п.п., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63464/ > --- > > (Updated Ноя. 1, 2017, 12:43 п.п.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22346 > https://issues.apache.org/jira/browse/AMBARI-22346 > > > Repository: ambari > > > Description > --- > > PROBLEM: > beeline connection to HS2 hangs when hive metastore Database is down. > Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2 > beeline doesn't hangs. > > BUSINESS IMPACT: > Ambari spawning multiple beeline processes thats hanging causes unnecessary > memory usage, resulting in master service failures. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py > 3560bf82f5 > > > Diff: https://reviews.apache.org/r/63464/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 63653: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63653/ --- (Updated Лис. 9, 2017, 12:16 до полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi Radhakrishnan, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Added id column for service group dependency. Tested and fixed cross cluster mapping Did some code cleanup P.S. I've added changes only for postgres .sql file. After First review, if main part is ok, i will add changes and test other dbs. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java 0638a06 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java e9cf937 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java 78610d2 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java 63e78d6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 1bcdd80 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 2193c3a ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 3d59c96 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 7737c0d ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 881f172 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 36ff3b7 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 70a6543 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7c5f0fd ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 870555d ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 641b959 ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 Diff: https://reviews.apache.org/r/63653/diff/2/ Changes: https://reviews.apache.org/r/63653/diff/1-2/ Testing --- Thanks, Vitalyi Brodetskyi
Review Request 63653: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63653/ --- Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi Radhakrishnan, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Added id column for service group dependency. Tested and fixed cross cluster mapping Did some code cleanup P.S. I've added changes only for postgres .sql file. After First review, if main part is ok, i will add changes and test other dbs. Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java 0638a06 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java e9cf937 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java 78610d2 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java 63e78d6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 1bcdd80 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 2193c3a ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 3d59c96 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 7737c0d ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 881f172 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 Diff: https://reviews.apache.org/r/63653/diff/1/ Testing --- Thanks, Vitalyi Brodetskyi
Re: Review Request 63444: A bunch of alerts fails due to absence of configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63444/#review190142 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 2, 2017, 1:31 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63444/ > --- > > (Updated Лис. 2, 2017, 1:31 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-22341 > https://issues.apache.org/jira/browse/AMBARI-22341 > > > Repository: ambari > > > Description > --- > > Previously we had a bug/hack where alerts used some configurations (like > hostLevelParams,commandParams etc.) from the information saved by status > commands. > > Now the achitecture changed, we don't have this hack in place anymore. This > requires a non-hacky solution. Meaning alerts should be able to access > configurations outside of 'configurations' dictionary. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py > 3e2a55b849 > ambari-agent/src/main/python/ambari_agent/ClusterCache.py b924420f8b > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > 77ca4c1852 > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 1cf02d1e67 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py 2c8021844f > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 79a686ff66 > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py da49d2ac35 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 36425500dd > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 301e4401f9 > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 0e400f75e3 > > > Diff: https://reviews.apache.org/r/63444/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 63504: Changing hostname causes ambari-agent start to fail
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63504/#review189912 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 2, 2017, 11:09 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63504/ > --- > > (Updated Лис. 2, 2017, 11:09 до полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-22349 > https://issues.apache.org/jira/browse/AMBARI-22349 > > > Repository: ambari > > > Description > --- > > [root@gc6401 ~]# ambari-agent restart > Restarting ambari-agent > Verifying Python version compatibility... > Using python /usr/bin/python > ambari-agent is not running. No PID found at > /var/run/ambari-agent/ambari-agent.pid > Verifying Python version compatibility... > Using python /usr/bin/python > Checking for previously running Ambari Agent... > Checking ambari-common dir... > Starting ambari-agent > /var/lib/ambari-agent/bin/ambari-agent: line 185: 10328 Killed > nohup $PYTHON $AMBARI_AGENT_PY_SCRIPT "$@" > $OUTFILE 2>&1 > Verifying ambari-agent process status... > ERROR: ambari-agent start failed. For more details, see > /var/log/ambari-agent/ambari-agent.out: > > self.topology_cache = > ClusterTopologyCache(self.config.cluster_cache_dir, self.config) > File > "/usr/lib/python2.6/site-packages/ambari_agent/ClusterTopologyCache.py", line > 50, in __init__ > super(ClusterTopologyCache, self).__init__(cluster_cache_dir) > File "/usr/lib/python2.6/site-packages/ambari_agent/ClusterCache.py", > line 72, in __init__ > self.rewrite_cache(cache_dict, self.hash) > File "/usr/lib/python2.6/site-packages/ambari_agent/ClusterCache.py", > line 98, in rewrite_cache > self.on_cache_update() > File > "/usr/lib/python2.6/site-packages/ambari_agent/ClusterTopologyCache.py", line > 75, in on_cache_update > current_host_id = self.current_host_ids_to_cluster[cluster_id] > KeyError: '2' > > Agent out at: /var/log/ambari-agent/ambari-agent.out > Agent log at: /var/log/ambari-agent/ambari-agent.log > > > This happens because topology contains invalid hostname and cannot be loaded > correctly. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py > e7ad8d255f > > > Diff: https://reviews.apache.org/r/63504/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Review Request 63457: Add service dependencies
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/
---
Review request for Ambari, Jayush Luniya and Swapan Shridhar.
Bugs: AMBARI-22345
https://issues.apache.org/jira/browse/AMBARI-22345
Repository: ambari
Description
---
API:
{code}
POST
http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
Request
{
"ServiceInfo" : {
"service_name" : "{service-name}",
"service_display_name" : "{service-display-name}",
"service_version" : "{service-version}",
"stack_id" : "{stack-id}",
"hosting_platform" : "Ambari|Yarn"
}
"dependencies" : [
{
"ServiceInfo" : {
"service_id" : "{dependent-service-id}",
"cluster_id" : "{dependent-cluster-id}",
"service_group_id" : "{dependent-service-group-id}",
}
}
]
}
{code}
DB:
Add table {{servicedependencies}}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
737b9b4
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
8255674
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
cb0ad20
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
3117186
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
f75a7d5
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
b8c1674
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
cfab185
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
6a76fff
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
9fca099
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
8fd878e
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
b9ab79f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
b48d825
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
167e4ca
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
1e4d81f
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
0434728
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c
Diff: https://reviews.apache.org/r/63457/diff/1/
Testing
---
Thanks,
Vitalyi Brodetskyi
Re: Review Request 63411: PERF stack: UI hangs to 2nd step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63411/#review189594 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 30, 2017, 3:15 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63411/ > --- > > (Updated Жов. 30, 2017, 3:15 після полудня) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22335 > https://issues.apache.org/jira/browse/AMBARI-22335 > > > Repository: ambari > > > Description > --- > > Since PU Ambari UI relies on getting repositories info solely from > hdp_urlinfo.json which are not present for PERF stack. > > > Diffs > - > > ambari-server/src/main/resources/stacks/PERF/1.0/hdp_urlinfo.json > PRE-CREATION > ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml > 0895fabe56 > ambari-server/src/main/resources/stacks/PERF/1.0/vdf.xml PRE-CREATION > ambari-server/src/main/resources/stacks/PERF/2.0/hdp_urlinfo.json > PRE-CREATION > ambari-server/src/main/resources/stacks/PERF/2.0/repos/repoinfo.xml > 5c3b40b7e5 > ambari-server/src/main/resources/stacks/PERF/2.0/vdf.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/63411/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 63412: Alerts UPDATE/DELETE should work deleting and adding a cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63412/#review189593 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 30, 2017, 3:15 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63412/ > --- > > (Updated Жов. 30, 2017, 3:15 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-22336 > https://issues.apache.org/jira/browse/AMBARI-22336 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py > 914f453de6 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > eb6737adb2 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 8fe6583903 > ambari-server/src/main/resources/custom_actions/scripts/check_host.py > e610307249 > ambari-server/src/main/resources/stacks/PERF/1.0/repos/repoinfo.xml > 0895fabe56 > ambari-server/src/main/resources/stacks/PERF/2.0/repos/repoinfo.xml > 5c3b40b7e5 > contrib/utils/perf/deploy-gce-perf-cluster.py 7431ae9d7a > > > Diff: https://reviews.apache.org/r/63412/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 25, 2017, 11:18 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 737b9b4 ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java 13bdd7b ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java 1e2eaf4 ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 3117186 ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java f75a7d5 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java b8c1674 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java cfab185 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a76fff ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1e4d81f ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/8/ Changes: https://reviews.apache.org/r/63051/diff/7-8/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63289: Spark history server is stopped (with umask 027 and custom spark log/pid dir)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63289/#review189177 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 25, 2017, 8:17 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63289/ > --- > > (Updated Жов. 25, 2017, 8:17 до полудня) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22303 > https://issues.apache.org/jira/browse/AMBARI-22303 > > > Repository: ambari > > > Description > --- > > STR: > > 1. Deploy HDP 2.4.3.0-227 on Ambari 2.5.2.0 without Spark > 2. Enable NN HA > 3. Upgrade Ambari to 2.6.0.0 > 4. Register install and perform RU to 2.6.3.0-220 > 5. Add Spark service > 6. Wait for some time. > Result: Spark History server is stopped. > > Cluster: 172.27.62.82:8080 - nat-yc-r6-pgos-ambari-hv-r-upg-1 - 48h. > > Artifacts: <http://logserver.eng.hortonworks.com/?prefix=qelogs/nat/70440 > /ambari-hv-r-upg/split-1/nat-yc-r6-pgos-ambari- > hv-r-upg-1/artifacts/ctr-e134-1499953498516-250582-01-14.hwx.site/artifacts/screenshots/com.hw.ambari.ui.tests.monitoring.admin_page.rolling_express_upgrade.TestRegisterAndInstallNewStackVersion/test130_AddService/_24_10_27_28_Component__Spark_History_Server__not_started_on_host_ctr_e134_1499953498516_250582_01_0/> > > Spark logs: <http://logserver.eng.hortonworks.com/?prefix=qelogs/nat/70440 > /ambari-hv-r-upg/split-1/nat-yc-r6-pgos-ambari-hv-r-upg-1/var- > logs/spark/ctr-e134-1499953498516-250582-01-02.hwx.site/> > > From Spark.out > > > > > The reported blocks 1677 has reached the threshold 0.9900 of total blocks > 1677. The number of live datanodes 5 has reached the minimum number 0. In > safe mode extension. Safe mode will be turned off automatically in 18 seconds. > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkNameNodeSafeMode(FSNamesystem.java:1422) > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2693) > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2582) > at > org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:736) > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:409) > at > org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) > at > org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:640) > at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:982) > at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2351) > at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2347) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1866) > at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2347) > Caused by: org.apache.hadoop.hdfs.server.namenode.SafeModeException: > Cannot create file/spark-history/.342200c3-6e9e-485c-8f08-d998cd9d92aa. Name > node is in safe mode. > The reported blocks 1677 has reached the threshold 0.9900 of total blocks > 1677. The number of live datanodes 5 has reached the minimum number 0. In > safe mode extension. Safe mode will be turned off automatically in 18 seconds. > at > org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkNameNodeSafeMode(FSNamesystem.java:1418) > ... 13 more > , while invoking ClientNamenodeProtocolTranslatorPB.create over > ctr-e134-1499953498516-250582-01-02.hwx.site/172.27.56.143:8020. Retrying > after sleeping for 22256ms. > > > However, the NN is not in safemode state: > > > > > [root@ctr-e134-1499953498516-250582-01-02 ~]# hdfs dfsadmin -safemode > get > Safe mode is OFF in > ctr-e134-1499953498516-250582-01-13.hwx.site/172.27.69.83:8020 > Safe mode is OFF in > ctr-e134-1499953498516-250582-01-02.hwx.site/172.27.56.143:8020 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 19, 2017, 9:12 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/7/ Changes: https://reviews.apache.org/r/63051/diff/6-7/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 19, 2017, 6:03 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/6/ Changes: https://reviews.apache.org/r/63051/diff/5-6/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63051: Add service group dependencies
> On Жов. 19, 2017, 4:31 після полудня, Jayush Luniya wrote: > > Can you add some sample POST, GET APIs? Added them here https://hortonworks.jira.com/browse/BUG-87082 - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188693 --- On Жов. 19, 2017, 2:58 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > --- > > (Updated Жов. 19, 2017, 2:58 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Add table servicegroupdependencies > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/5/ > > > Testing > --- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 19, 2017, 2:58 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/5/ Changes: https://reviews.apache.org/r/63051/diff/4-5/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 19, 2017, 1:55 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/4/ Changes: https://reviews.apache.org/r/63051/diff/3-4/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 18, 2017, 11:59 після полудня) Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/3/ Changes: https://reviews.apache.org/r/63051/diff/2-3/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63051: Add service group dependencies
> On Жов. 18, 2017, 1:43 після полудня, Vitalyi Brodetskyi wrote: > > Ship It! Wrong review request))) - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188485 --- On Жов. 17, 2017, 8:38 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > --- > > (Updated Жов. 17, 2017, 8:38 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Add table servicegroupdependencies > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/2/ > > > Testing > --- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188485 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 17, 2017, 8:38 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > --- > > (Updated Жов. 17, 2017, 8:38 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > --- > > Add table servicegroupdependencies > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/2/ > > > Testing > --- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 63071: A bunch of services fail to start
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63071/#review188484 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 17, 2017, 11:32 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63071/ > --- > > (Updated Жов. 17, 2017, 11:32 до полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-22251 > https://issues.apache.org/jira/browse/AMBARI-22251 > > > Repository: ambari > > > Description > --- > > Test full stack deployment and find services which fail to > install/start/service_check. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py > af11cc534e > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 8813243030 > > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py > 12356ed3b3 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > aed635e329 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py > e039606ae4 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/params.py > b01884c6ec > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py > 6590478aa3 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py > afbbb5f38a > > ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py > 8cb7a0b6a5 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py > 79bfd62a0e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 58b44c424a > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 3b4ab30382 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py > fff1167c18 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > c733ddbfeb > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py > c18e422c0a > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py > 937c4b572d > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > e46ce7831d > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/params.py > 0f2acca3bb > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/package/scripts/status_params.py > 8a840fb3c2 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 16c59ca061 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_linux.py > b12ffefb45 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/params_windows.py > 631146d2e1 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/status_params.py > 699d9a847e > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > 64d7c5a8ec > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py > b090e9885f > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py > 1e968a3d0d > > ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py > 156db10f6d > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py > 63cee09b7c > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py > 1d36a75c8c > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 2d6469cca9 > > ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py > 664c582262 > > ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/status_params.py > 7d97203e51 > > ambari-
Re: Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- (Updated Жов. 17, 2017, 8:38 після полудня) Review request for Ambari, Jayush Luniya and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java fcc07b6 ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 0434728 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c Diff: https://reviews.apache.org/r/63051/diff/2/ Changes: https://reviews.apache.org/r/63051/diff/1-2/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 63080: Smartsense requires HDFS to be always present while installing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63080/#review188332
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Жов. 17, 2017, 5:15 після полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63080/
> ---
>
> (Updated Жов. 17, 2017, 5:15 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-22256
> https://issues.apache.org/jira/browse/AMBARI-22256
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Smartsense cannot be installed without HDFS in the cluster.
> I am getting the below exception
>
>
>
>
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
> line 43, in
> BeforeStartHook().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 367, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
> line 29, in hook
> import params
> File
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py",
> line 331, in
> if "core-site" in config['configurations'] and namenode_rpc:
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
> line 73, in __getattr__
> raise Fail("Configuration parameter '" + self.name + "' was not found
> in configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter
> 'fs.defaultFS' was not found in configurations dictionary!
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
> 55a609328e
>
>
> Diff: https://reviews.apache.org/r/63080/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Review Request 63051: Add service group dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/ --- Review request for Ambari, Jayush Luniya and Swapan Shridhar. Bugs: AMBARI-22249 https://issues.apache.org/jira/browse/AMBARI-22249 Repository: ambari Description --- Add table servicegroupdependencies Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java 1e2eaf4 ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java 53c3d1e ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java 147650c ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java 2e935af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java 7f8facb ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 8fd878e ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 9850462 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java 7146bdf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java 735a946 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 3bde889 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 Diff: https://reviews.apache.org/r/63051/diff/1/ Testing --- Will fix tests after patch approve Thanks, Vitalyi Brodetskyi
Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links
> On Жов. 11, 2017, 8:43 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > > Lines 1075 (patched) > > <https://reviews.apache.org/r/62895/diff/1/?file=1852428#file1852428line1075> > > > > Why not set quickLinksConfigurations itself? The same as for themes. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187697 --- On Жов. 11, 2017, 4:17 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62895/ > --- > > (Updated Жов. 11, 2017, 4:17 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi > Radhakrishnan. > > > Bugs: AMBARI-22209 > https://issues.apache.org/jira/browse/AMBARI-22209 > > > Repository: ambari > > > Description > --- > > Fix quick links in mpacks. > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 1cad4df > > > Diff: https://reviews.apache.org/r/62895/diff/1/ > > > Testing > --- > > will check tests after approve > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links
> On Жов. 11, 2017, 8:43 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > > Lines 1037 (patched) > > <https://reviews.apache.org/r/62895/diff/1/?file=1852428#file1852428line1037> > > > > Why not set themes itself instead of themeList? As of now we are not reading themes/quicklinks from metainfo. But we have a code which set themesMap/quicklinksMap with related data. This data is the result of merge for all stack versions. We have inheritence for many components in metainfo like (osspecific packages, quick links, themes and other). The same behaviour you can see for OsSpecific in ServiceInfo. So it will be more correctly to use merged data. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187697 --- On Жов. 11, 2017, 4:17 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62895/ > --- > > (Updated Жов. 11, 2017, 4:17 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi > Radhakrishnan. > > > Bugs: AMBARI-22209 > https://issues.apache.org/jira/browse/AMBARI-22209 > > > Repository: ambari > > > Description > --- > > Fix quick links in mpacks. > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 1cad4df > > > Diff: https://reviews.apache.org/r/62895/diff/1/ > > > Testing > --- > > will check tests after approve > > > Thanks, > > Vitalyi Brodetskyi > >
Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/ --- Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi Radhakrishnan. Bugs: AMBARI-22209 https://issues.apache.org/jira/browse/AMBARI-22209 Repository: ambari Description --- Fix quick links in mpacks. Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 1cad4df Diff: https://reviews.apache.org/r/62895/diff/1/ Testing --- will check tests after approve Thanks, Vitalyi Brodetskyi
Re: Review Request 62888: ZKFC start failed due to hadoop-hdfs-zkfc is not supported
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62888/#review187649
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Жов. 11, 2017, 12:29 після полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62888/
> ---
>
> (Updated Жов. 11, 2017, 12:29 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-22203
> https://issues.apache.org/jira/browse/AMBARI-22203
>
>
> Repository: ambari
>
>
> Description
> ---
>
> 1\. HDP-2.4.3.0-227 is installed on Ambari-2.5.2.0 (with HA)
> 2\. Ambari is upgraded to Ambari-2.6.0.0
> 3\. Code tries to get version of zkfc from hdp-select to advertise it. However
> hdp-select 2.4.3.0 does not support zkfc package
>
>
>
> [root@aonishuk-gc6402-1 yum.repos.d]# rpm -q hdp-select
> hdp-select-2.4.3.0-227.el6.noarch
> [root@aonishuk-gc6402-1 yum.repos.d]# hdp-select packages | grep zkfc
> [root@aonishuk-gc6402-1 yum.repos.d]#
>
>
> vs
>
>
>
> [root@natr76-nbzs-dgtofnmlevelha-r7-1 ~]# rpm -q hdp-select
> hdp-select-2.5.3.0-37.el6.noarch
> [root@natr76-nbzs-dgtofnmlevelha-r7-1 ~]# hdp-select packages | grep zkfc
> hadoop-hdfs-zkfc
>
>
>
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py",
> line 43, in
> BeforeStartHook().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 374, in execute
> self.save_component_version_to_structured_out(self.command_name)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 244, in save_component_version_to_structured_out
> stack_select_package_name = stack_select.get_package_name()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
> line 109, in get_package_name
> package = get_packages(PACKAGE_SCOPE_STACK_SELECT, service_name,
> component_name)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/stack_select.py",
> line 234, in get_packages
> raise Fail("The package {0} is not supported by this version of the
> stack-select tool.".format(package))
> resource_management.core.exceptions.Fail: The package hadoop-hdfs-zkfc is
> not supported by this version of the stack-select tool.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
> 2db0a74195
>
>
> Diff: https://reviews.apache.org/r/62888/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 62808: hadooplzo package installation failed on devdeploys
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62808/#review187515 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 10, 2017, 11:05 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62808/ > --- > > (Updated Жов. 10, 2017, 11:05 до полудня) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22160 > https://issues.apache.org/jira/browse/AMBARI-22160 > > > Repository: ambari > > > Description > --- > > Packages which installed via install_packages used different code to get > package version than the one used to get versions of packages during start > (e.g. lzo). > I merged them into a single method. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > a1fd1f37f1 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > 370b776914 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 7091298cbc > > > Diff: https://reviews.apache.org/r/62808/diff/4/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62808: hadooplzo package installation failed on devdeploys
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62808/#review187256 --- Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 6, 2017, 12:53 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62808/ > --- > > (Updated Жов. 6, 2017, 12:53 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22160 > https://issues.apache.org/jira/browse/AMBARI-22160 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 829868e03a > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > 4ade11a1a2 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py c10ff64e0b > > > Diff: https://reviews.apache.org/r/62808/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- (Updated Жов. 5, 2017, 2:22 після полудня) Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi Radhakrishnan, and Sid Wagle. Bugs: AMBARI-22124 https://issues.apache.org/jira/browse/AMBARI-22124 Repository: ambari Description --- We need to move AMS specific logic in the stack advisors to service advisor. Diffs (updated) - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py PRE-CREATION ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py a2e31cc ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 5307176 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 2dc1738 ambari-server/src/test/python/common-services/AMBARI_METRICS/test_service_advisor.py PRE-CREATION ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 65b23b0 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py d6b572e Diff: https://reviews.apache.org/r/62756/diff/4/ Changes: https://reviews.apache.org/r/62756/diff/3-4/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- (Updated Жов. 4, 2017, 9:03 після полудня) Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi Radhakrishnan, and Sid Wagle. Bugs: AMBARI-22124 https://issues.apache.org/jira/browse/AMBARI-22124 Repository: ambari Description --- We need to move AMS specific logic in the stack advisors to service advisor. Diffs (updated) - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py PRE-CREATION ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py a2e31cc ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 5307176 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 2dc1738 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 65b23b0 ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py d6b572e Diff: https://reviews.apache.org/r/62756/diff/3/ Changes: https://reviews.apache.org/r/62756/diff/2-3/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors
> On Жов. 4, 2017, 12:54 до полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > > Lines 21 (patched) > > <https://reviews.apache.org/r/62756/diff/1/?file=1845302#file1845302line21> > > > > Can we also remove the duplicate code in HDP stack advisors? Which code i should remove? If you are talking about all AMS methods (recommendations and validations), i don't think we can remove them. As of now, only HDP 3.0 work with service advisors, all other stacks work with stack advisor. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187037 --- On Жов. 4, 2017, 8:26 до полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62756/ > --- > > (Updated Жов. 4, 2017, 8:26 до полудня) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Sid Wagle. > > > Bugs: AMBARI-22124 > https://issues.apache.org/jira/browse/AMBARI-22124 > > > Repository: ambari > > > Description > --- > > We need to move AMS specific logic in the stack advisors to service advisor. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > a2e31cc > > > Diff: https://reviews.apache.org/r/62756/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors
> On Жов. 4, 2017, 12:49 до полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > > Line 77 (original), 77 (patched) > > <https://reviews.apache.org/r/62756/diff/1/?file=1845303#file1845303line77> > > > > Is this change to ATLAS service advisor supposed to be part of the > > patch? Just found this little part of missed code during work on service advisor for AMS. Decided to add it here because change is trivial. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187036 ------- On Жов. 4, 2017, 8:26 до полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62756/ > --- > > (Updated Жов. 4, 2017, 8:26 до полудня) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Sid Wagle. > > > Bugs: AMBARI-22124 > https://issues.apache.org/jira/browse/AMBARI-22124 > > > Repository: ambari > > > Description > --- > > We need to move AMS specific logic in the stack advisors to service advisor. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > a2e31cc > > > Diff: https://reviews.apache.org/r/62756/diff/2/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- (Updated Жов. 4, 2017, 8:26 до полудня) Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi Radhakrishnan, and Sid Wagle. Bugs: AMBARI-22124 https://issues.apache.org/jira/browse/AMBARI-22124 Repository: ambari Description --- We need to move AMS specific logic in the stack advisors to service advisor. Diffs (updated) - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py PRE-CREATION ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py a2e31cc Diff: https://reviews.apache.org/r/62756/diff/2/ Changes: https://reviews.apache.org/r/62756/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 62756: Refactor AMS logic in stack advisors to service advisors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. Bugs: AMBARI-22124 https://issues.apache.org/jira/browse/AMBARI-22124 Repository: ambari Description --- We need to move AMS specific logic in the stack advisors to service advisor. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py PRE-CREATION ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py a2e31cc Diff: https://reviews.apache.org/r/62756/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 51198: Hsi-Hs2: Mondrian tests intermittently fail with "java.io.IOException: Connection reset by peer"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51198/#review186837 --- Ship it! Ship It! - Vitalyi Brodetskyi On Сер. 18, 2016, 9:27 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51198/ > --- > > (Updated Сер. 18, 2016, 9:27 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18194 > https://issues.apache.org/jira/browse/AMBARI-18194 > > > Repository: ambari > > > Description > --- > > I'd reported this issue previously in > not see this due to its intermitent nature. > In yesterdays nightly, around 8 tests had failed with this issue and on rerun > 48 failed. Hs2 logs are below: > > > > > 2016-08-17T07:28:55,479 INFO [HiveServer2-Background-Pool: Thread-6508]: > SessionState (SessionState.java:printInfo(1075)) - Status: Running (Executing > on YARN cluster with App id application_1471417242320_0006) > > Map 1: 1/1 Reducer 2: 0(+1)/1 Reducer 3: 0/1 > 2016-08-17T07:28:55,480 INFO [HiveServer2-Background-Pool: Thread-6508]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: > 0(+1)/1 Reducer 3: 0/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1)/1 > 2016-08-17T07:28:55,681 INFO [HiveServer2-Background-Pool: Thread-6508]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1,-2)/1 > 2016-08-17T07:28:58,422 INFO [HiveServer2-Background-Pool: Thread-6503]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1,-2)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1,-1)/1 > 2016-08-17T07:28:58,422 INFO [HiveServer2-Background-Pool: Thread-6507]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1,-1)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1)/1 > 2016-08-17T07:28:58,955 INFO [HiveServer2-Background-Pool: Thread-6508]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1,-1)/1 > 2016-08-17T07:29:00,566 INFO [HiveServer2-Background-Pool: Thread-6508]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1,-1)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1,-3)/1 > 2016-08-17T07:29:00,633 INFO [HiveServer2-Background-Pool: Thread-6503]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1,-3)/1 > Map 1: 1/1 Reducer 2: 1/1 Reducer 3: 0(+1,-2)/1 > 2016-08-17T07:29:00,635 INFO [HiveServer2-Background-Pool: Thread-6507]: > SessionState (SessionState.java:printInfo(1075)) - Map 1: 1/1 Reducer 2: 1/1 > Reducer 3: 0(+1,-2)/1 > Status: Failed > 2016-08-17T07:29:00,708 ERROR [HiveServer2-Background-Pool: Thread-6503]: > SessionState (SessionState.java:printError(1084)) - Status: Failed > Vertex failed, vertexName=Reducer 3, > vertexId=vertex_1471417242320_0005_293_02, diagnostics=[Task failed, > taskId=task_1471417242320_0005_293_02_00, diagnostics=[TaskAttempt 0 > failed, info=[Error: Error while running task ( failure ) : > attempt_1471417242320_0005_293_02_00_0:java.lang.RuntimeException: > java.lang.RuntimeException: Hive Runtime Error while closing operators: > java.io.IOException: Connection reset by peer > at > org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:211) > at > org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:168) > at > org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:370) > at > org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:73) > at > org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724) > at > org.apache
Re: Review Request 61841: Ensure topology_mappings.data has 0644 permissions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61841/#review186836 --- Ship it! Ship It! - Vitalyi Brodetskyi On None, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61841/ > --- > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-21788 > https://issues.apache.org/jira/browse/AMBARI-21788 > > > Repository: ambari > > > Description > --- > > In restricted umask environments, the topology_metadata.data file is created > but the permission bits are stripped off and that results in jobs running with > the default rack. A workaround is available to manually change permissions for > this file on each host, but it is not optimal. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py > 548f051 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py > 4f62ace > > > Diff: https://reviews.apache.org/r/61841/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62669: Make dfs.permissions.superusergroup as group property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62669/#review186577 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 28, 2017, 4:53 після полудня, Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62669/ > --- > > (Updated Вер. 28, 2017, 4:53 після полудня) > > > Review request for Ambari, Robert Levas and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22086 > https://issues.apache.org/jira/browse/AMBARI-22086 > > > Repository: ambari > > > Description > --- > > hdfs user must be added to hdfs superuser group explicitly and > dfs.permissions.superusergroup must be maked as group to allow to add other > users(from mpacks, for example) to hdfs superuser gorup. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > 0f36e0b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml > 4eab367 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > 4154007 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-site.xml > a4fed0f > > > Diff: https://reviews.apache.org/r/62669/diff/1/ > > > Testing > --- > > mnv clean test, cluster deploy > > > Thanks, > > Eugene Chekanskiy > >
Re: Review Request 62667: Zeppelin start failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62667/#review186570
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Вер. 28, 2017, 3:59 після полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62667/
> ---
>
> (Updated Вер. 28, 2017, 3:59 після полудня)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-22085
> https://issues.apache.org/jira/browse/AMBARI-22085
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.7.0/package/scripts/master.py",
> line 577, in
> Master().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 350, in execute
> method(env)
> File
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.7.0/package/scripts/master.py",
> line 264, in start
> self.reset_interpreter_settings()
> File
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.7.0/package/scripts/master.py",
> line 288, in reset_interpreter_settings
> config_data = self.get_interpreter_settings()
> File
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.7.0/package/scripts/master.py",
> line 336, in get_interpreter_settings
> raise Fail
> resource_management.core.exceptions.Fail
>
>
>
> 2017-09-28 10:47:50,390 - Execute['/usr/bin/kinit -kt
> /etc/security/keytabs/hdfs.headless.keytab cstm-h...@example.com'] {'user':
> 'cstm-zeppelin'}
> Error getting interpreter.json from HDFS
> ("Execution of '/usr/bin/kinit -kt
> /etc/security/keytabs/hdfs.headless.keytab cstm-h...@example.com' returned 1.
> Hortonworks #\nThis is MOTD message, added for testing
> in qe infra\nkinit: Generic preauthentication failure while getting initial
> credentials",)
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
> af5758a6c5
>
>
> Diff: https://reviews.apache.org/r/62667/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
> On Вер. 27, 2017, 1:28 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py > > Line 246 (original) > > <https://reviews.apache.org/r/62599/diff/1/?file=1836301#file1836301line246> > > > > Lets also fix the Ganglia configs. Jayush, i decided not to fix ganglia. Because in ganglia-env we don't have user property, only group. And in ganlia code they are using group property for both cases, for user and for group. So to fix it, i should add new user property, change the code and test ganglia. It's a waist of time according to fact that we don't using it in ambari. And one more thing, we don't have packages for it. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186408 --- On Вер. 27, 2017, 9:52 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Вер. 27, 2017, 9:52 після полудня) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml > b2d60c6 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > 7748176 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml > 0f67356 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > cc62c8b > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml > ff44901 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuratio
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
/mapred-env.xml 93e5234 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 4e722ee ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml fb3b512 ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-env.xml 85373e0 ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml 5a1529d ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 55b9cd3 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 4d92dbe ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml 5bd1017 ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml ebebf82 ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml fee24bb ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml 23a4cc1 ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 94b1d57 ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 1b903b1 ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py eb5feae Diff: https://reviews.apache.org/r/62599/diff/2/ Changes: https://reviews.apache.org/r/62599/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62599: Remove user to group hardcoded logic in hooks
> On Вер. 27, 2017, 12:20 до полудня, Madhuvanthi Radhakrishnan wrote: > > Hi Vitaly, > > Kindly refer https://reviews.apache.org/r/56727/ to check the value of > > user_groups attribute. > > For eg: > > /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > > > > zeppelin_user > > zeppelin > > USER > > User zeppelin daemon runs as > > > > user > > false > > > > > > zeppelin-env > > zeppelin_group > > > > > > hadoop-env > > proxyuser_group > > > > > > > > > > > > > > Here, the user-group tag is able to tell the mapping between > > (zeppelin_group property in zeppellin-env file and proxyuser_group property > > in hadoop-env file) with the zeppelin_user. > > You can follow a similar pattern for the other services. > > Thanks for doing this. > > Jayush Luniya wrote: > @Madhu > I think we renamed to in the final patch. Can > you confirm? Jayush, you are right. I've tested my patch and it works with - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186348 --- On Вер. 26, 2017, 11:23 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Вер. 26, 2017, 11:23 після полудня) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > --- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml
Review Request 62599: Remove user to group hardcoded logic in hooks
/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml 4e722ee ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml fb3b512 ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-env.xml 85373e0 ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml 5a1529d ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 55b9cd3 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 4d92dbe ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml 5bd1017 ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml ebebf82 ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml fee24bb ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml 23a4cc1 ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 94b1d57 ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 1b903b1 ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py eb5feae Diff: https://reviews.apache.org/r/62599/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62500: File "hdfs.headless.keytab" has incorrect permission
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62500/#review185966 --- Ship it! Ship It! - Vitalyi Brodetskyi On Сен. 22, 2017, 10:31 д.п., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62500/ > --- > > (Updated Сен. 22, 2017, 10:31 д.п.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22039 > https://issues.apache.org/jira/browse/AMBARI-22039 > > > Repository: ambari > > > Description > --- > > **Actual result:** Zeppelin Notebook can not start due to file > "hdfs.headless.keytab" has incorrect permission. > > > > -r. 1 cstm-hdfs hadoop 313 ??? 21 05:32 > /etc/security/keytabs/hdfs.headless.keytab > > > Changed permission by hands the Zeppelin Notebook successfully started. > Cluster: > > > > > http://172.27.52.205:8080 > > > Job for reproduce : > > > > > > http://linux-jenkins.qe.hortonworks.com:8080/job/Nightly-Start-EC2-Run-HDP/641939/ > > > Artifacts: > > > > > > https://testqelog.s3.amazonaws.com/qelogs/index.html?prefix=qelogs/nat/65233/stackdeploy/split-1/nat-yc-r6o12-stackdeploy/ > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > 7d44d16 > > > Diff: https://reviews.apache.org/r/62500/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62431: Ambari schema upgrade failure as views destination path dir already exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62431/#review185777 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 20, 2017, 8:15 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62431/ > --- > > (Updated Вер. 20, 2017, 8:15 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-22003 > https://issues.apache.org/jira/browse/AMBARI-22003 > > > Repository: ambari > > > Description > --- > > Upgrade path from 2.5.10 to 2.6.0.0-107 > Error seen from the output of "ambari-server upgrade --verbose" > > > > > [ERROR STREAM] > > Traceback (most recent call last): > File "/usr/sbin/ambari-server.py", line 950, in > mainBody() > File "/usr/sbin/ambari-server.py", line 920, in mainBody > main(options, args, parser) > File "/usr/sbin/ambari-server.py", line 872, in main > action_obj.execute() > File "/usr/sbin/ambari-server.py", line 78, in execute > self.fn(*self.args, **self.kwargs) > File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", > line 271, in upgrade > shutil.move(file, root_views_dir) > File "/usr/lib64/python2.6/shutil.py", line 250, in move > raise Error, "Destination path '%s' already exists" % real_dst > shutil.Error: Destination path > '/var/lib/ambari-server/resources/views/work/../work' already exists > > [EXIT CODE] > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverUpgrade.py a10841d > > > Diff: https://reviews.apache.org/r/62431/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62402: Multiple fixes into branch-3.0-perf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62402/#review185662 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 19, 2017, 8:53 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62402/ > --- > > (Updated Вер. 19, 2017, 8:53 до полудня) > > > Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-21989 > https://issues.apache.org/jira/browse/AMBARI-21989 > > > Repository: ambari > > > Description > --- > > * restart triggered by server should gracefully finish operations > * if status command fails, exception should be logged. > * move configs logic from InitializerModule into AmbariConfig, where it > belongs > * fix typo (alert_def*E*nitions into alert_def*I*nitions) > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 94e72c2 > ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 2bd2383 > ambari-agent/src/main/python/ambari_agent/AmbariConfig.py e1c40c8 > ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py c681550 > ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 652574f > ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py > f85ba42 > ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d2 > ambari-agent/src/main/python/ambari_agent/FileCache.py 0e598e9 > ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf > ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py 09ce016 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py 0126250 > ambari-agent/src/main/python/ambari_agent/Utils.py af70d77 > > ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py > 91ae5de > ambari-agent/src/main/python/ambari_agent/main.py 05fc5ce > ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py > 3c571ab > > > Diff: https://reviews.apache.org/r/62402/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/ --- (Updated Вер. 18, 2017, 5:46 після полудня) Review request for Ambari, Dmytro Grinenko, Jayush Luniya, Swapan Shridhar, and Sid Wagle. Bugs: AMBARI-21973 https://issues.apache.org/jira/browse/AMBARI-21973 Repository: ambari Description --- Add tez.runtime.shuffle.ssl.enable=false to tez-interactive-site. Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml c1a42b0 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 5618e14 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 9f77065 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8824de5 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml a6d7a49 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 2a61034 ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml c67e4cf ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml b49fdbf ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml af885e1 Diff: https://reviews.apache.org/r/62364/diff/2/ Changes: https://reviews.apache.org/r/62364/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/ --- Review request for Ambari, Dmytro Grinenko, Jayush Luniya, Swapan Shridhar, and Sid Wagle. Bugs: AMBARI-21973 https://issues.apache.org/jira/browse/AMBARI-21973 Repository: ambari Description --- Add tez.runtime.shuffle.ssl.enable=false to tez-interactive-site. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml c1a42b0 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 75a8782 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 07bc8a4 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 850f725 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 9a42098 ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml ea58559 ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml c67e4cf ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml b49fdbf ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml af885e1 Diff: https://reviews.apache.org/r/62364/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- (Updated Вер. 15, 2017, 3:58 після полудня) Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. Bugs: AMBARI-21856 https://issues.apache.org/jira/browse/AMBARI-21856 Repository: ambari Description --- The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py 32b8038 ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 858a55f ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 89dc126 ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 0735e27 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 88ece8f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java e81d1af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java bad8195 ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java d43bdfa ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 854f03f ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 5e1d5d3 ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 17ded10 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java 8427a1d ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 9f2107d ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 058c45b ambari-server/src/main/resources/version_definition.xsd 832d7f9 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java 18e2d3f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 3a7b19b ambari-server/src/test/python/stacks/2.0.6/configs/default.json f337f41 ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d200 Diff: https://reviews.apache.org/r/61994/diff/5/ Changes: https://reviews.apache.org/r/61994/diff/4-5/ Testing --- test will be fixed after solution will be approved Thanks, Vitalyi Brodetskyi
Re: Review Request 62348: branch-2.6 Builds Fail With Forked VM Error On Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62348/#review185471 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 15, 2017, 6:59 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62348/ > --- > > (Updated Вер. 15, 2017, 6:59 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21964 > https://issues.apache.org/jira/browse/AMBARI-21964 > > > Repository: ambari > > > Description > --- > > All 2.6 builds are failing even though tests report as passing. With each run, > it's a different test that seems to cause the problem, so it's not consistent. > > > > > [INFO] Results: > [INFO] > [WARNING] Tests run: 4802, Failures: 0, Errors: 0, Skipped: 35 > > > This seems to be due to a surefire problem with the JVMs created for the > tests: > > > > > [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, > [date].dumpstream and [date]-jvmRun[N].dumpstream. > [ERROR] ExecutionException The forked VM terminated without properly > saying goodbye. VM crash or System.exit called? > [ERROR] Command was /bin/sh -c cd > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && > /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m > -XX:MaxPermSize=512m -Xms512m -jar > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter1775364586569779113.jar > > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire > 2017-08-23T14-58-45_595-jvmRun1 surefire5302937670169703589tmp > surefire_3565051269905631767801tmp > [ERROR] Error occurred in starting fork, check output in log > [ERROR] Process Exit Code: 1 > [ERROR] Crashed tests: > [ERROR] org.apache.ambari.server.agent.TestHeartbeatHandler > [ERROR] ExecutionException The forked VM terminated without properly > saying goodbye. VM crash or System.exit called? > [ERROR] Command was /bin/sh -c cd > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && > /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m > -XX:MaxPermSize=512m -Xms512m -jar > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter4243280705420804420.jar > > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire > 2017-08-23T14-58-45_595-jvmRun4 surefire5453334563682547339tmp > surefire_3586448350854680944601tmp > [ERROR] Error occurred in starting fork, check output in log > [ERROR] Process Exit Code: 1 > [ERROR] Crashed tests: > [ERROR] org.apache.ambari.server.agent.TestHeartbeatMonitor > [ERROR] ExecutionException The forked VM terminated without properly > saying goodbye. VM crash or System.exit called? > [ERROR] Command was /bin/sh -c cd > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && > /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m > -XX:MaxPermSize=512m -Xms512m -jar > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter7638123946663578882.jar > > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire > 2017-08-23T14-58-45_595-jvmRun2 surefire5447207613794558892tmp > surefire_359575380127168860507tmp > [ERROR] Error occurred in starting fork, check output in log > [ERROR] Process Exit Code: 1 > [ERROR] Crashed tests: > [ERROR] org.apache.ambari.server.agent.HeartbeatProcessorTest > [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: > ExecutionException The forked VM terminated without properly saying goodbye. > VM crash or System.exit called? > [ERROR] Command was /bin/sh -c cd > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server && > /usr/local/asfpackages/java/jdk1.7.0_80/jre/bin/java -Xmx1024m > -XX:MaxPermSize=512m -Xms512m -jar > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire/surefirebooter1775364586569779113.jar > > /home/jenkins/jenkins-slave/workspace/Ambari-branch-2.6/ambari-server/target/surefire > 2017-08-23T14-58-45_595-jvmRun1 surefire5302937670169703589tmp > surefire
Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- (Updated Вер. 14, 2017, 10:47 після полудня) Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. Bugs: AMBARI-21856 https://issues.apache.org/jira/browse/AMBARI-21856 Repository: ambari Description --- The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide. Diffs (updated) - ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py 32b8038 ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 858a55f ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java c78d88d ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 0735e27 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java 88ece8f ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java e81d1af ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java bad8195 ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java d43bdfa ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 854f03f ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 5e1d5d3 ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 17ded10 ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java 8427a1d ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 9f2107d ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 058c45b ambari-server/src/main/resources/version_definition.xsd 832d7f9 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java 18e2d3f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 3a7b19b Diff: https://reviews.apache.org/r/61994/diff/4/ Changes: https://reviews.apache.org/r/61994/diff/3-4/ Testing --- test will be fixed after solution will be approved Thanks, Vitalyi Brodetskyi
Re: Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62278/#review185279 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 13, 2017, 11:17 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62278/ > --- > > (Updated Вер. 13, 2017, 11:17 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21947 > https://issues.apache.org/jira/browse/AMBARI-21947 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 05b395d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 956438e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > eb16778 > > > Diff: https://reviews.apache.org/r/62278/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 62249: Do not export YARN_CONF_DIR in 'yarn-env.sh' file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62249/
---
(Updated Вер. 12, 2017, 4:47 після полудня)
Review request for Ambari, Jayush Luniya and Swapan Shridhar.
Bugs: AMBARI-21936
https://issues.apache.org/jira/browse/AMBARI-21936
Repository: ambari
Description
---
yarn-env.sh exports YARN_CONF_DIR
{code:title=yarn-env.sh}
# resolve links - $0 may be a softlink
export YARN_CONF_DIR="${YARN_CONF_DIR:-$HADOOP_YARN_HOME/conf}"
{code}
This causes in not respecting --config option for yarn daemon.
Hence please remove the export
Diffs (updated)
-
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
aaa72d1
Diff: https://reviews.apache.org/r/62249/diff/2/
Changes: https://reviews.apache.org/r/62249/diff/1-2/
Testing
---
TODO
Thanks,
Vitalyi Brodetskyi
Review Request 62249: Do not export YARN_CONF_DIR in 'yarn-env.sh' file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62249/
---
Review request for Ambari, Jayush Luniya and Swapan Shridhar.
Bugs: AMBARI-21936
https://issues.apache.org/jira/browse/AMBARI-21936
Repository: ambari
Description
---
yarn-env.sh exports YARN_CONF_DIR
{code:title=yarn-env.sh}
# resolve links - $0 may be a softlink
export YARN_CONF_DIR="${YARN_CONF_DIR:-$HADOOP_YARN_HOME/conf}"
{code}
This causes in not respecting --config option for yarn daemon.
Hence please remove the export
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
bfe2a13
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
aaa72d1
ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml
121a81d
Diff: https://reviews.apache.org/r/62249/diff/1/
Testing
---
TODO
Thanks,
Vitalyi Brodetskyi
Re: Review Request 62215: Ambari should honor permissions specified for dfs.datanode.data.dir.perm when creating datanode dir's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62215/#review185069
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Вер. 11, 2017, 10:25 до полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62215/
> ---
>
> (Updated Вер. 11, 2017, 10:25 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21896
> https://issues.apache.org/jira/browse/AMBARI-21896
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Give this:
> property
> namedfs.datanode.data.dir.perm/name
> value750/value
> Ambari reports as changing permission from 750 to 755 on the data dirs:
> 2017-09-01 16:39:28,877 - Forcefully ensuring existence and permissions of the
> directory: /hadoop01/data
> 2017-09-01 16:39:28,878 -
>
> {'group': 'hadoop', 'cd_access': 'a', 'create_parents': True,
> 'ignore_failures': True, 'mode': 0755, 'owner': 'hdfs'}
>
> 2017-09-01 16:39:28,878 - Changing permission for /hadoop01/data from 750 to
> 755
> 2017-09-01 16:39:28,879 - Mount point for directory /hadoop02/data is
> /hadoop02
> 2017-09-01 16:39:28,880 - Forcefully ensuring existence and permissions of the
> directory: /hadoop02/data
> 2017-09-01 16:39:28,880 -
>
> {'group': 'hadoop', 'cd_access': 'a', 'create_parents': True,
> 'ignore_failures': True, 'mode': 0755, 'owner': 'hdfs'}
>
> 2017-09-01 16:39:28,880 - Changing permission for /hadoop02/data from 750 to
> 755
> 2017-09-01 16:39:28,881 - Mount point for directory /hadoop03/data is
> /hadoop03
> 2017-09-01 16:39:28,881 - Forcefully ensuring existence and permissions of the
> directory: /hadoop03/data
> 2017-09-01 16:39:28,882 -
>
> {'group': 'hadoop', 'cd_access': 'a', 'create_parents': True,
> 'ignore_failures': True, 'mode': 0755, 'owner': 'hdfs'}
>
> 2017-09-01 16:39:28,882 - Changing permission for /hadoop03/data from 750 to
> 755
> 2017-09-01 16:39:28,882 - Mount point for directory /hadoop04/data is
> /hadoop04
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
> 1a54be0
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
> 3c01059
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 966254a
>
>
> Diff: https://reviews.apache.org/r/62215/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
> On Вер. 8, 2017, 12:36 після полудня, Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml > > Line 19 (original), 19 (patched) > > <https://reviews.apache.org/r/61994/diff/2/?file=1817744#file1817744line19> > > > > Are we sure we should be changing this to the public json file? Thanks for review. This change will not be added, it's here because i attached patch draft to discuss solution. This change was added automatically during ambari build process. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review184970 --- On Вер. 7, 2017, 8:40 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61994/ > --- > > (Updated Вер. 7, 2017, 8:40 після полудня) > > > Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-21856 > https://issues.apache.org/jira/browse/AMBARI-21856 > > > Repository: ambari > > > Description > --- > > The problem is that Ambari is using the reponame name field as the > distribution when it creates the repo definition file. Since both of these > repos use same distribution (which is a common Debian pattern), they collide. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > 3d96122 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1a022af > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 0735e27 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java > bad8195 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java > 854f03f > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java > 5e1d5d3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java > 17ded10 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 058c45b > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 3a7b19b > > > Diff: https://reviews.apache.org/r/61994/diff/2/ > > > Testing > --- > > test will be fixed after solution will be approved > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
> On Вер. 7, 2017, 8:55 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml > > Lines 95 (patched) > > <https://reviews.apache.org/r/61994/diff/2/?file=1817744#file1817744line95> > > > > We dont need to change it for HDP. For HDP the distribution should > > remain HDP. > > i.e. > > deb http://public-repo-1/ HDP main > > > > KIBANA service in Metron mpack requires setting distribution=stable. > > > > "distribution" should be an optional parameter. sure, i understand this. This patch is draft, to show for reviewers and get some notes. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review184878 ------- On Вер. 7, 2017, 8:40 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61994/ > --- > > (Updated Вер. 7, 2017, 8:40 після полудня) > > > Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-21856 > https://issues.apache.org/jira/browse/AMBARI-21856 > > > Repository: ambari > > > Description > --- > > The problem is that Ambari is using the reponame name field as the > distribution when it creates the repo definition file. Since both of these > repos use same distribution (which is a common Debian pattern), they collide. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > 3d96122 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1a022af > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 0735e27 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java > bad8195 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java > 854f03f > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java > 5e1d5d3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java > 17ded10 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 058c45b > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 3a7b19b > > > Diff: https://reviews.apache.org/r/61994/diff/2/ > > > Testing > --- > > test will be fixed after solution will be approved > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- (Updated Вер. 7, 2017, 4:04 після полудня) Review request for Ambari, Jayush Luniya and Sid Wagle. Bugs: AMBARI-21856 https://issues.apache.org/jira/browse/AMBARI-21856 Repository: ambari Description --- The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java 3d96122 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 1a022af ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java 0735e27 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java bad8195 ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 854f03f ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java 5e1d5d3 ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java 17ded10 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py 058c45b ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java 3a7b19b Diff: https://reviews.apache.org/r/61994/diff/2/ Changes: https://reviews.apache.org/r/61994/diff/1-2/ Testing --- test will be fixed after solution will be approved Thanks, Vitalyi Brodetskyi
Review Request 62121: Fix AmbariServerTest
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62121/
---
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Eugene
Chekanskiy.
Bugs: AMBARI-21891
https://issues.apache.org/jira/browse/AMBARI-21891
Repository: ambari
Description
---
AmbariServerTest fails with:
{code}
Error occurred in starting fork, check output in log
Process Exit Code: 1
Crashed tests:
org.apache.ambari.server.controller.AmbariServerTest
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:494)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:441)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:292)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:243)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1077)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:907)
at
org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:785)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
at org.apache.maven.cli.MavenCli.main(Mave
Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: The
forked VM terminated without properly saying goodbye. VM crash or System.exit
called?
{code}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
f5a7203
Diff: https://reviews.apache.org/r/62121/diff/1/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 62072: Remove hive.custom-extensions.root from Hive Properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/ --- (Updated Вер. 5, 2017, 6:46 після полудня) Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-21876 https://issues.apache.org/jira/browse/AMBARI-21876 Repository: ambari Description --- Remove hive.custom-extensions.root from hive properties. Diffs (updated) - ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 4b53c7c ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 48d1d92 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 29fcac0 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 1d4a6f4 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py 63f6f70 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml c0800ed Diff: https://reviews.apache.org/r/62072/diff/4/ Changes: https://reviews.apache.org/r/62072/diff/3-4/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62072: Remove hive.custom-extensions.root from Hive Properties.
> On Вер. 5, 2017, 5:18 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 379 (patched) > > <https://reviews.apache.org/r/62072/diff/3/?file=1814453#file1814453line379> > > > > Why is this done during Ambari upgrade as well as stack upgrade? The > > presense of this property on existing stack should not cause ay issues > > after Amabri upgrade. Yes. it will not cause any issues. But as i understood, according to first comment in jira "No issues, it’s just a warning. If Ambari sets this config for Hive it should be fixed to not set it; this config does not exist." they don't want hive to throw even WARN messages. And i'm not sure about changes for BigInsight (stack upgrade), probably we don't need them, what do you think? - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/#review184559 ----------- On Вер. 5, 2017, 3:06 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62072/ > --- > > (Updated Вер. 5, 2017, 3:06 після полудня) > > > Review request for Ambari, Andrew Onischuk and Sid Wagle. > > > Bugs: AMBARI-21876 > https://issues.apache.org/jira/browse/AMBARI-21876 > > > Repository: ambari > > > Description > --- > > Remove hive.custom-extensions.root from hive properties. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 5d50f29 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > 4b53c7c > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 48d1d92 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > 29fcac0 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 1d4a6f4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py > 63f6f70 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml > c0800ed > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > d8e8171 > > > Diff: https://reviews.apache.org/r/62072/diff/3/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 62072: Remove hive.custom-extensions.root from Hive Properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/ --- (Updated Вер. 5, 2017, 3:06 після полудня) Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-21876 https://issues.apache.org/jira/browse/AMBARI-21876 Repository: ambari Description --- Remove hive.custom-extensions.root from hive properties. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 5d50f29 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 4b53c7c ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 48d1d92 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 29fcac0 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 1d4a6f4 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py 63f6f70 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml c0800ed ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java d8e8171 Diff: https://reviews.apache.org/r/62072/diff/3/ Changes: https://reviews.apache.org/r/62072/diff/2-3/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62072: Remove hive.custom-extensions.root from Hive Properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/ --- (Updated Вер. 5, 2017, 2:49 після полудня) Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-21876 https://issues.apache.org/jira/browse/AMBARI-21876 Repository: ambari Description --- Remove hive.custom-extensions.root from hive properties. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 5d50f29 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 4b53c7c ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 48d1d92 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 29fcac0 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 1d4a6f4 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py 63f6f70 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml c0800ed ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java d8e8171 Diff: https://reviews.apache.org/r/62072/diff/2/ Changes: https://reviews.apache.org/r/62072/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62058: Deploys failing with MR service check failure due to missing mapreduce.tar.gz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62058/#review184541
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Вер. 4, 2017, 9:44 до полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62058/
> ---
>
> (Updated Вер. 4, 2017, 9:44 до полудня)
>
>
> Review request for Ambari, Di Li and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21872
> https://issues.apache.org/jira/browse/AMBARI-21872
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **Problem:**
>
>
>
> 2017-08-30 01:31:33,674 - ExecuteHadoop['jar
> /usr/hdp/current/hadoop-mapreduce-client/hadoop-mapreduce-examples-3.*.jar
> wordcount /user/ambari-qa/mapredsmokeinput
> /user/ambari-qa/mapredsmokeoutput'] {'bin_dir':
> '/usr/sbin:/sbin:/usr/lib/ambari-server/*:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/var/lib/ambari-agent:/usr/hdp/current/hadoop-client/bin:/usr/hdp/current/hadoop-yarn-client/bin',
> 'conf_dir': '/usr/hdp/current/hadoop-client/conf', 'logoutput': True,
> 'try_sleep': 5, 'tries': 1, 'user': 'ambari-qa'}
> 2017-08-30 01:31:33,675 - Execute['hadoop --config
> /usr/hdp/current/hadoop-client/conf jar
> /usr/hdp/current/hadoop-mapreduce-client/hadoop-mapreduce-examples-3.*.jar
> wordcount /user/ambari-qa/mapredsmokeinput
> /user/ambari-qa/mapredsmokeoutput'] {'logoutput': True, 'try_sleep': 5,
> 'environment': {}, 'tries': 1, 'user': 'ambari-qa', 'path':
> ['/usr/sbin:/sbin:/usr/lib/ambari-server/*:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/var/lib/ambari-agent:/usr/hdp/current/hadoop-client/bin:/usr/hdp/current/hadoop-yarn-client/bin']}
> Hortonworks #
> This is MOTD message, added for testing in qe infra
> 17/08/30 01:31:35 INFO client.RMProxy: Connecting to ResourceManager at
> ctr-e134-1499953498516-113587-01-03.hwx.site/172.27.31.9:8050
> java.io.FileNotFoundException: File does not exist:
> hdfs://ctr-e134-1499953498516-113587-01-03.hwx.site:8020/hdp/apps/3.0.0.0-229/mapreduce/mapreduce.tar.gz
> at org.apache.hadoop.fs.Hdfs.getFileStatus(Hdfs.java:137)
> at
> org.apache.hadoop.fs.AbstractFileSystem.resolvePath(AbstractFileSystem.java:480)
> at org.apache.hadoop.fs.FileContext$25.next(FileContext.java:2191)
> at org.apache.hadoop.fs.FileContext$25.next(FileContext.java:2187)
> at org.apache.hadoop.fs.FSLinkResolver.resolve(FSLinkResolver.java:90)
> at org.apache.hadoop.fs.FileContext.resolve(FileContext.java:2193)
> at org.apache.hadoop.fs.FileContext.resolvePath(FileContext.java:598)
> at
> org.apache.hadoop.mapreduce.JobSubmitter.addMRFrameworkToDistributedCache(JobSubmitter.java:465)
> at
> org.apache.hadoop.mapreduce.JobSubmitter.submitJobInternal(JobSubmitter.java:150)
> at org.apache.hadoop.mapreduce.Job$11.run(Job.java:1344)
>
>
> **Investigation:**
> After starting History Server, (which includes adding mapreduce.tar.gz to
> HDFS), it complains about HDFS_CLIENT not present.
>
>
>
> 2017-09-01 21:16:04,194 - Called copy_to_hdfs tarball: mapreduce
> 2017-09-01 21:16:04,194 - Stack Feature Version Info: Cluster Stack=3.0,
> Command Stack=None, Command Version=3.0.0.0-229 -> 3.0.0.0-229
> 2017-09-01 21:16:04,194 - Tarball version was calcuated as 3.0.0.0-229.
> Use Command Version: True
> 2017-09-01 21:16:04,194 - HDFS_CLIENT is not installed on the host. Skip
> copying /usr/hdp/3.0.0.0-229/hadoop/mapreduce.tar.gz
>
>
> In Ambari-2.5.2 history server host does not have MR client/Hadoop client and
> has MR service check passed.
>
> **Solution:**
> Seems like Ambari checks if a certain component is installed on the cluster
> (like HDFS_CLIENT). However not only HDFS_CLIENT but namenode, datanode,
> nfsgateway, journalnode etc.
> would include tar.gz. We have to check instead if cluster has a service, but
> not that host has a component.
>
>
> Diffs
> -
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
> 795160c
>
>
> Diff: https://reviews.apache.org/r/62058/diff/1/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Review Request 62072: Remove hive.custom-extensions.root from Hive Properties.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/ --- Review request for Ambari, Andrew Onischuk and Sid Wagle. Bugs: AMBARI-21876 https://issues.apache.org/jira/browse/AMBARI-21876 Repository: ambari Description --- Remove hive.custom-extensions.root from hive properties. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 5d50f29 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 4b53c7c ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 48d1d92 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 29fcac0 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 1d4a6f4 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py 63f6f70 ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml c0800ed Diff: https://reviews.apache.org/r/62072/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 62026: ambari-server upgrade process still puts the new views jar to default location even if views.dir is customized in ambari.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62026/#review184348 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 1, 2017, 8:14 до полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62026/ > --- > > (Updated Вер. 1, 2017, 8:14 до полудня) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-21684 > https://issues.apache.org/jira/browse/AMBARI-21684 > > > Repository: ambari > > > Description > --- > > "ambari-server upgrade" process still puts the new views jar to default > location even if views.dir is customized in ambari.properties > > Tested with Ambari 2.2.1 to upgrade to Ambari 2.4.0. > > Steps to reproduce: > > 1\. Stop Ambari Server. > 2\. Move /var/lib/ambari-server/resources/views to a new custom directory. > 3\. Add views.dir property in ambari.properties with above custom directory as > value. > 4\. Restart Ambari server and it view works. > 5\. Upgrade Ambari server. > 6\. Views.dir still points to new custom directory but upgrade puts the new > jars again back to /var/lib/ambari-server/resources/views (default location). > > 7\. Views fails as jars are older than current Ambari version in the views.dir > location. > > > > > Every 2.0s: grep views.dir /etc/ambari-server/conf/ambari.properties >Tue Aug 8 17:22:29 2017 > > views.dir=/tmp/amogh/views > > Every 2.0s: ls -l /tmp/amogh/views >Tue Aug 8 17:23:21 2017 > > total 326792 > -rw-r--r-- 1 root root 571656 2017-08-08 00:42 > ambari-admin-2.2.1.0.161.jar > -rw-r--r-- 1 root root 45378971 2017-08-08 00:42 > capacity-scheduler-2.2.1.0.161.jar > -rw-r--r-- 1 root root 42834901 2017-08-08 00:42 files-2.2.1.0.161.jar > -rw-r--r-- 1 root root 98657707 2017-08-08 00:42 hive-2.2.1.0.161.jar > -rw-r--r-- 1 root root 46910268 2017-08-08 00:42 pig-2.2.1.0.161.jar > -rw-r--r-- 1 root root 52239902 2017-08-08 00:42 slider-2.2.1.0.161.jar > -rw-r--r-- 1 root root 48025481 2017-08-08 00:42 tez-view-2.2.1.0.161.jar > drwxr-xr-x 10 root root 4096 2017-08-08 00:46 work > -rw--- 1 root root 3309 2017-08-08 00:42 > zeppelin-view-1.0-SNAPSHOT.jar > > > After Upgrage > > > > > Every 2.0s: ls -l /var/lib/ambari-server/resources/views > Tue Aug 8 17:23:44 2017 > > total 582628 > -rwxrwxrwx 1 root root917475 2016-08-30 19:29 > ambari-admin-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 45784224 2016-08-30 19:29 > capacity-scheduler-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 42287167 2016-08-30 19:29 files-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 99518847 2016-08-30 19:29 hive-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 126641271 2016-08-30 19:29 hive-jdbc-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 35225272 2016-08-30 19:29 > hueambarimigration-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 47306795 2016-08-30 19:29 pig-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 53071022 2016-08-30 19:29 slider-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 1202086 2016-08-30 19:29 storm-view-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 49835854 2016-08-30 19:29 tez-view-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 49250942 2016-08-30 19:29 wfmanager-2.4.0.1.1.jar > -rwxrwxrwx 1 root root 45547958 2016-08-30 19:29 > zeppelin-view-2.4.0.1.1.jar > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py f6f3f43 > ambari-server/src/main/python/ambari_server/serverUpgrade.py 07f5097 > > > Diff: https://reviews.apache.org/r/62026/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- Review request for Ambari, Jayush Luniya and Sid Wagle. Bugs: AMBARI-21856 https://issues.apache.org/jira/browse/AMBARI-21856 Repository: ambari Description --- The problem is that Ambari is using the reponame name field as the distribution when it creates the repo definition file. Since both of these repos use same distribution (which is a common Debian pattern), they collide. Diffs - ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 749a95e ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java cbbe92e ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java b593c32 ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java 4698178 Diff: https://reviews.apache.org/r/61994/diff/1/ Testing --- test will be fixed after solution will be approved Thanks, Vitalyi Brodetskyi
Re: Review Request 61969: Database consistency check fails after upgrade to ambari 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61969/ --- (Updated Сер. 29, 2017, 2:55 після полудня) Review request for Ambari, Jonathan Hurley and Sid Wagle. Bugs: AMBARI-21843 https://issues.apache.org/jira/browse/AMBARI-21843 Repository: ambari Description --- Here we need to fix two issues: 1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table. 2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping" Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3 Diff: https://reviews.apache.org/r/61969/diff/2/ Changes: https://reviews.apache.org/r/61969/diff/1-2/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 61969: Database consistency check fails after upgrade to ambari 2.6.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61969/ --- Review request for Ambari, Jonathan Hurley and Sid Wagle. Bugs: AMBARI-21843 https://issues.apache.org/jira/browse/AMBARI-21843 Repository: ambari Description --- Here we need to fix two issues: 1) Table "clusterconfigmapping" was removed in ambari-2.6.0 (dropping it during upgrade). But db consistency check still using this table to get some data. After upgrade it fails because "clusterconfigmapping" doesn't exist. Need to reimplement checks which are using this table. 2) Db consistency check doesn't show any information for user about errors, in casse when table doesn't exist. You can check that with "clusterconfigmapping" Diffs - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java aa96875 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 5ce03a3 Diff: https://reviews.apache.org/r/61969/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 61941: Fix config paths in libraries folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61941/#review183923 --- Ship it! Ship It! - Vitalyi Brodetskyi On Сер. 28, 2017, 1:20 після полудня, Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61941/ > --- > > (Updated Сер. 28, 2017, 1:20 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-21827 > https://issues.apache.org/jira/browse/AMBARI-21827 > > > Repository: ambari > > > Description > --- > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > ce00f0c > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 82a732b > > ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py > b636607 > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 5a16061 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > c3856e4 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b9 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > 79dc874 > > ambari-common/src/main/python/resource_management/libraries/providers/msi.py > 7f4deeb > > > Diff: https://reviews.apache.org/r/61941/diff/1/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/ --- (Updated Сер. 25, 2017, 6:33 після полудня) Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. Bugs: AMBARI-21795 https://issues.apache.org/jira/browse/AMBARI-21795 Repository: ambari Description --- If user has deleted services, after upgrade db consistency check will throw warnings about unmapped configs. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 9592209 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 34f3034 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 319bf53 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java cee05ef ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7348d4f ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 28ac59e ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31b308 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8ed9da5 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2a45476 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c5d2e90 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 2e38686 Diff: https://reviews.apache.org/r/61856/diff/5/ Changes: https://reviews.apache.org/r/61856/diff/4-5/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/ --- (Updated Сер. 25, 2017, 3:34 після полудня) Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. Bugs: AMBARI-21795 https://issues.apache.org/jira/browse/AMBARI-21795 Repository: ambari Description --- If user has deleted services, after upgrade db consistency check will throw warnings about unmapped configs. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 9592209 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 34f3034 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 319bf53 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java cee05ef ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7348d4f ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 28ac59e ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31b308 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8ed9da5 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2a45476 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c5d2e90 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 2e38686 Diff: https://reviews.apache.org/r/61856/diff/4/ Changes: https://reviews.apache.org/r/61856/diff/3-4/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade
> On Сер. 23, 2017, 6:59 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 160 (patched) > > <https://reviews.apache.org/r/61856/diff/1/?file=1802391#file1802391line163> > > > > Why doesn't this check is service exists or not? I think that this query will be enough: "SELECT clusterConfig FROM ClusterConfigEntity clusterConfig WHERE clusterConfig.serviceConfigEntities IS EMPTY AND clusterConfig.type != 'cluster-env'". Using it we will get all configs from clusterconfig table, which are not linked ti any service config. I think it's safe. Anyway we are using same query in db consistency check and they will be removed according to auto fix. One more, if we will just check configs without service, there are some cases which will not be covered. Like this one (for example): 1) Deploy cluster with hbase 2) Remove hbase. Configs will stay. 3) Add hbase. Old configs will become orphaned, and hbase will create and use new one. So, to my mind query that i used is correct/safe and will cover all needed cases. > On Сер. 23, 2017, 6:59 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 168 (patched) > > <https://reviews.apache.org/r/61856/diff/1/?file=1802391#file1802391line171> > > > > Is this within a transaction boundary? Sorry, missed that. Done. > On Сер. 23, 2017, 6:59 після полудня, Sid Wagle wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > > Lines 48 (patched) > > <https://reviews.apache.org/r/61856/diff/1/?file=1802401#file1802401line54> > > > > Make sure to run checkstyle on this. done. - Vitalyi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/#review183641 --- On Сер. 23, 2017, 9:14 після полудня, Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61856/ > --- > > (Updated Сер. 23, 2017, 9:14 після полудня) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-21795 > https://issues.apache.org/jira/browse/AMBARI-21795 > > > Repository: ambari > > > Description > --- > > If user has deleted services, after upgrade db consistency check will throw > warnings about unmapped configs. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 40049c0 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java > 34f3034 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 319bf53 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 7fc392d > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e77 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql da23e95 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > 44b5d91 > > > Diff: https://reviews.apache.org/r/61856/diff/3/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/ --- (Updated Сер. 23, 2017, 9:14 після полудня) Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. Bugs: AMBARI-21795 https://issues.apache.org/jira/browse/AMBARI-21795 Repository: ambari Description --- If user has deleted services, after upgrade db consistency check will throw warnings about unmapped configs. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 40049c0 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 34f3034 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 319bf53 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 7fc392d ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e77 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql da23e95 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 44b5d91 Diff: https://reviews.apache.org/r/61856/diff/3/ Changes: https://reviews.apache.org/r/61856/diff/2-3/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/ --- Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. Bugs: AMBARI-21795 https://issues.apache.org/jira/browse/AMBARI-21795 Repository: ambari Description --- If user has deleted services, after upgrade db consistency check will throw warnings about unmapped configs. Diffs - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 40049c0 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 34f3034 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 319bf53 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 7fc392d ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e77 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb6 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql da23e95 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555 ambari-server/src/main/resources/stacks/HDP/2.3.ECS/repos/repoinfo.xml 329539e ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/repos/repoinfo.xml ad79215 ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 44b5d91 Diff: https://reviews.apache.org/r/61856/diff/1/ Testing --- mvn clean test Thanks, Vitalyi Brodetskyi
Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/
---
(Updated Сер. 21, 2017, 8:48 після полудня)
Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-21173
https://issues.apache.org/jira/browse/AMBARI-21173
Repository: ambari
Description
---
Change Yarn-site.xml to some custom configs and restart Yarn
Restore it back to the origin config; Restart fails
{Code}
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 106, in
Nodemanager().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 330, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 835, in restart
self.stop(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 45, in stop
import params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params.py",
line 29, in
from params_linux import *
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py",
line 39, in
import status_params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py",
line 46, in
yarn_pid_dir = format("{yarn_pid_dir_prefix}/{yarn_user}")
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 95, in format
return ConfigurationFormatter().format(format_string, args, **result)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 59, in format
result_protected = self.vformat(format_string, args, all_params)
File "/usr/lib64/python2.7/string.py", line 549, in vformat
result = self._vformat(format_string, args, kwargs, used_args, 2)
File "/usr/lib64/python2.7/string.py", line 582, in _vformat
result.append(self.format_field(obj, format_spec))
File "/usr/lib64/python2.7/string.py", line 599, in format_field
return format(value, format_spec)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found in
configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 'yarn-env'
was not found in configurations dictionary!
{Code}
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
84b411c
Diff: https://reviews.apache.org/r/61582/diff/4/
Changes: https://reviews.apache.org/r/61582/diff/3-4/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/
---
(Updated Сер. 21, 2017, 8:01 після полудня)
Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-21173
https://issues.apache.org/jira/browse/AMBARI-21173
Repository: ambari
Description
---
Change Yarn-site.xml to some custom configs and restart Yarn
Restore it back to the origin config; Restart fails
{Code}
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 106, in
Nodemanager().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 330, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 835, in restart
self.stop(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 45, in stop
import params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params.py",
line 29, in
from params_linux import *
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py",
line 39, in
import status_params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py",
line 46, in
yarn_pid_dir = format("{yarn_pid_dir_prefix}/{yarn_user}")
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 95, in format
return ConfigurationFormatter().format(format_string, args, **result)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 59, in format
result_protected = self.vformat(format_string, args, all_params)
File "/usr/lib64/python2.7/string.py", line 549, in vformat
result = self._vformat(format_string, args, kwargs, used_args, 2)
File "/usr/lib64/python2.7/string.py", line 582, in _vformat
result.append(self.format_field(obj, format_spec))
File "/usr/lib64/python2.7/string.py", line 599, in format_field
return format(value, format_spec)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found in
configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 'yarn-env'
was not found in configurations dictionary!
{Code}
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
84b411c
Diff: https://reviews.apache.org/r/61582/diff/3/
Changes: https://reviews.apache.org/r/61582/diff/2-3/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 61582: Not able to start Yarn services after restoring the configs to initial value
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/
---
(Updated Сер. 21, 2017, 2:18 після полудня)
Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-21173
https://issues.apache.org/jira/browse/AMBARI-21173
Repository: ambari
Description
---
Change Yarn-site.xml to some custom configs and restart Yarn
Restore it back to the origin config; Restart fails
{Code}
Traceback (most recent call last):
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 106, in
Nodemanager().execute()
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 330, in execute
method(env)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
line 835, in restart
self.stop(env, upgrade_type=upgrade_type)
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
line 45, in stop
import params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params.py",
line 29, in
from params_linux import *
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py",
line 39, in
import status_params
File
"/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py",
line 46, in
yarn_pid_dir = format("{yarn_pid_dir_prefix}/{yarn_user}")
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 95, in format
return ConfigurationFormatter().format(format_string, args, **result)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
line 59, in format
result_protected = self.vformat(format_string, args, all_params)
File "/usr/lib64/python2.7/string.py", line 549, in vformat
result = self._vformat(format_string, args, kwargs, used_args, 2)
File "/usr/lib64/python2.7/string.py", line 582, in _vformat
result.append(self.format_field(obj, format_spec))
File "/usr/lib64/python2.7/string.py", line 599, in format_field
return format(value, format_spec)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
line 73, in __getattr__
raise Fail("Configuration parameter '" + self.name + "' was not found in
configurations dictionary!")
resource_management.core.exceptions.Fail: Configuration parameter 'yarn-env'
was not found in configurations dictionary!
{Code}
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
84b411c
Diff: https://reviews.apache.org/r/61582/diff/2/
Changes: https://reviews.apache.org/r/61582/diff/1-2/
Testing
---
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 61727: Unable to add new host to the upgraded PPC cluster due to exception:Local OS is not compatible with cluster primary OS family
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61727/#review183208
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Сер. 18, 2017, 7:41 до полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61727/
> ---
>
> (Updated Сер. 18, 2017, 7:41 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21753
> https://issues.apache.org/jira/browse/AMBARI-21753
>
>
> Repository: ambari
>
>
> Description
> ---
>
> **STR**
>
> 1. Install IOP 4.2.5
> 2. Upgrade ambari 2.4.2 to 2.5.2
> 3. Upgrade IOP 4.2.5 to HDP 2.6.2
> ambari repo build - <http://s3.amazonaws.com/dev.hortonworks.com/ambari/centos
> 7-ppc/2.x/BUILDS/2.5.2.0-259/ambaribn.repo>
> HDP stack - <http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7-ppc/2.x/B
> UILDS/2.6.2.0-180/HDP-2.6.2.0-180.xml>
>
> 4. Try adding a new host to the existing cluster.
>
> Error-
>
>
>
>
> ==
> Creating target directory...
> ==
>
> Command start time 2017-08-17 13:37:43
> chmod: cannot access '/var/lib/ambari-agent/data': No such file or
> directory
>
> Warning: Permanently added 'satya-iop-3.pub.pic2.ibm.com' (ECDSA) to the
> list of known hosts.
> Connection to satya-iop-3.pub.pic2.ibm.com closed.
> SSH command execution finished
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:43
>
> ==
> Copying ambari sudo script...
> ==
>
> Command start time 2017-08-17 13:37:43
>
> scp /var/lib/ambari-server/ambari-sudo.sh
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:43
>
> ==
> Copying common functions script...
> ==
>
> Command start time 2017-08-17 13:37:43
>
> scp /usr/lib/python2.6/site-packages/ambari_commons
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:44
>
> ==
> Copying create-python-wrap script...
> ==
>
> Command start time 2017-08-17 13:37:44
>
> scp /var/lib/ambari-server/create-python-wrap.sh
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:44
>
> ==
> Copying OS type check script...
> ==
>
> Command start time 2017-08-17 13:37:44
>
> scp /usr/lib/python2.6/site-packages/ambari_server/os_check_type.py
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:44
>
> ==
> Running create-python-wrap script...
> ==
>
> Command start time 2017-08-17 13:37:44
>
> Connection to satya-iop-3.pub.pic2.ibm.com closed.
> SSH command execution finished
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=0
> Command end time 2017-08-17 13:37:44
>
> ==
> Running OS type check...
> ==
>
> Command start time 2017-08-17 13:37:44
> Cluster primary/cluster OS family is redhat7 and local/current OS family
> is redhat-ppc7
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/tmp/os_check_type1502977064.py", line 44,
> in
> main()
> File "/var/lib/ambari-agent/tmp/os_check_type1502977064.py", line 40,
> in main
> raise Exception("Local OS is not compatible with cluster primary OS
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family.
> Please perform manual bootstrap on this host.
>
> Connection to satya-iop-3.pub.pic2.ibm.com closed.
> SSH command execution finished
> host=satya-iop-3.pub.pic2.ibm.com, exitcode=1
> Command end time 2017-08-17 13:37:44
>
> ERROR: Bootstrap of host satya-iop-3.pub.pic2.ibm.com fails because
> previous action finished with non-zero exit code (1)
>
