Re: Review Request 64769: AMBARI-22406 : UI for verifying if repo exist for new OS family and user prompt for entering HDP and HDP-UTILs repo URLs

2018-01-04 Thread Yussuf Shaikh
> On Dec. 22, 2017, 2:51 p.m., Nate Cole wrote: > > ambari-web/app/controllers/wizard/step3_controller.js > > Lines 863-880 (patched) > > > > > > I'm no UI expert, but this entire new block seems to be doing repo >

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
/StageUtilsTest.java b90295d Diff: https://reviews.apache.org/r/64887/diff/2/ Changes: https://reviews.apache.org/r/64887/diff/1-2/ Testing --- tests ran on ambari-server project. Thanks, Yussuf Shaikh

Re: Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
ence had introduced a method in Configuration class which is called in hosts loop later for different flows. - Yussuf --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/#review194635 ---

Review Request 64887: AMBARI-22403 Read the JAVA_HOME depending on the OS family during Service install (action & command) and upgrade

2018-01-02 Thread Yussuf Shaikh
://reviews.apache.org/r/64887/diff/1/ Testing --- tests ran on ambari-server project. Thanks, Yussuf Shaikh

Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types

2017-12-11 Thread Yussuf Shaikh
> On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java > > Lines 130-132 (patched) > > > > > > How many URLs are we talking about here. If

Re: Review Request 64407: AMBARI-22592: Set ambari.repo. in ambari-server setup script

2017-12-07 Thread Yussuf Shaikh
> On Dec. 7, 2017, 2:53 p.m., Nate Cole wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 1140-1141 (patched) > > > > > > Can this somehow be validated to the known, good os family

Review Request 64203: AMBARI-22476 Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types

2017-11-30 Thread Yussuf Shaikh
/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/64203/diff/1/ Testing --- Thanks, Yussuf Shaikh

Re: Review Request 63666: AMBARI-22327 Allow different OS types and versions for Hybrid setup

2017-11-09 Thread Yussuf Shaikh
n/os_check_type.py 34de34b > ambari-server/src/test/python/TestOSCheck.py 9aba78b > > > Diff: https://reviews.apache.org/r/63666/diff/1/ > > > Testing > --- > > test_os_type_check (TestOSCheck.TestOSCheck) ... ok > > > Thanks, > > Yussuf Shaikh > >

Review Request 63666: AMBARI-22327 Allow different OS types and versions for Hybrid setup

2017-11-08 Thread Yussuf Shaikh
- ambari-server/src/main/python/os_check_type.py 34de34b ambari-server/src/test/python/TestOSCheck.py 9aba78b Diff: https://reviews.apache.org/r/63666/diff/1/ Testing --- test_os_type_check (TestOSCheck.TestOSCheck) ... ok Thanks, Yussuf Shaikh

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-12 Thread Yussuf Shaikh
://reviews.apache.org/r/62923/diff/1/ Testing --- all tests pass on ambari-server Thanks, Yussuf Shaikh

Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

2017-10-12 Thread Yussuf Shaikh
/ Testing --- all tests pass on ambari-server Thanks, Yussuf Shaikh