Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host
> On 一月 19, 2017, 1:39 a.m., Alejandro Fernandez wrote: > > Pushed to trunk, commit 990747fe7d16874ef9788b1859bd0bcc6f9e2676 > > branch-2.5, commit fa6bbfff68c7f6a61e890b04e70577c5890ec94b we also consider this feature later, which can control the display of front-end by adding tag to metainfo. https://issues.apache.org/jira/browse/AMBARI-19618 - alice --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review162223 --- On 一月 18, 2017, 6:01 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6/ > --- > > (Updated 一月 18, 2017, 6:01 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-19557 > https://issues.apache.org/jira/browse/AMBARI-19557 > > > Repository: ambari > > > Description > --- > > http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html?? > The Ranger Admin and Ranger Usersync services must be installed on the same > cluster node. > so we'd betted install ranger_admin and ranger_usersync in same cluster node > in instaling at managing master hostcomponent > > > Diffs > - > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml > 92527c3 > > Diff: https://reviews.apache.org/r/6/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated 一月 18, 2017, 6:01 a.m.) Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-19557 https://issues.apache.org/jira/browse/AMBARI-19557 Repository: ambari Description --- http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html?? The Ranger Admin and Ranger Usersync services must be installed on the same cluster node. so we'd betted install ranger_admin and ranger_usersync in same cluster node in instaling at managing master hostcomponent Diffs (updated) - ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml 92527c3 Diff: https://reviews.apache.org/r/6/diff/ Testing --- done it Thanks, alice alice
Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host
> On 一月 17, 2017, 7:09 p.m., Alejandro Fernandez wrote: > > ambari-web/app/models/stack_service_component.js, line 200 > > <https://reviews.apache.org/r/6/diff/1/?file=1605673#file1605673line200> > > > > The standard is to provide that information in the metainfo file for > > several good reasons. > > * Support multiple stacks which may have differences in behavior > > * Support multiple versions of the same stack which may have > > differences in behavior > > * Abstract knowledge of the web-layer having to know about Hadoop > > > > I think the 2nd approach is more consistent with the rest of Ambari. > > Jayush Luniya wrote: > +1 we need to do away with UI hacks > > alice zhangxiaolu wrote: > Thanks for your reply. > But I find the fronted javascript code can not be deleted which will > cause the RANGER_USERSYNC still can be assigned to the other host. > So I will keep them . > Besides,I will add the configuration in the 2nd approach to my patch too. > what do you think about it? > > Alejandro Fernandez wrote: > We appreciate your contribution, but we should avoid the practice of > hardcoding component names in the UI; that's why the metainfo.xml file exists > for each component and for each version. Thanks for your reply. Very well, you are quite right, I will apply the second method in my patch. Centainly we will consider this feature later, which can control the display of front-end by adding tag to metainfo. - alice --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review161910 --- On 一月 17, 2017, 2:12 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6/ > --- > > (Updated 一月 17, 2017, 2:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-19557 > https://issues.apache.org/jira/browse/AMBARI-19557 > > > Repository: ambari > > > Description > --- > > http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html?? > The Ranger Admin and Ranger Usersync services must be installed on the same > cluster node. > so we'd betted install ranger_admin and ranger_usersync in same cluster node > in instaling at managing master hostcomponent > > > Diffs > - > > ambari-web/app/models/stack_service_component.js 17c2aa1 > > Diff: https://reviews.apache.org/r/6/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host
> On 一月 16, 2017, 7:05 p.m., Alejandro Fernandez wrote: > > ambari-web/app/models/stack_service_component.js, line 200 > > <https://reviews.apache.org/r/6/diff/1/?file=1605673#file1605673line200> > > > > Can this come from metainfo instead of being hardcoded on the UI? > > > > Please add Jaimin Jetly for input. > > alice zhangxiaolu wrote: > As we all know, there are two ways installing relative components in same > host; > > (1)fisrt method is as above, configs relative components in > stack_service_component.js. > (2)second method is in metainfo,but cannot be shown in web. The method is > as follows: > > > true > RANGER/RANGER_ADMIN > > > so suggest we can select one. > thanks for your reply. > > alice zhangxiaolu wrote: > Please ignore my above reply : ) > > > Thanks for your reply. > As I know, there are two ways making one component install with other in > same host automaticlly > > The first one is to code in stack_service_component.js as I did in my > patch. > The second one is to add following configuration to section RANGER_ADMIN > component in metainfo.xml: > > true > RANGER/RANGER_USERSYNC > > > The advantage of firs way is that we can see the relation in web page > clearly which the second one lacks As we know,there are two ways installing components in same host. 1.one is in stack_service_component as above; 2.two is in metainfo, but cannot show in web.as follow? 3. true RANGER/RANGER_ADMIN so in this case,I recommend that we can select first method. thanks for your reply. - alice --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review161773 --- On 一月 17, 2017, 2:12 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6/ > --- > > (Updated 一月 17, 2017, 2:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-19557 > https://issues.apache.org/jira/browse/AMBARI-19557 > > > Repository: ambari > > > Description > --- > > http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html?? > The Ranger Admin and Ranger Usersync services must be installed on the same > cluster node. > so we'd betted install ranger_admin and ranger_usersync in same cluster node > in instaling at managing master hostcomponent > > > Diffs > - > > ambari-web/app/models/stack_service_component.js 17c2aa1 > > Diff: https://reviews.apache.org/r/6/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Re: Review Request 55556: ranger_usersync should install with ranger_admin in the same host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated 一月 16, 2017, 2:32 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Zhe (Joe) Wang, Richard Zang, Sumit Mohanty, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-19557 https://issues.apache.org/jira/browse/AMBARI-19557 Repository: ambari Description --- http://docs.hortonworks.com/HDPDocuments/HDP2/HDP-2.3.0/bk_Ranger_Install_Guide/content/ch03s01.html?? The Ranger Admin and Ranger Usersync services must be installed on the same cluster node. so we'd betted install ranger_admin and ranger_usersync in same cluster node in instaling at managing master hostcomponent Diffs - ambari-web/app/models/stack_service_component.js 17c2aa1 Diff: https://reviews.apache.org/r/6/diff/ Testing --- done it Thanks, alice alice
Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- (Updated 十二月 7, 2016, 12:53 a.m.) Review request for Ambari, Zhe (Joe) Wang and Yusaku Sako. Bugs: AMBARI-18312 https://issues.apache.org/jira/browse/AMBARI-18312 Repository: ambari Description (updated) --- 1. when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config these. Diffs - ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 36dcfb8 ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 Diff: https://reviews.apache.org/r/51640/diff/ Testing --- done it Thanks, alice alice
Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.
> On 十二月 6, 2016, 3:03 p.m., Jonathan Hurley wrote: > > I normally don't review web client requests since I have little experience > > with that part of the codebase... OK,thank you all the same for your swift respondence. - alice --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/#review158159 --- On 十二月 6, 2016, 2:31 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51640/ > --- > > (Updated 十二月 6, 2016, 2:31 a.m.) > > > Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18312 > https://issues.apache.org/jira/browse/AMBARI-18312 > > > Repository: ambari > > > Description > --- > > 1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' > and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config > these. > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js > 36dcfb8 > ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 > ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 > > Diff: https://reviews.apache.org/r/51640/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- (Updated 十二月 6, 2016, 2:31 a.m.) Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. Changes --- when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing;Maybe we need to config these when starting rm ha. Summary (updated) - After staring rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing. Bugs: AMBARI-18312 https://issues.apache.org/jira/browse/AMBARI-18312 Repository: ambari Description --- 1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config these. Diffs - ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 36dcfb8 ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 Diff: https://reviews.apache.org/r/51640/diff/ Testing --- done it Thanks, alice alice
Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- (Updated 九月 6, 2016, 8:01 a.m.) Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. Bugs: AMBARI-18312 https://issues.apache.org/jira/browse/AMBARI-18312 Repository: ambari Description --- 1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config these. Diffs - ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 36dcfb8 ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 Diff: https://reviews.apache.org/r/51640/diff/ Testing --- done it Thanks, alice alice
Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi. Repository: ambari Description --- 1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config these. Diffs - ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 36dcfb8 ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 Diff: https://reviews.apache.org/r/51640/diff/ Testing --- done it Thanks, alice alice
Re: Review Request 51422: ExtensionModeule's description is not corrent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51422/#review147278 --- Ship it! Ship It! - alice alice On 八月 30, 2016, 9:07 a.m., alice alice wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51422/ > --- > > (Updated 八月 30, 2016, 9:07 a.m.) > > > Review request for Ambari, Jaimin Jetly, Myroslav Papirkovskyy, Srimanth > Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako. > > > Bugs: AMBARI-18259 > https://issues.apache.org/jira/browse/AMBARI-18259 > > > Repository: ambari > > > Description > --- > > ExtensionModeule's description is not corrent > > > Diffs > - > > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java > 1fc5b0e > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java > e3f8d0d > > Diff: https://reviews.apache.org/r/51422/diff/ > > > Testing > --- > > done it > > > Thanks, > > alice alice > >
Re: Review Request 51422: ExtensionModeule's description is not corrent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51422/ --- (Updated 八月 25, 2016, 8:28 a.m.) Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi. Bugs: 18259 https://issues.apache.org/jira/browse/18259 Repository: ambari Description --- ExtensionModeule's description is not corrent Diffs (updated) - ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java 1fc5b0e ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java e3f8d0d Diff: https://reviews.apache.org/r/51422/diff/ Testing --- done it Thanks, alice alice
Review Request 51132: testSerializeResourcesAsArray.java cannot pass
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51132/ --- Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi. Bugs: AMBARI-17910 https://issues.apache.org/jira/browse/AMBARI-17910 Repository: ambari Description --- testSerializeResourcesAsArray.java cannot pass because the input was not correct Diffs - ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java 2ea45dc Diff: https://reviews.apache.org/r/51132/diff/ Testing --- done it Thanks, alice alice
