iew177262
---
On 六月 7, 2017, 4:34 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
90a8-483b3cfd4d52__script_alert_notification_2.png
Thanks,
yao lei
t; Maybe make this a little clearer:
> >
> > The directory for scripts which are used by the alert notification
> > dispatcher.
>
> yao lei wrote:
> Got it.
> I will make this change.
>
> yao lei wrote:
> Hi Jonathan Hurley,
>
iew176949
---
On 六月 5, 2017, 10:28 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
iew176931
---
On 六月 2, 2017, 1:31 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
aded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png
Thanks,
yao lei
://reviews.apache.org/r/59440/diff/7/
Changes: https://reviews.apache.org/r/59440/diff/6-7/
Testing
---
Tested in a cluster
Thanks,
yao lei
mail. To reply, visit:
https://reviews.apache.org/r/59440/#review176608
-----------
On 六月 1, 2017, 1:37 a.m., yao lei wrote:
>
> ---
> This is an automatically gener
iew176601
---
On 六月 1, 2017, 1:37 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59440/
> -
/
Changes: https://reviews.apache.org/r/59440/diff/3-4/
Testing
---
Tested in a cluster
Thanks,
yao lei
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/59440/#review176309
-----------
On May 25, 2017, 6:02 a.m., yao lei wrote:
>
> ---
> This is an au
/diff/1/
Testing
---
1.cd ambari-web & mvn test
30383 passing (34s)
157 pending
2.Tested in a cluster
Thanks,
yao lei
> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
>
> A
> On May 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
>
> yao lei wrote:
> Hi Alexandr Antonenko,
> Would you please commit this patch if you are free?
> Thanks.
>
> A
1/alert_targets/:id
{"AlertTarget":{"name":"test","description":"","global":true,"notification_type":"ALERT_SCRIPT","alert_states":["OK","WARNING","CRITICAL","UNKNOWN"],"properties":{"ambari.dispatch-property.script":"com.mycompany.dispatch.shell.script"}}}
b.Delete /var/ambari-server/log_script_filename.log
c.Stop or start any service , wait for a moment, we should see log in
/var/log/ambari-server/log_script_dispatch_property.log and
/var/ambari-server/log_script_filename.log is not existed any more.
Thanks,
yao lei
> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> yao lei wrote:
> Thanks for your review
Hi Alexandr Antonenko,
Would you please commit this patch if you are free?
Thanks.
- yao
---
This i
iew175785
---
On 五月 23, 2017, 8:10 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
test
30383 passing (34s)
157 pending
2.Tested in a cluster
Thanks,
yao lei
ript_dispatch_property.log and
/var/ambari-server/log_script_filename.log is not exited any more.
Thanks,
yao lei
/59256/diff/1/
Testing
---
1.mvn test
20691 passing (30s)
128 pending
2.Tested in cluster
Thanks,
yao lei
iew174319
---
On 五月 9, 2017, 9:49 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
test4?
Cluster Administrator to test5
3.Login with above users in sequence and find items of Service Actions shown as
expected
Thanks,
yao lei
er.
>
>
> Diffs
> -----
>
>
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
> 73c19c6
> ambari-web/app/messages.js a2edf06
> ambari-web/app/templates/main/alerts/create_alert_notification.hbs 5b40bca
>
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
> 31da561
>
>
> Diff: https://reviews.apache.org/r/58256/diff/2/
>
>
> Testing
> ---
>
> mvn test
> 20676 passing (34s)
> 128 pending
>
>
> Thanks,
>
> yao lei
>
>
iew171399
---
On 四月 7, 2017, 2:16 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
s
73c19c6
ambari-web/app/messages.js a2edf06
ambari-web/app/templates/main/alerts/create_alert_notification.hbs 5b40bca
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
31da561
Diff: https://reviews.apache.org/r/58256/diff/1/
Testing
---
mvn test
20676 passing (34s)
128 pending
Thanks,
yao lei
---------
On 三月 17, 2017, 1:47 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57716/
> ---
it:
https://reviews.apache.org/r/57721/#review169780
---
On 三月 22, 2017, 1:48 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
iew169754
---
On 三月 22, 2017, 1:48 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
/manage_alert_notifications_controller.js
f470f08
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
15b4da3
Diff: https://reviews.apache.org/r/57721/diff/1/
Testing
---
mvn test
20580 passing (36s)
153 pending
Thanks,
yao lei
6ed87cd
ambari-views/examples/phone-list-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java
146a8e3
Diff: https://reviews.apache.org/r/57716/diff/1/
Testing
---
Tested in a cluster
Thanks,
yao lei
honelist/PhoneListServlet.java
146a8e3
Diff: https://reviews.apache.org/r/57716/diff/1/
Testing
---
Tested in a cluster
Thanks,
yao lei
> On 三月 6, 2017, 2:21 p.m., Jonathan Hurley wrote:
> > Ship It!
>
> yao lei wrote:
> Hi Jonathan,
> Thank you very much.
> Would you please help me to commit the patch to trunk if you are free?
>
> Jonathan Hurley wrote:
> Yes, I'm just r
To reply, visit:
https://reviews.apache.org/r/57281/#review167979
---
On 三月 3, 2017, 11:56 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To rep
iew167857
---
On 三月 3, 2017, 11:56 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
an see the expected result.
Thanks,
yao lei
is patch.
I also think your contribution is more flexible.
- yao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55817/#review166433
---
On 二月 2
iew166421
---
On 二月 22, 2017, 1:52 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
his JIRA can
> leverage the new behavior for hive server/webhcat cohost logic as Jaimin
> suggested.
Thank you for reviewing this patch
- yao
---
This is an automatically generated e-mail. To reply, visit
on:254->testReadViewArchives:466
expected: but was:
Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30
3.Installed a cluster using RPM based on latest trunk codes and screenshots
attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the
expected result.
Thanks,
yao lei
d the test case to the updated patch.
But I will handle the duplicate configuration in fronted code,this is because i
think the backend code will only extact configurartion from tag which
will be displayed by API
How about your opinion?
- yao
------------
----------
On 二月 14, 2017, 1:20 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55817/
>
expected: but was:
Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30
3.Installed a cluster using RPM based on latest trunk codes and screenshots
attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the
expected result.
Thanks,
yao lei
iew162992
---
On 一月 26, 2017, 12:22 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ipped: 30
3.Installed a cluster using RPM based on latest trunk codes and screenshots
attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the
expected result.
Thanks,
yao lei
played.
> >
> > Did you happen to investigate why Ambari server has lower hostcase name
> > while the actual hostname is in mixed/upper case?
>
> yao lei wrote:
> Thanks for your reply.
> Firstly,the hostnames of flume metrics sent by flume si
played.
> >
> > Did you happen to investigate why Ambari server has lower hostcase name
> > while the actual hostname is in mixed/upper case?
>
> yao lei wrote:
> Thanks for your reply.
> Firstly,the hostnames of flume metrics sent by flume si
> On 一月 9, 2017, 1:23 a.m., Matt wrote:
> > Is this issue only for Flume?
> >
> > If the root cause is because of case mismatch, are other sinks (like
> > StormTimelineMetricsSink, similar code to get hostname) prone to have the
> > same issue?
>
> yao
visit:
https://reviews.apache.org/r/55173/#review160845
-----------
On 一月 5, 2017, 3:23 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To
played.
> >
> > Did you happen to investigate why Ambari server has lower hostcase name
> > while the actual hostname is in mixed/upper case?
>
> yao lei wrote:
> Thanks for your reply.
> Firstly,the hostnames of flume metrics sent by flume si
eviews.apache.org/r/55173/#review160765
-----------
On 一月 5, 2017, 3:23 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55173/
> -
/FlumeTimelineMetricsSink.java
c1b684b
Diff: https://reviews.apache.org/r/55173/diff/
Testing
---
Manually Tested
Thanks,
yao lei
On 十月 13, 2016, 7:43 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
ent
jiras have existed
- yao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152389
---
On 九月 23,
is may impact.
Thanks for your comment.
- yao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152301
---
On 九月 23,
/create_alert_notification.hbs a248e57
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
a0a4ce4
Diff: https://reviews.apache.org/r/52183/diff/
Testing
---
ambari-web/mvn test
30365 tests complete (43 seconds)
151 tests pending
Thanks,
yao lei
"notification_type": "FOO",
> > "groups": [1,2,3]
> > }
> > }
> > ```
> >
> > This is also accomplished through the Web Client when created/editing the
> > target.
>
> yao lei wrote:
> thanks for your explai
"notification_type": "FOO",
> > "groups": [1,2,3]
> > }
> > }
> > ```
> >
> > This is also accomplished through the Web Client when created/editing the
> > target.
>
> yao lei wrote:
>
creating or editing the alert target on web ui?
- yao
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51599/#review147727
---
, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in
Thanks,
yao lei
org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in
Thanks,
yao lei
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in
Thanks,
yao lei
/diff/
Testing
---
Tested
Running
org.apache.ambari.server.notifications.dispatchers.AlertScriptDispatcherTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.096 sec - in
Thanks,
yao lei
g/r/42155/#review131621
---
On 五月 3, 2016, 4:57 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ef90561
Diff: https://reviews.apache.org/r/42155/diff/
Testing
---
Manually Tested.
But Ambari Web Unit Test fails in trunk for other reasons described in
https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt
Thanks,
yao lei
64 matches
Mail list logo
