Re: Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45696/
---

(Updated April 4, 2016, 8:17 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
---

Added unit test.


Bugs: AMBARI-15692
https://issues.apache.org/jira/browse/AMBARI-15692


Repository: ambari


Description
---

AMS-Collector host had the environment variable HBASE_HOME=/usr/lib/hbase 
defined somewhere in the system. AMS user somehow inherited this environment 
variable. When AMS-Collector started, he would start the embedded HBase which 
would use the incorrect environment variable and failed to start 
(/usr/lib/hbase was missing many JARs).

AMS-HBase's hbase-env.sh script should explicitly set the HBASE_HOME to its own 
path and not fail due to some incorrect environment variable.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f4a0b8c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 378138b 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 3723ff8 

Diff: https://reviews.apache.org/r/45696/diff/


Testing
---

Manually tested on cluster where AMS co-existed with cluster HBase.


Thanks,

Aravindan Vijayan

Re: Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45696/#review126896
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 720)


Any changes to unit test ?


- Dmytro Sen


On Апрель 4, 2016, 6:38 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45696/
> ---
> 
> (Updated Апрель 4, 2016, 6:38 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15692
> https://issues.apache.org/jira/browse/AMBARI-15692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS-Collector host had the environment variable HBASE_HOME=/usr/lib/hbase 
> defined somewhere in the system. AMS user somehow inherited this environment 
> variable. When AMS-Collector started, he would start the embedded HBase which 
> would use the incorrect environment variable and failed to start 
> (/usr/lib/hbase was missing many JARs).
> 
> AMS-HBase's hbase-env.sh script should explicitly set the HBASE_HOME to its 
> own path and not fail due to some incorrect environment variable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f4a0b8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  378138b 
> 
> Diff: https://reviews.apache.org/r/45696/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster where AMS co-existed with cluster HBase.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>