Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-11 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132620
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 10, 2016, 5:15 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 10, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132464
---


Fix it, then Ship it!





ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 795)


Oracle maximum is 30 characters - let's reduce this across the board.


- Jonathan Hurley


On May 10, 2016, 12:02 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 10, 2016, 12:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/
---

(Updated May 10, 2016, 4:02 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Changed clusterType column to non nullable.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added tables for Remote Cluster to create scripts.
Added table changes to UpgradeCatalog240


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f85a4c7 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
0f3a2c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7c85ba7 

Diff: https://reviews.apache.org/r/47026/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar 


> On May 10, 2016, 3:44 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 791-797
> > 
> >
> > I thought in the entities you had this as a Many-To-Many relationship 
> > ... but here it's 1:M (which is what I'd expect).
> > 
> > Are the entities adjusted accordingly?

Yes. Changed the Mapping to one to Many. Entities are adjusted accordingly.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132451
---


On May 10, 2016, 11:19 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 10, 2016, 11:19 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132451
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 270)


nullable?



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 570)


nullable?



ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (lines 791 - 797)


I thought in the entities you had this as a Many-To-Many relationship ... 
but here it's 1:M (which is what I'd expect).

Are the entities adjusted accordingly?


- Jonathan Hurley


On May 10, 2016, 7:19 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 10, 2016, 7:19 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-10 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/
---

(Updated May 10, 2016, 11:19 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updated tables.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added tables for Remote Cluster to create scripts.
Added table changes to UpgradeCatalog240


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f85a4c7 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
0f3a2c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7c85ba7 

Diff: https://reviews.apache.org/r/47026/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Jonathan Hurley 


> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.
> 
> Jonathan Hurley wrote:
> I think that's implied though - what other kinds of remote clusters are 
> there?
> 
> Gaurav Nagar wrote:
> Currently we have only ambari managed. But in future we can have remote 
> clusters that are not managed by ambari also.
> 
> Jonathan Hurley wrote:
> In that case, wouldn't it still be a remotecluster of a different type? 
> Not a different table entirely?

Discussed and it was my misunderstanding that remote clusters and remote ambari 
clusters wouldn't really share any common data, so there should separate tables 
for these (instead of a column type)


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 9, 2016, 9:44 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 9, 2016, 9:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Jonathan Hurley 


> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.
> 
> Jonathan Hurley wrote:
> I think that's implied though - what other kinds of remote clusters are 
> there?
> 
> Gaurav Nagar wrote:
> Currently we have only ambari managed. But in future we can have remote 
> clusters that are not managed by ambari also.

In that case, wouldn't it still be a remotecluster of a different type? Not a 
different table entirely?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 9, 2016, 9:44 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 9, 2016, 9:44 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-09 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/
---

(Updated May 9, 2016, 1:44 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj Rathore, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Updated patch as per comment.


Bugs: AMBARI-16274
https://issues.apache.org/jira/browse/AMBARI-16274


Repository: ambari


Description
---

Added tables for Remote Cluster to create scripts.
Added table changes to UpgradeCatalog240


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f85a4c7 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
0f3a2c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 7c85ba7 

Diff: https://reviews.apache.org/r/47026/diff/


Testing
---

Manual Testing.


Thanks,

Gaurav Nagar

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar 


> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.
> 
> Jonathan Hurley wrote:
> I think that's implied though - what other kinds of remote clusters are 
> there?

Currently we have only ambari managed. But in future we can have remote 
clusters that are not managed by ambari also.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 5, 2016, 4:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 5, 2016, 4:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley 


> On May 6, 2016, 10:12 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.
> 
> Gaurav Nagar wrote:
> remoteambaricluster indicates remote cluster managed by ambari.

I think that's implied though - what other kinds of remote clusters are there?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 5, 2016, 12:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 5, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Gaurav Nagar 


> On May 6, 2016, 2:12 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 198
> > 
> >
> > I don't think we need the word "ambari" in an Ambari database table.

remoteambaricluster indicates remote cluster managed by ambari.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


On May 5, 2016, 4:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 5, 2016, 4:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47026: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Database changes

2016-05-06 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47026/#review132026
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 198)


I don't think we need the word "ambari" in an Ambari database table.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 229)


Use {} in log statements



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (lines 279 - 280)


Create an enum for cluster_type for 'LOCAL_AMBARI'


- Jonathan Hurley


On May 5, 2016, 12:29 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47026/
> ---
> 
> (Updated May 5, 2016, 12:29 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
> https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added tables for Remote Cluster to create scripts.
> Added table changes to UpgradeCatalog240
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f85a4c7 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f5336bc 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fca3be3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ce0bd84 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7fb8c31 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 0f3a2c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql b89389c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1107c4d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  7c85ba7 
> 
> Diff: https://reviews.apache.org/r/47026/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>