Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/
---

(Updated Май 6, 2016, 4 п.п.)


Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi Brodetskyi.


Bugs: AMBARI-16286
https://issues.apache.org/jira/browse/AMBARI-16286


Repository: ambari


Description
---

1. Install ambari cluster with few services 
2. enable kerberos
3. run service check on services
Expected: all service checks should pass successfully
Actual: MR service check fails.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 ee12ba3 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
d6bc713 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
cf0990d 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py c48b2c7 

Diff: https://reviews.apache.org/r/47063/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/
---

(Updated Май 6, 2016, 3:16 п.п.)


Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi Brodetskyi.


Bugs: AMBARI-16286
https://issues.apache.org/jira/browse/AMBARI-16286


Repository: ambari


Description
---

1. Install ambari cluster with few services 
2. enable kerberos
3. run service check on services
Expected: all service checks should pass successfully
Actual: MR service check fails.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 ee12ba3 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
d6bc713 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
cf0990d 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py c48b2c7 

Diff: https://reviews.apache.org/r/47063/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/
---

(Updated Май 6, 2016, 3:13 п.п.)


Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi Brodetskyi.


Bugs: AMBARI-16286
https://issues.apache.org/jira/browse/AMBARI-16286


Repository: ambari


Description
---

1. Install ambari cluster with few services 
2. enable kerberos
3. run service check on services
Expected: all service checks should pass successfully
Actual: MR service check fails.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
 2184c0e 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
d6bc713 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
cf0990d 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py c48b2c7 

Diff: https://reviews.apache.org/r/47063/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/#review132021
---




ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 
90)


When Kerberos is enabled we just need to set the container-executor.class. 
The other properties need not be set. They should only be based on if 
yarn_cgroups_enabled is true or false.


- Sumit Mohanty


On May 6, 2016, 12:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47063/
> ---
> 
> (Updated May 6, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16286
> https://issues.apache.org/jira/browse/AMBARI-16286
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Install ambari cluster with few services 
> 2. enable kerberos
> 3. run service check on services
> Expected: all service checks should pass successfully
> Actual: MR service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
>  2184c0e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> d6bc713 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> cf0990d 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> c48b2c7 
> 
> Diff: https://reviews.apache.org/r/47063/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/#review132018
---


Ship it!




Ship It!

- Oliver Szabo


On May 6, 2016, 12:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47063/
> ---
> 
> (Updated May 6, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16286
> https://issues.apache.org/jira/browse/AMBARI-16286
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Install ambari cluster with few services 
> 2. enable kerberos
> 3. run service check on services
> Expected: all service checks should pass successfully
> Actual: MR service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
>  2184c0e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> d6bc713 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> cf0990d 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> c48b2c7 
> 
> Diff: https://reviews.apache.org/r/47063/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/
---

(Updated Май 6, 2016, 12:07 п.п.)


Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi Brodetskyi.


Bugs: AMBARI-16286
https://issues.apache.org/jira/browse/AMBARI-16286


Repository: ambari


Description
---

1. Install ambari cluster with few services 
2. enable kerberos
3. run service check on services
Expected: all service checks should pass successfully
Actual: MR service check fails.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
 2184c0e 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
d6bc713 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
cf0990d 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py c48b2c7 

Diff: https://reviews.apache.org/r/47063/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/#review132015
---


Ship it!




Ship It!

- Robert Levas


On May 6, 2016, 6:04 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47063/
> ---
> 
> (Updated May 6, 2016, 6:04 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16286
> https://issues.apache.org/jira/browse/AMBARI-16286
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Install ambari cluster with few services 
> 2. enable kerberos
> 3. run service check on services
> Expected: all service checks should pass successfully
> Actual: MR service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
>  2184c0e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> d6bc713 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> cf0990d 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> c48b2c7 
> 
> Diff: https://reviews.apache.org/r/47063/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 47063: MapReduce service check failed on most of the Kerberos tests

2016-05-06 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47063/#review132009
---




ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 
84)


You should rename this variable (yarn_cgroups_enabled) because it can be 
misleading


- Oliver Szabo


On May 6, 2016, 10:04 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47063/
> ---
> 
> (Updated May 6, 2016, 10:04 a.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16286
> https://issues.apache.org/jira/browse/AMBARI-16286
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Install ambari cluster with few services 
> 2. enable kerberos
> 3. run service check on services
> Expected: all service checks should pass successfully
> Actual: MR service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-env.xml
>  2184c0e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> d6bc713 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> cf0990d 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> c48b2c7 
> 
> Diff: https://reviews.apache.org/r/47063/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>