Re: Review Request 47956: Automatically cleanup /var/run/ambari-server/stack-recommendations

2016-05-27 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47956/
---

(Updated May 27, 2016, 3:07 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Srimanth Gunturi.


Bugs: AMBARI-16929
https://issues.apache.org/jira/browse/AMBARI-16929


Repository: ambari


Description
---

In clusters with many nodes and thousands of processes running
/var/run/ambari-server/stack-recommendations folder gets filled up and not
cleaned till ambari-server is restarted.

Disk is getting filled up causing space issues.


Diffs (updated)
-

  ambari-server/conf/unix/ambari.properties 9f1692e 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java
 a925d7d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutRecommendationCommand.java
 0dff92b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutValidationCommand.java
 757ebee 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationDependenciesRecommendationCommand.java
 ae86548 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommand.java
 ad01b40 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationValidationCommand.java
 c234947 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 3e20a09 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 7cfaf61 
  ambari-server/src/main/java/org/apache/ambari/server/utils/DateUtils.java 
785f4fd 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommandTest.java
 bc9cf77 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
 263bbe1 

Diff: https://reviews.apache.org/r/47956/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk



Re: Review Request 47956: Automatically cleanup /var/run/ambari-server/stack-recommendations

2016-05-27 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47956/#review135238
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 27, 2016, 5:44 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47956/
> ---
> 
> (Updated May 27, 2016, 5:44 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16929
> https://issues.apache.org/jira/browse/AMBARI-16929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In clusters with many nodes and thousands of processes running
> /var/run/ambari-server/stack-recommendations folder gets filled up and not
> cleaned till ambari-server is restarted.
> 
> Disk is getting filled up causing space issues.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 9f1692e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java
>  a925d7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutRecommendationCommand.java
>  0dff92b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutValidationCommand.java
>  757ebee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationDependenciesRecommendationCommand.java
>  ae86548 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommand.java
>  ad01b40 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationValidationCommand.java
>  c234947 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  3e20a09 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  7cfaf61 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/DateUtils.java 
> 785f4fd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommandTest.java
>  bc9cf77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  263bbe1 
> 
> Diff: https://reviews.apache.org/r/47956/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>