Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-07-15 Thread Jayush Luniya
> On June 17, 2016, 3:04 p.m., Jayush Luniya wrote: > > @Saisai > > Looks like you need to rebase again > > $ git apply ~/Downloads/AMBARI-16864-v1.patch > > /Users/jluniya/Downloads/AMBARI-16864-v1.patch:1100: trailing whitespace. > > "spark-javaopts-properties": {}, > > /Users/jluniya/D

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48651/#review138229 --- @Saisai Looks like you need to rebase again $ git apply ~/Download

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48651/ --- (Updated June 15, 2016, 5:03 p.m.) Review request for Ambari and Jayush Luniya.

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Saisai Shao
> On June 15, 2016, 4:47 p.m., Jayush Luniya wrote: > > Can you rebase patch to latest in trunk and submit the patch > > > > git apply ~/Downloads/AMBARI-16864.patch > > /Users/jluniya/Downloads/AMBARI-16864.patch:1114: trailing whitespace. > > "spark-javaopts-properties": {}, > > /Users

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48651/#review137765 --- Can you rebase patch to latest in trunk and submit the patch git