Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/#review139142
---


Ship it!




Ship It!

- Robert Levas


On June 22, 2016, 5:25 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49104/
> ---
> 
> (Updated June 22, 2016, 5:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17380
> https://issues.apache.org/jira/browse/AMBARI-17380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using full URI paths for DataNode directories, ie, 
> {{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  
> 
> The script alert needs to accept URI paths for DataNodes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  df85002 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
>  c9bd187 
> 
> Diff: https://reviews.apache.org/r/49104/diff/
> 
> 
> Testing
> ---
> 
> Used a mixture of file:// and normal paths.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/
---

(Updated June 22, 2016, 5:25 p.m.)


Review request for Ambari, Alejandro Fernandez and Robert Levas.


Changes
---

mvn clean test


Bugs: AMBARI-17380
https://issues.apache.org/jira/browse/AMBARI-17380


Repository: ambari


Description
---

When using full URI paths for DataNode directories, ie, 
{{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  

The script alert needs to accept URI paths for DataNodes.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
 df85002 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
 c9bd187 

Diff: https://reviews.apache.org/r/49104/diff/


Testing
---

Used a mixture of file:// and normal paths.


Thanks,

Jonathan Hurley

Re: Review Request 49104: The DataNode Unmounted Alert Produces False Alerts When file:// URIs Are Used

2016-06-22 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49104/#review139139
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 22, 2016, 9:18 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49104/
> ---
> 
> (Updated June 22, 2016, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-17380
> https://issues.apache.org/jira/browse/AMBARI-17380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using full URI paths for DataNode directories, ie, 
> {{file:///hadoop01/data/dn}}, the DataNode directory alert fails.  
> 
> The script alert needs to accept URI paths for DataNodes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  df85002 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
>  c9bd187 
> 
> Diff: https://reviews.apache.org/r/49104/diff/
> 
> 
> Testing
> ---
> 
> Used a mixture of file:// and normal paths.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>