Re: Review Request 49387: Support password type for custom properties

> On July 25, 2016, 9:08 p.m., Alexandr Antonenko wrote: > > Ship It! > > Keta Patel wrote: > Thank you Alexandr! > Could you please help with pushing in the changes? done - Alexandr --- This is an automatically generated

Re: Review Request 49387: Support password type for custom properties

> On July 25, 2016, 9:08 p.m., Alexandr Antonenko wrote: > > Ship It! Thank you Alexandr! Could you please help with pushing in the changes? - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49387: Support password type for custom properties

> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 264 > > > > > > I do not see FINAL populated anywhere. I think this code will trigger > > fatal error. Have you

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review143428 --- Ship it! Ship It! - Alexandr Antonenko On July 25, 2016,

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 25, 2016, 8:47 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 264 > > > > > > I do not see FINAL populated anywhere. I think this code will trigger > > fatal error. Have you

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 21, 2016, 11:11 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

> On July 20, 2016, 11:17 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 264 > > > > > > I do not see FINAL populated anywhere. I think this code will trigger > > fatal error. Have you

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 21, 2016, 11:05 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review143024 --- ambari-web/app/utils/config.js (line 248)

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 20, 2016, 9:05 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

> On July 20, 2016, 2:04 p.m., Alexandr Antonenko wrote: > > ambari-web/app/utils/config.js, line 256 > > > > > > When you see so many if statements, the first thing that comes to mind > > that this needs to be

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review142943 --- Ship it! Ship It! - Dmitro Lisnichenko On July 18, 2016,

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review142938 --- ambari-web/app/utils/config.js (line 256)

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review142933 --- Ship it! Ship It! - Jonathan Hurley On July 18, 2016, 12:40

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review142375 ---

Re: Review Request 49387: Support password type for custom properties

> On July 9, 2016, 4:49 a.m., Matt wrote: > > ambari-web/app/mixins/common/configs/configs_saver.js, line 469 > > > > > > Isn't it possible to simplify all these if conditions (considering your > > property types

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review141391 --- ambari-web/app/mixins/common/configs/configs_saver.js (line 469)

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 8, 2016, 9:15 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

> On July 8, 2016, 2:12 p.m., Di Li wrote: > > please add Jonathan Hurley to the review Thank you Di. I have added him. - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/ --- (Updated July 8, 2016, 9:05 p.m.) Review request for Ambari, Alexandr

Re: Review Request 49387: Support password type for custom properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49387/#review141280 --- please add Jonathan Hurley to the review - Di Li On June 29,