Re: Review Request 45487: VDF creation script should be callable as an importable module

[Nate Cole]

> On March 30, 2016, 10:21 a.m., Jonathan Hurley wrote:
> > contrib/version-builder/version_builder.py, line 231
> > 
> >
> > Should this be a member of the class; seems like it's only called in 
> > the context of the class and outside imports shouldn't get it by default.

Agreed.  Will update and test python3.  Thanks for the review!


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45487/#review126107
---


On March 30, 2016, 9:55 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45487/
> ---
> 
> (Updated March 30, 2016, 9:55 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15631
> https://issues.apache.org/jira/browse/AMBARI-15631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The version_builder.py script should be a callable module
> 
> 
> Diffs
> -
> 
>   contrib/version-builder/example.py PRE-CREATION 
>   contrib/version-builder/example.sh 7016997 
>   contrib/version-builder/version_builder.py 6c20a47 
> 
> Diff: https://reviews.apache.org/r/45487/diff/
> 
> 
> Testing
> ---
> 
> Manual.  No automated tests for contrib.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45487: VDF creation script should be callable as an importable module

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45487/#review126107
---


Ship it!




argparse is my only real concern; I don't know how it behaves on Python 3.x


contrib/version-builder/version_builder.py (line 192)


Should this be a member of the class; seems like it's only called in the 
context of the class and outside imports shouldn't get it by default.



contrib/version-builder/version_builder.py (line 327)


I think that this is deprecated; maybe you should switch this to argparse?


- Jonathan Hurley


On March 30, 2016, 9:55 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45487/
> ---
> 
> (Updated March 30, 2016, 9:55 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15631
> https://issues.apache.org/jira/browse/AMBARI-15631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The version_builder.py script should be a callable module
> 
> 
> Diffs
> -
> 
>   contrib/version-builder/example.py PRE-CREATION 
>   contrib/version-builder/example.sh 7016997 
>   contrib/version-builder/version_builder.py 6c20a47 
> 
> Diff: https://reviews.apache.org/r/45487/diff/
> 
> 
> Testing
> ---
> 
> Manual.  No automated tests for contrib.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 45487: VDF creation script should be callable as an importable module

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45487/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-15631
https://issues.apache.org/jira/browse/AMBARI-15631


Repository: ambari


Description
---

The version_builder.py script should be a callable module


Diffs
-

  contrib/version-builder/example.py PRE-CREATION 
  contrib/version-builder/example.sh 7016997 
  contrib/version-builder/version_builder.py 6c20a47 

Diff: https://reviews.apache.org/r/45487/diff/


Testing
---

Manual.  No automated tests for contrib.


Thanks,

Nate Cole