subject:"Review Request 45703\: Allow skipping creation of repo files"

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-05 Thread Nate Cole



> On April 4, 2016, 10:26 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py,
> >  lines 121-122
> > 
> >
> > Is this really a warning? Kind of odd to warn on a feature.

Will fix.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127013
---


On April 4, 2016, 5 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45703/
> ---
> 
> (Updated April 4, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15697
> https://issues.apache.org/jira/browse/AMBARI-15697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
> an attribute to OperatingSystems that gets persisted to do this work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  f3197cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a0b98f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
>  06b4148 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  bb50820 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
>  fd4a91f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
>  3c881a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  6a36522 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c01dbb3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  05751fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  4da8896 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  e031fc8 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  aacd1f2 
> 
> Diff: https://reviews.apache.org/r/45703/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127013
---


Ship it!





ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
(lines 121 - 122)


Is this really a warning? Kind of odd to warn on a feature.


- Jonathan Hurley


On April 4, 2016, 5 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45703/
> ---
> 
> (Updated April 4, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15697
> https://issues.apache.org/jira/browse/AMBARI-15697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
> an attribute to OperatingSystems that gets persisted to do this work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  f3197cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a0b98f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
>  06b4148 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  bb50820 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
>  fd4a91f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
>  3c881a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  6a36522 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c01dbb3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  05751fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  4da8896 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  e031fc8 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  aacd1f2 
> 
> Diff: https://reviews.apache.org/r/45703/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127012
---


Ship it!




Ship It!

- Jayush Luniya


On April 4, 2016, 9 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45703/
> ---
> 
> (Updated April 4, 2016, 9 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15697
> https://issues.apache.org/jira/browse/AMBARI-15697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
> an attribute to OperatingSystems that gets persisted to do this work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  f3197cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a0b98f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
>  06b4148 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  bb50820 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
>  fd4a91f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
>  3c881a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  6a36522 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c01dbb3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  05751fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  4da8896 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  e031fc8 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  aacd1f2 
> 
> Diff: https://reviews.apache.org/r/45703/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-15697
https://issues.apache.org/jira/browse/AMBARI-15697


Repository: ambari


Description
---

RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
an attribute to OperatingSystems that gets persisted to do this work.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 f3197cb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a0b98f7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
 06b4148 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 bb50820 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
 fd4a91f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
 3c881a1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 6a36522 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
c01dbb3 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
 05751fa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 4da8896 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
 e031fc8 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
 aacd1f2 

Diff: https://reviews.apache.org/r/45703/diff/


Testing
---

Manual.  Automated pending


Thanks,

Nate Cole

Re: Review Request 45703: Allow skipping creation of repo files

Re: Review Request 45703: Allow skipping creation of repo files

Re: Review Request 45703: Allow skipping creation of repo files

Review Request 45703: Allow skipping creation of repo files

4 matches

Site Navigation

Mail list logo

Footer information