Re: Review Request 46217: After adding support for real jdbc jar names, verify the post Ambari upgrade nothing breaks

2016-04-15 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46217/#review129073
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 14, 2016, 6:40 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46217/
> ---
> 
> (Updated Апрель 14, 2016, 6:40 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15894
> https://issues.apache.org/jira/browse/AMBARI-15894
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Lets think through the upgrade scenario again:
> Prior to upgrade we know of hard-coded names and the system is in working 
> state
> During upgrade, lets pre-populate the ambari.properties file with the old 
> hard-coded values (think of them as the real names as thats what we know)
> If user wants to use real name, they can call ambari-server setup ...
> Net goal is to not have user do anything post Ambari upgrade.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 1830d18 
> 
> Diff: https://reviews.apache.org/r/46217/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>



Review Request 46217: After adding support for real jdbc jar names, verify the post Ambari upgrade nothing breaks

2016-04-14 Thread Vitalyi Brodetskyi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46217/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15894
https://issues.apache.org/jira/browse/AMBARI-15894


Repository: ambari


Description
---

Lets think through the upgrade scenario again:
Prior to upgrade we know of hard-coded names and the system is in working state
During upgrade, lets pre-populate the ambari.properties file with the old 
hard-coded values (think of them as the real names as thats what we know)
If user wants to use real name, they can call ambari-server setup ...
Net goal is to not have user do anything post Ambari upgrade.


Diffs
-

  ambari-server/conf/unix/ambari.properties 1830d18 

Diff: https://reviews.apache.org/r/46217/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi