Re: Review Request 46987: Show the connect string with the HiveServer instance

2016-05-04 Thread Zhe (Joe) Wang


> On May 4, 2016, 8:04 p.m., Zhe (Joe) Wang wrote:
> > The width of the field for this string seems be too small. I can only see 
> > "jdbc:hive2://c6402".
> 
> Jaimin Jetly wrote:
> Thats intentional as the string can be long depending upon zookeeper 
> quorom value. so it is ellipses with "...". However "copy to clipboard" 
> action is supposed to copy entire actual string.

Yeah. That's what I figured may be. Makes sense.


- Zhe (Joe)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/#review131733
---


On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46987/
> ---
> 
> (Updated May 4, 2016, 5:52 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16244
> https://issues.apache.org/jira/browse/AMBARI-16244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Zookeeper based service discovery is used, then Hive summary page should 
> show JDBC connect string for HiveServer2 and HiveServer2 Interactive 
> instances.
> The semantics for this will be
> jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f92b489 
>   ambari-web/app/assets/img/clippy.svg PRE-CREATION 
>   ambari-web/app/controllers/global/configuration_controller.js 1f5675f 
>   ambari-web/app/controllers/main/service/info/summary.js f1740a7 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/templates/main/service/services/hive.hbs 617f6ce 
>   ambari-web/app/views/main/service/info/summary.js 7e0d0bb 
>   ambari-web/app/views/main/service/services/hive.js c1a0f58 
>   ambari-web/test/views/main/service/services/hive_test.js a31ba62 
>   ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46987/diff/
> 
> 
> Testing
> ---
> 
> Verified the patch to work manually.
> Verified that ambari-web unit tests passes with the patch:
> 27525 tests complete (27 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Re: Review Request 46987: Show the connect string with the HiveServer instance

2016-05-04 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/#review131733
---



The width of the field for this string seems be too small. I can only see 
"jdbc:hive2://c6402".

- Zhe (Joe) Wang


On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46987/
> ---
> 
> (Updated May 4, 2016, 5:52 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16244
> https://issues.apache.org/jira/browse/AMBARI-16244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Zookeeper based service discovery is used, then Hive summary page should 
> show JDBC connect string for HiveServer2 and HiveServer2 Interactive 
> instances.
> The semantics for this will be
> jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f92b489 
>   ambari-web/app/assets/img/clippy.svg PRE-CREATION 
>   ambari-web/app/controllers/global/configuration_controller.js 1f5675f 
>   ambari-web/app/controllers/main/service/info/summary.js f1740a7 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/templates/main/service/services/hive.hbs 617f6ce 
>   ambari-web/app/views/main/service/info/summary.js 7e0d0bb 
>   ambari-web/app/views/main/service/services/hive.js c1a0f58 
>   ambari-web/test/views/main/service/services/hive_test.js a31ba62 
>   ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46987/diff/
> 
> 
> Testing
> ---
> 
> Verified the patch to work manually.
> Verified that ambari-web unit tests passes with the patch:
> 27525 tests complete (27 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Re: Review Request 46987: Show the connect string with the HiveServer instance

2016-05-04 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/#review131734
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46987/
> ---
> 
> (Updated May 4, 2016, 5:52 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16244
> https://issues.apache.org/jira/browse/AMBARI-16244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Zookeeper based service discovery is used, then Hive summary page should 
> show JDBC connect string for HiveServer2 and HiveServer2 Interactive 
> instances.
> The semantics for this will be
> jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f92b489 
>   ambari-web/app/assets/img/clippy.svg PRE-CREATION 
>   ambari-web/app/controllers/global/configuration_controller.js 1f5675f 
>   ambari-web/app/controllers/main/service/info/summary.js f1740a7 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/templates/main/service/services/hive.hbs 617f6ce 
>   ambari-web/app/views/main/service/info/summary.js 7e0d0bb 
>   ambari-web/app/views/main/service/services/hive.js c1a0f58 
>   ambari-web/test/views/main/service/services/hive_test.js a31ba62 
>   ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46987/diff/
> 
> 
> Testing
> ---
> 
> Verified the patch to work manually.
> Verified that ambari-web unit tests passes with the patch:
> 27525 tests complete (27 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Re: Review Request 46987: Show the connect string with the HiveServer instance

2016-05-04 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/#review131728
---


Ship it!




Ship It!

- Richard Zang


On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46987/
> ---
> 
> (Updated May 4, 2016, 5:52 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16244
> https://issues.apache.org/jira/browse/AMBARI-16244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Zookeeper based service discovery is used, then Hive summary page should 
> show JDBC connect string for HiveServer2 and HiveServer2 Interactive 
> instances.
> The semantics for this will be
> jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f92b489 
>   ambari-web/app/assets/img/clippy.svg PRE-CREATION 
>   ambari-web/app/controllers/global/configuration_controller.js 1f5675f 
>   ambari-web/app/controllers/main/service/info/summary.js f1740a7 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/templates/main/service/services/hive.hbs 617f6ce 
>   ambari-web/app/views/main/service/info/summary.js 7e0d0bb 
>   ambari-web/app/views/main/service/services/hive.js c1a0f58 
>   ambari-web/test/views/main/service/services/hive_test.js a31ba62 
>   ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46987/diff/
> 
> 
> Testing
> ---
> 
> Verified the patch to work manually.
> Verified that ambari-web unit tests passes with the patch:
> 27525 tests complete (27 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>



Review Request 46987: Show the connect string with the HiveServer instance

2016-05-04 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/
---

Review request for Ambari, Richard Zang and Srimanth Gunturi.


Bugs: AMBARI-16244
https://issues.apache.org/jira/browse/AMBARI-16244


Repository: ambari


Description
---

If Zookeeper based service discovery is used, then Hive summary page should 
show JDBC connect string for HiveServer2 and HiveServer2 Interactive instances.
The semantics for this will be
jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=


Diffs
-

  LICENSE.txt f92b489 
  ambari-web/app/assets/img/clippy.svg PRE-CREATION 
  ambari-web/app/controllers/global/configuration_controller.js 1f5675f 
  ambari-web/app/controllers/main/service/info/summary.js f1740a7 
  ambari-web/app/messages.js c5e1145 
  ambari-web/app/templates/main/service/services/hive.hbs 617f6ce 
  ambari-web/app/views/main/service/info/summary.js 7e0d0bb 
  ambari-web/app/views/main/service/services/hive.js c1a0f58 
  ambari-web/test/views/main/service/services/hive_test.js a31ba62 
  ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION 

Diff: https://reviews.apache.org/r/46987/diff/


Testing
---

Verified the patch to work manually.
Verified that ambari-web unit tests passes with the patch:
27525 tests complete (27 seconds)
154 tests pending


Thanks,

Jaimin Jetly