Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48293/#review136378
---


Ship it!




Ship It!

- Yusaku Sako


On June 6, 2016, 9:24 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48293/
> ---
> 
> (Updated June 6, 2016, 9:24 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17072
> https://issues.apache.org/jira/browse/AMBARI-17072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are a two important hive-site.xml parameters that govern the url:
> i) hive.server2.webui.port : This is the port on which the webui hosts itself.
> ii) hive.server2.webui.use.ssl : Whether or not ssl is used.
> If ssl is used, we use https:// and if not, we use http:// . Either way, the 
> service seems to be intended to be hosted at :/llap.html
> this will work only for hive2 and not hive1.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  8e32e9dd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
>  e586d20 
> 
> Diff: https://reviews.apache.org/r/48293/diff/
> 
> 
> Testing
> ---
> 
> Tested the patch manualy on the cluster.
> unit tests not required as only metadata (quicklinks.json) is cahnged as part 
> of the patch.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48293/#review136377
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 263)


I had some concerns about this "on-ambari-upgrade", "on-stack-upgrade", 
etc., but this is a separate issue that others have addressed (e.g., 
https://reviews.apache.org/r/48212/#comment201053)


- Yusaku Sako


On June 6, 2016, 9:24 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48293/
> ---
> 
> (Updated June 6, 2016, 9:24 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17072
> https://issues.apache.org/jira/browse/AMBARI-17072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are a two important hive-site.xml parameters that govern the url:
> i) hive.server2.webui.port : This is the port on which the webui hosts itself.
> ii) hive.server2.webui.use.ssl : Whether or not ssl is used.
> If ssl is used, we use https:// and if not, we use http:// . Either way, the 
> service seems to be intended to be hosted at :/llap.html
> this will work only for hive2 and not hive1.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  8e32e9dd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
>  e586d20 
> 
> Diff: https://reviews.apache.org/r/48293/diff/
> 
> 
> Testing
> ---
> 
> Tested the patch manualy on the cluster.
> unit tests not required as only metadata (quicklinks.json) is cahnged as part 
> of the patch.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48293/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-17072
https://issues.apache.org/jira/browse/AMBARI-17072


Repository: ambari


Description
---

There are a two important hive-site.xml parameters that govern the url:
i) hive.server2.webui.port : This is the port on which the webui hosts itself.
ii) hive.server2.webui.use.ssl : Whether or not ssl is used.
If ssl is used, we use https:// and if not, we use http:// . Either way, the 
service seems to be intended to be hosted at :/llap.html
this will work only for hive2 and not hive1.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 8e32e9dd 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
 e586d20 

Diff: https://reviews.apache.org/r/48293/diff/


Testing
---

Tested the patch manualy on the cluster.
unit tests not required as only metadata (quicklinks.json) is cahnged as part 
of the patch.


Thanks,

Jaimin Jetly