Re: Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/#review144027 --- Ship it! Ship It! - Matt On July 28, 2016, 2:30 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50547/ > --- > > (Updated July 28, 2016, 2:30 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and > Matt. > > > Bugs: AMBARI-17939 > https://issues.apache.org/jira/browse/AMBARI-17939 > > > Repository: ambari > > > Description > --- > > When HAWQ is added to existing cluster, some HDFS properties do not take > recommended values, so there should be validations that alert the user to the > fact that the properties need to be updated for HAWQ to function optimally. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 9f85518 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > f82655d > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py > b3edae4 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > ff87adb > > Diff: https://reviews.apache.org/r/50547/diff/ > > > Testing > --- > > tested manually and update unit tests: > -- > Ran 66 tests in 0.285s > OK > > > Thanks, > > Alexander Denissov > >
Re: Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/ --- (Updated July 28, 2016, 9:30 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and Matt. Changes --- updated patch, removed HAWQ recommendations / validations from HDP 2.3 stack_advisor, as they are now available in HAWQServiceAdvisor Bugs: AMBARI-17939 https://issues.apache.org/jira/browse/AMBARI-17939 Repository: ambari Description --- When HAWQ is added to existing cluster, some HDFS properties do not take recommended values, so there should be validations that alert the user to the fact that the properties need to be updated for HAWQ to function optimally. Diffs (updated) - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 9f85518 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py f82655d ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py b3edae4 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py ff87adb Diff: https://reviews.apache.org/r/50547/diff/ Testing --- tested manually and update unit tests: -- Ran 66 tests in 0.285s OK Thanks, Alexander Denissov
Review Request 50547: AMBARI-17939: Validations are missing for HDFS properties recommended by HAWQ
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50547/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and Matt. Bugs: AMBARI-17939 https://issues.apache.org/jira/browse/AMBARI-17939 Repository: ambari Description --- When HAWQ is added to existing cluster, some HDFS properties do not take recommended values, so there should be validations that alert the user to the fact that the properties need to be updated for HAWQ to function optimally. Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 9f85518 ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py b3edae4 Diff: https://reviews.apache.org/r/50547/diff/ Testing --- tested manually and update unit tests: -- Ran 66 tests in 0.285s OK Thanks, Alexander Denissov
