Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
> On Oct. 12, 2016, 5:42 p.m., Alejandro Fernandez wrote: > > How much was the improvement? After the fix, improved timings are as follows: *ExecutionScheduleManagerTest :* After Improvements - ~11.3 secs Before Improvement - ~30.6 secs *UpgradeCatalog221Test :* After Improvements - ~11.0 secs Before Improvement - ~30.5 secs - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/#review152353 --- On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52757/ > --- > > (Updated Oct. 11, 2016, 11:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18575 > https://issues.apache.org/jira/browse/AMBARI-18575 > > > Repository: ambari > > > Description > --- > > Issue: > > **Current time taken:** > == > > ||Test||Count||Time (s)|| > |org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586| > |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685| > > > **Individual tests time taken is as follows:** > == > > **UpgradeCatalog221Test:** > > - init() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |init()|10197| > |1|testUpdateAmsHbaseSiteConfigs| 198| > | |init()|3140| > |2|testExecuteDDLUpdates| 17| > | |init()|2377| > |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6| > | |init()|2396| > |4|testExecuteDMLUpdates| 18| > | |init()|2203| > |5|testUpdateTezConfigs| 11| > | |init()|2011| > |6|testUpdateAmsHbaseEnvContent| 0| > | |init()|1953| > |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0| > | |init()|1882| > |8|testUpdateOozieConfigs| 2| > | |init()|1871| > |9|testUpdateAmsEnvContent| 0| > | |init()|1801| > |10|testUpdateRangerKmsDbksConfigs| 2| > | |init()|1735| > |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0| > | |init()|1693| > |12|testUpdateAmsHbaseSecuritySiteConfigs| 5| > | |init()|1626| > |13|testUpdateAlertDefinitions| 19| > > > *ExecutionScheduleManagerTest:* > - setup() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |setup()|10111| > |1|testUpdateBatchRequest| 249| > | |after()|2| > | |setup()|3234| > |2|testExecuteBatchRequest| 59| > | |after()|1| > | |setup()|2480| > |3|testScheduleBatch| 40| > | |after()|1| > | |setup()|2381| > |4|testFinalizeBeforeExit| 28| > | |after()|1| > | |setup()|2312| > |5|testDeleteAllJobs| 17| > | |after()|1| > | |setup()|2141| > |6|testFinalizeBatch| 64| > | |after()|1| > | |setup()|1970| > |7|testPointInTimeExecutionJob| 18| > | |after()|2| > | |setup()|1944| > |8|testHasToleranceThresholdExceeded| 68| > | |after()|1| > | |setup()|1994| > |9|testGetBatchRequestResponse| 59| > | |after()|1| > > > **Fix:** > > > Make test's before and after functions as @BeforeClass @AfterClass methods. > > > Diffs > - > > > ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java > f2fe3b8 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java > e754a41 > > Diff: https://reviews.apache.org/r/52757/diff/ > > > Testing > --- > > - Locally: Passes > - Jenkins pending. > > > Thanks, > > Swapan Shridhar > >
Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/#review152353 --- Ship it! How much was the improvement? - Alejandro Fernandez On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52757/ > --- > > (Updated Oct. 11, 2016, 11:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18575 > https://issues.apache.org/jira/browse/AMBARI-18575 > > > Repository: ambari > > > Description > --- > > Issue: > > **Current time taken:** > == > > ||Test||Count||Time (s)|| > |org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586| > |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685| > > > **Individual tests time taken is as follows:** > == > > **UpgradeCatalog221Test:** > > - init() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |init()|10197| > |1|testUpdateAmsHbaseSiteConfigs| 198| > | |init()|3140| > |2|testExecuteDDLUpdates| 17| > | |init()|2377| > |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6| > | |init()|2396| > |4|testExecuteDMLUpdates| 18| > | |init()|2203| > |5|testUpdateTezConfigs| 11| > | |init()|2011| > |6|testUpdateAmsHbaseEnvContent| 0| > | |init()|1953| > |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0| > | |init()|1882| > |8|testUpdateOozieConfigs| 2| > | |init()|1871| > |9|testUpdateAmsEnvContent| 0| > | |init()|1801| > |10|testUpdateRangerKmsDbksConfigs| 2| > | |init()|1735| > |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0| > | |init()|1693| > |12|testUpdateAmsHbaseSecuritySiteConfigs| 5| > | |init()|1626| > |13|testUpdateAlertDefinitions| 19| > > > *ExecutionScheduleManagerTest:* > - setup() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |setup()|10111| > |1|testUpdateBatchRequest| 249| > | |after()|2| > | |setup()|3234| > |2|testExecuteBatchRequest| 59| > | |after()|1| > | |setup()|2480| > |3|testScheduleBatch| 40| > | |after()|1| > | |setup()|2381| > |4|testFinalizeBeforeExit| 28| > | |after()|1| > | |setup()|2312| > |5|testDeleteAllJobs| 17| > | |after()|1| > | |setup()|2141| > |6|testFinalizeBatch| 64| > | |after()|1| > | |setup()|1970| > |7|testPointInTimeExecutionJob| 18| > | |after()|2| > | |setup()|1944| > |8|testHasToleranceThresholdExceeded| 68| > | |after()|1| > | |setup()|1994| > |9|testGetBatchRequestResponse| 59| > | |after()|1| > > > **Fix:** > > > Make test's before and after functions as @BeforeClass @AfterClass methods. > > > Diffs > - > > > ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java > f2fe3b8 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java > e754a41 > > Diff: https://reviews.apache.org/r/52757/diff/ > > > Testing > --- > > - Locally: Passes > - Jenkins pending. > > > Thanks, > > Swapan Shridhar > >
Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/#review152307 --- Ship it! Ship It! - Sumit Mohanty On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52757/ > --- > > (Updated Oct. 11, 2016, 11:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18575 > https://issues.apache.org/jira/browse/AMBARI-18575 > > > Repository: ambari > > > Description > --- > > Issue: > > **Current time taken:** > == > > ||Test||Count||Time (s)|| > |org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586| > |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685| > > > **Individual tests time taken is as follows:** > == > > **UpgradeCatalog221Test:** > > - init() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |init()|10197| > |1|testUpdateAmsHbaseSiteConfigs| 198| > | |init()|3140| > |2|testExecuteDDLUpdates| 17| > | |init()|2377| > |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6| > | |init()|2396| > |4|testExecuteDMLUpdates| 18| > | |init()|2203| > |5|testUpdateTezConfigs| 11| > | |init()|2011| > |6|testUpdateAmsHbaseEnvContent| 0| > | |init()|1953| > |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0| > | |init()|1882| > |8|testUpdateOozieConfigs| 2| > | |init()|1871| > |9|testUpdateAmsEnvContent| 0| > | |init()|1801| > |10|testUpdateRangerKmsDbksConfigs| 2| > | |init()|1735| > |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0| > | |init()|1693| > |12|testUpdateAmsHbaseSecuritySiteConfigs| 5| > | |init()|1626| > |13|testUpdateAlertDefinitions| 19| > > > *ExecutionScheduleManagerTest:* > - setup() function takes most of the time. > > ||Test No.||Test||Time (micro secs)|| > | |setup()|10111| > |1|testUpdateBatchRequest| 249| > | |after()|2| > | |setup()|3234| > |2|testExecuteBatchRequest| 59| > | |after()|1| > | |setup()|2480| > |3|testScheduleBatch| 40| > | |after()|1| > | |setup()|2381| > |4|testFinalizeBeforeExit| 28| > | |after()|1| > | |setup()|2312| > |5|testDeleteAllJobs| 17| > | |after()|1| > | |setup()|2141| > |6|testFinalizeBatch| 64| > | |after()|1| > | |setup()|1970| > |7|testPointInTimeExecutionJob| 18| > | |after()|2| > | |setup()|1944| > |8|testHasToleranceThresholdExceeded| 68| > | |after()|1| > | |setup()|1994| > |9|testGetBatchRequestResponse| 59| > | |after()|1| > > > **Fix:** > > > Make test's before and after functions as @BeforeClass @AfterClass methods. > > > Diffs > - > > > ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java > f2fe3b8 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java > e754a41 > > Diff: https://reviews.apache.org/r/52757/diff/ > > > Testing > --- > > - Locally: Passes > - Jenkins pending. > > > Thanks, > > Swapan Shridhar > >
Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52757/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-18575 https://issues.apache.org/jira/browse/AMBARI-18575 Repository: ambari Description --- Issue: **Current time taken:** == ||Test||Count||Time (s)|| |org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586| |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685| **Individual tests time taken is as follows:** == **UpgradeCatalog221Test:** - init() function takes most of the time. ||Test No.||Test||Time (micro secs)|| | |init()|10197| |1|testUpdateAmsHbaseSiteConfigs| 198| | |init()|3140| |2|testExecuteDDLUpdates| 17| | |init()|2377| |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6| | |init()|2396| |4|testExecuteDMLUpdates| 18| | |init()|2203| |5|testUpdateTezConfigs| 11| | |init()|2011| |6|testUpdateAmsHbaseEnvContent| 0| | |init()|1953| |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0| | |init()|1882| |8|testUpdateOozieConfigs| 2| | |init()|1871| |9|testUpdateAmsEnvContent| 0| | |init()|1801| |10|testUpdateRangerKmsDbksConfigs| 2| | |init()|1735| |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0| | |init()|1693| |12|testUpdateAmsHbaseSecuritySiteConfigs| 5| | |init()|1626| |13|testUpdateAlertDefinitions| 19| *ExecutionScheduleManagerTest:* - setup() function takes most of the time. ||Test No.||Test||Time (micro secs)|| | |setup()|10111| |1|testUpdateBatchRequest| 249| | |after()|2| | |setup()|3234| |2|testExecuteBatchRequest| 59| | |after()|1| | |setup()|2480| |3|testScheduleBatch| 40| | |after()|1| | |setup()|2381| |4|testFinalizeBeforeExit| 28| | |after()|1| | |setup()|2312| |5|testDeleteAllJobs| 17| | |after()|1| | |setup()|2141| |6|testFinalizeBatch| 64| | |after()|1| | |setup()|1970| |7|testPointInTimeExecutionJob| 18| | |after()|2| | |setup()|1944| |8|testHasToleranceThresholdExceeded| 68| | |after()|1| | |setup()|1994| |9|testGetBatchRequestResponse| 59| | |after()|1| **Fix:** Make test's before and after functions as @BeforeClass @AfterClass methods. Diffs - ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java f2fe3b8 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java e754a41 Diff: https://reviews.apache.org/r/52757/diff/ Testing --- - Locally: Passes - Jenkins pending. Thanks, Swapan Shridhar
