Re: Review Request 55175: Hive View 2.0 : add REST endpoint for renaming a table

2017-01-04 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55175/#review160489
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 4, 2017, 1:03 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55175/
> ---
> 
> (Updated Jan. 4, 2017, 1:03 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19362
> https://issues.apache.org/jira/browse/AMBARI-19362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added REST endpoint ("databases/{database_id}/tables/{table_id}/rename") for 
> renaming a table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  5a2d389 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  3d4e7d7 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
>   
> contrib/views/hive20/src/test/rest/postman/HIVE20_ENVIRONMENT.postman_environment.json
>  PRE-CREATION 
>   contrib/views/hive20/src/test/rest/postman/hive2.postman_collection.json 
> c7ce0c9 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55175/diff/
> 
> 
> Testing
> ---
> 
> added test case RenameTableQueryGeneratorSpecTest
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 55175: Hive View 2.0 : add REST endpoint for renaming a table

2017-01-04 Thread Rohit Choudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55175/#review160488
---


Ship it!




Ship It!

- Rohit Choudhary


On Jan. 4, 2017, 1:03 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55175/
> ---
> 
> (Updated Jan. 4, 2017, 1:03 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19362
> https://issues.apache.org/jira/browse/AMBARI-19362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added REST endpoint ("databases/{database_id}/tables/{table_id}/rename") for 
> renaming a table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java
>  PRE-CREATION 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
>  5a2d389 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
>  3d4e7d7 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy
>  PRE-CREATION 
>   
> contrib/views/hive20/src/test/rest/postman/HIVE20_ENVIRONMENT.postman_environment.json
>  PRE-CREATION 
>   contrib/views/hive20/src/test/rest/postman/hive2.postman_collection.json 
> c7ce0c9 
>   contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55175/diff/
> 
> 
> Testing
> ---
> 
> added test case RenameTableQueryGeneratorSpecTest
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>