Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165754
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 15, 2017, 6:55 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 6:55 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>



Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165747
---


Ship it!




Ship It!

- Robert Levas


On Feb. 15, 2017, 11:55 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>



Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165725
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 15, 2017, 5:55 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 5:55 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>



Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Eugene Chekanskiy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/
---

(Updated Feb. 15, 2017, 4:55 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
Brodetskyi.


Changes
---

added upgrade code.


Bugs: AMBARI-20008
https://issues.apache.org/jira/browse/AMBARI-20008


Repository: ambari


Description
---

Add "Manage alert notifications" authorization and protect resoure with it.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 4010528 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
 969772f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 5e929e3 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 f4212d6 

Diff: https://reviews.apache.org/r/56659/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy



Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165542
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 5:07 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 14, 2017, 5:07 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>



Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165520
---


Ship it!




Ship It!

- Robert Levas


On Feb. 14, 2017, 7:21 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 14, 2017, 7:21 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>



Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Eugene Chekanskiy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20008
https://issues.apache.org/jira/browse/AMBARI-20008


Repository: ambari


Description
---

Add "Manage alert notifications" authorization and protect resoure with it.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 4010528 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
 969772f 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 

Diff: https://reviews.apache.org/r/56659/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy