Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122872 --- Ship it! Ship It! - Sid Wagle On March 9, 2016, 8:59 p.m., S

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
> On March 9, 2016, 11:07 p.m., Aravindan Vijayan wrote: > > Ship It! Thanks Aravindan. I'd request you or Sid to push the change to trunk once Sid has reviewed it. - Shantanu --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122828 --- Ship it! Ship It! - Aravindan Vijayan On March 9, 2016, 8:59

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
> On March 9, 2016, 9:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector, > > line 382 > > > > > > Quick question, why do we need a leading ":" in

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
> On March 9, 2016, 8:13 p.m., Aravindan Vijayan wrote: > > I think Point 1 will not be needed since we execute the ams-env.sh in > > ambari-metrics-collector. > > > > # execute ams-env.sh > > if [[ -f "${COLLECTOR_CONF_DIR}/ams-env.sh" ]]; then > > . "${COLLECTOR_CONF_DIR}/ams-env.sh" > > el

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
> On March 9, 2016, 8:13 p.m., Aravindan Vijayan wrote: > > I think Point 1 will not be needed since we execute the ams-env.sh in > > ambari-metrics-collector. > > > > # execute ams-env.sh > > if [[ -f "${COLLECTOR_CONF_DIR}/ams-env.sh" ]]; then > > . "${COLLECTOR_CONF_DIR}/ams-env.sh" > > el

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
> On March 9, 2016, 8:13 p.m., Aravindan Vijayan wrote: > > I think Point 1 will not be needed since we execute the ams-env.sh in > > ambari-metrics-collector. > > > > # execute ams-env.sh > > if [[ -f "${COLLECTOR_CONF_DIR}/ams-env.sh" ]]; then > > . "${COLLECTOR_CONF_DIR}/ams-env.sh" > > el

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Sid Wagle
> On March 9, 2016, 8:13 p.m., Aravindan Vijayan wrote: > > I think Point 1 will not be needed since we execute the ams-env.sh in > > ambari-metrics-collector. > > > > # execute ams-env.sh > > if [[ -f "${COLLECTOR_CONF_DIR}/ams-env.sh" ]]; then > > . "${COLLECTOR_CONF_DIR}/ams-env.sh" > > el

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122808 --- ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-me

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122790 --- I think Point 1 will not be needed since we execute the ams-env.sh

Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-08 Thread Shantanu Mundkur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/ --- Review request for Ambari and Sid Wagle. Bugs: AMBARI-15331 https://issues.