Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/ --- (Updated March 18, 2016, 8:57 p.m.) Review request for Ambari, Alejandro

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Jayush Luniya
> On March 16, 2016, 5:53 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 106 > > > > > > This may not necessarily be a rolling

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123892 --- Ship it!

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review124302 --- Ship it! Ship It! - Alejandro Fernandez On March 18, 2016,

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
> On March 15, 2016, 2:44 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 375 > > > > > > I don't really understand this abstraction. You're

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
> On March 15, 2016, 2:44 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py, > > line 42 > > > > > > This should no longer be accessible outside of

Re: Review Request 44835: AMBARI-15420: Refactor resource_management library

2016-03-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44835/#review123683 ---