Re: Review Request 44983: Service version display should be based on Version Definition

2016-03-19 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44983/
---

(Updated March 18, 2016, 10:43 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-15473
https://issues.apache.org/jira/browse/AMBARI-15473


Repository: ambari


Description
---

Add {{stack_services}} to the repository_version endpoint, similar to the 
{{services}} attribute that lists the available services.

This will return a list of all stack services as they pertain to the Version 
Definition File.  This is required to show the correct versions that are 
available for a stack based on the repo_version.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
 c298e0a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestServiceInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 93ac767 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 f2939c7 
  ambari-server/src/test/resources/version_definition_test.xml 69ea581 

Diff: https://reviews.apache.org/r/44983/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 3963, Failures: 0, Errors: 0, Skipped: 33

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 35:40.607s
[INFO] Finished at: Fri Mar 18 10:34:17 EDT 2016
[INFO] Final Memory: 37M/770M
[INFO] 


Thanks,

Nate Cole



Review Request 44983: Service version display should be based on Version Definition

2016-03-19 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44983/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-15473
https://issues.apache.org/jira/browse/AMBARI-15473


Repository: ambari


Description
---

Add {{stack_services}} to the repository_version endpoint, similar to the 
{{services}} attribute that lists the available services.

This will return a list of all stack services as they pertain to the Version 
Definition File.  This is required to show the correct versions that are 
available for a stack based on the repo_version.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
 c298e0a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestServiceInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 93ac767 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 f2939c7 
  ambari-server/src/test/resources/version_definition_test.xml 69ea581 

Diff: https://reviews.apache.org/r/44983/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole



Re: Review Request 44983: Service version display should be based on Version Definition

2016-03-18 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44983/#review124177
---


Ship it!




Ship It!

- Jonathan Hurley


On March 17, 2016, 5:53 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44983/
> ---
> 
> (Updated March 17, 2016, 5:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15473
> https://issues.apache.org/jira/browse/AMBARI-15473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add {{stack_services}} to the repository_version endpoint, similar to the 
> {{services}} attribute that lists the available services.
> 
> This will return a list of all stack services as they pertain to the Version 
> Definition File.  This is required to show the correct versions that are 
> available for a stack based on the repo_version.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  c298e0a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ManifestServiceInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  93ac767 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  f2939c7 
>   ambari-server/src/test/resources/version_definition_test.xml 69ea581 
> 
> Diff: https://reviews.apache.org/r/44983/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>