Re: Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Nate Cole
> On March 30, 2016, 10:21 a.m., Jonathan Hurley wrote: > > contrib/version-builder/version_builder.py, line 231 > > > > > > Should this be a member of the class; seems like it's only called in > > the context of

Re: Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45487/#review126107 --- Ship it! argparse is my only real concern; I don't know how it

Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45487/ --- Review request for Ambari and Jonathan Hurley. Bugs: AMBARI-15631