---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45809/#review127309
---
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Квітень 6, 2016, 10:59 до полудня, Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45809/
> ---
>
> (Updated Квітень 6, 2016, 10:59 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15729
> https://issues.apache.org/jira/browse/AMBARI-15729
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Ambari server script is using hard coded path to load _log4.properties_ file
>
> **serverConfiguration.py**
>
>
>
> self.OUT_DIR =
> parse_log4j_file(AmbariPath.get("/etc/ambari-server/conf/log4j.properties"))['ambari.log.dir’]
>
>
> In case Ambari server is installed to other than the default location amber
> server script won't be able to load log4j.properties
>
> _get_conf_dir()_ should be used to determine the path of log4j.properties
> file.
>
> e.g.
>
>
>
>
> self.OUT_DIR = parse_log4j_file(get_conf_dir() +
> "/log4j.properties"))['ambari.log.dir’]
>
>
> Diffs
> -
>
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 5a0c8e8
>
> Diff: https://reviews.apache.org/r/45809/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
