Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review128140 --- Ship it! Ship It! - Sid Wagle On April 11, 2016, 3:18 p.m.,

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this > >

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/ --- (Updated Апрель 11, 2016, 3:18 п.п.) Review request for Ambari, Aravindan Vijay

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 117-118 > > > > > > Any reason you chose to use httplib here instead of urllib2? I thin

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this > >

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 8, 2016, 12:18 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, line 24 > > > > > > Why not urllib2? urllib2 doesn't have urlencode() method. Common usage u

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 7, 2016, 11:57 п.п., Sid Wagle wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, line 157 > > > > > > OrderedDict support is only 2.7+ Made it unordered. For currently supported a

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On Апрель 7, 2016, 11:57 п.п., Sid Wagle wrote: > > Very nice pythonic changes to reduce verbosity (y) > > > > Why are we not chanigng the current script type alerts to use new scheme ? current script alert is to HDFS awared, but AmsAlert is a general implementation for checking any componen

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

> On April 8, 2016, 12:18 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py, lines 66-70 > > > > > > Since this is contacting AMS, is there a better place to get this > >

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127769 --- Fix it, then Ship it! ambari-agent/src/main/python/ambari_agen

Re: Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/#review127697 --- Very nice pythonic changes to reduce verbosity (y) Why are we not

Review Request 45873: Create a new alert type that is based on timeseries metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45873/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle. B