Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46269/#review129820 --- Ship it! Ship It! - Nate Cole On April 20, 2016, 4:25 p.m.,

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
> On April 15, 2016, 1:52 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-18 Thread Balázs Bence Sári
> On April 15, 2016, 1:52 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Nate Cole
> On April 15, 2016, 10:02 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql, line > > 1572 > > > > > > Quartz tables are not ours and I don't know the

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Nate Cole
> On April 15, 2016, 9:52 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Balázs Bence Sári
> On April 15, 2016, 2:02 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql, line > > 1572 > > > > > > Quartz tables are not ours and I don't know the implications

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46269/#review129118 ---

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Jonathan Hurley
> On April 15, 2016, 9:52 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184 > > > > > > Let's be consistent. Either: > > pk_sc_desired_state > >

Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

2016-04-15 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46269/ --- Review request for Ambari, Jonathan Robie, Nate Cole, and Nahappan Somasundaram.