----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46667/#review130640 -----------------------------------------------------------
AMS changes LGTM. - Aravindan Vijayan On April 26, 2016, 4:08 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46667/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 4:08 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16108 > https://issues.apache.org/jira/browse/AMBARI-16108 > > > Repository: ambari > > > Description > ------- > > Ambari agent changes to push hive metrics to AMS: > 1) Add configs to hiveserver2-site and hivemetastore-site > 2) create hivemetastore-site for HDP-2.5.0 > 2) Add necessary templates to the hive conf dir > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 8f27b48 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml > 42a7a4a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 930dd4c > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > aa561f8 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 733064e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hivemetastore-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-site.xml > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py > f63fcd4 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 26e3f72 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > d90d977 > > Diff: https://reviews.apache.org/r/46667/diff/ > > > Testing > ------- > > verified manually that grafana graphs for hive service appears with the patch > Verified ambari-agent unit tests passes > > > Thanks, > > Jaimin Jetly > >
