Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-05-17 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review133610
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 13, 2016, 7:09 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46738/
> ---
> 
> (Updated May 13, 2016, 7:09 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16138
> https://issues.apache.org/jira/browse/AMBARI-16138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
> hive auth based on the hive and hdfs service config.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  f36e640 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 05b55d2 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
>  f5e9bcf 
>   contrib/views/hive/src/main/resources/view.xml 8f8a470 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java
>  25db721 
>   contrib/views/pig/src/main/resources/view.xml 9df91f8 
>   contrib/views/tez/readme.md fdb9459 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java
>  440ac65 
>   contrib/views/tez/src/main/resources/view.xml d8105f1 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  1bace94 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  4911455 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  8b45cd6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  c7c0990 
> 
> Diff: https://reviews.apache.org/r/46738/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested on local Vm.
> Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-05-13 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

(Updated May 13, 2016, 7:09 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Added Update for tez view property change


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 3547ad3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 f36e640 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/pig/src/main/resources/view.xml 9df91f8 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 1bace94 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 4911455 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 8b45cd6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 c7c0990 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-05-03 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review131535
---




contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 (line 54)


You may need to think about upgrading the ViewInstanceProperties tables. 
This would fail if upgrade is not done in database.


- DIPAYAN BHOWMICK


On April 27, 2016, 2:16 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46738/
> ---
> 
> (Updated April 27, 2016, 2:16 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16138
> https://issues.apache.org/jira/browse/AMBARI-16138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
> hive auth based on the hive and hdfs service config.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 05b55d2 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
>  f5e9bcf 
>   contrib/views/hive/src/main/resources/view.xml 8f8a470 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java
>  25db721 
>   contrib/views/pig/src/main/resources/view.xml 9df91f8 
>   contrib/views/tez/readme.md fdb9459 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java
>  440ac65 
>   contrib/views/tez/src/main/resources/view.xml d8105f1 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
> 
> Diff: https://reviews.apache.org/r/46738/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested on local Vm.
> Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-04-27 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

(Updated April 27, 2016, 2:16 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs (updated)
-

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/pig/src/main/resources/view.xml 9df91f8 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-04-27 Thread Ashwin Rajeev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review130774
---


Ship it!




Ship It!

- Ashwin Rajeev


On April 27, 2016, 12:49 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46738/
> ---
> 
> (Updated April 27, 2016, 12:49 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16138
> https://issues.apache.org/jira/browse/AMBARI-16138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
> hive auth based on the hive and hdfs service config.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 05b55d2 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
>  f5e9bcf 
>   contrib/views/hive/src/main/resources/view.xml 8f8a470 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java
>  25db721 
>   contrib/views/tez/readme.md fdb9459 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java
>  440ac65 
>   contrib/views/tez/src/main/resources/view.xml d8105f1 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
> 
> Diff: https://reviews.apache.org/r/46738/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested on local Vm.
> Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

2016-04-27 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs
-

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar