Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review134020 --- Can we used TypedQuery instead of list and subsequent conversions?

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/ --- (Updated May 19, 2016, 6:43 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133976 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-19 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133929 --- Ship it! Ship It! - Ashwin Rajeev On May 17, 2016, 10:10 a.m

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-17 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/ --- (Updated May 17, 2016, 10:10 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-17 Thread Nitiraj Rathore
> On May 16, 2016, 4:48 p.m., Ajit Kumar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 320 > > > > > > Is maxId == 0 valid? yes it is valid. the id of firs

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133399 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133376 --- Minor code formatting comments. ambari-server/src/main/java/org/

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread DIPAYAN BHOWMICK
> On May 16, 2016, 1:58 p.m., DIPAYAN BHOWMICK wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java, > > line 367 > > > > > > Remove these lines Fixit and commit. -

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133352 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 4, 2016, 6:46 a.

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-16 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133351 --- ambari-server/src/main/java/org/apache/ambari/server/view/persist

Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

2016-05-03 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,