Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-24 Thread Don Bosco Durai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/#review134681
---


Ship it!




Ship It!

- Don Bosco Durai


On May 24, 2016, 11:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47605/
> ---
> 
> (Updated May 24, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Gautam Borad, Jaimin Jetly, Jayush Luniya, Oliver Szabo, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16446
> https://issues.apache.org/jira/browse/AMBARI-16446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
> instance.
> Enable Audit to Solr and populate Ranger Audit properties with that Solr 
> instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  aba3025 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  d4418e0 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  fabe2fb 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  ef05604 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  43975af 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 59451b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
>  bfa0fd2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
> b6d7d5b 
> 
> Diff: https://reviews.apache.org/r/47605/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation with Logsearch on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-24 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/
---

(Updated May 24, 2016, 9:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Adding -ns option to create collection


Bugs: AMBARI-16446
https://issues.apache.org/jira/browse/AMBARI-16446


Repository: ambari


Description
---

>From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
>instance.
Enable Audit to Solr and populate Ranger Audit properties with that Solr 
instance.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 aba3025 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 d4418e0 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 fabe2fb 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 ef05604 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
 43975af 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
59451b2 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
 bfa0fd2 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
11aac72 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
b6d7d5b 

Diff: https://reviews.apache.org/r/47605/diff/


Testing
---

Tested Ranger installation with Logsearch on centos 6.


Thanks,

Mugdha Varadkar

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-20 Thread Mugdha Varadkar 


> On May 19, 2016, 5:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> >  line 78
> > 
> >
> > Why not always do the import?

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/#review133983
---


On May 20, 2016, 6:21 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47605/
> ---
> 
> (Updated May 20, 2016, 6:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16446
> https://issues.apache.org/jira/browse/AMBARI-16446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
> instance.
> Enable Audit to Solr and populate Ranger Audit properties with that Solr 
> instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  d4418e0 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  fabe2fb 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  ef05604 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  43975af 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 59451b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
>  bfa0fd2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
> b6d7d5b 
> 
> Diff: https://reviews.apache.org/r/47605/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation with Logsearch on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-20 Thread Mugdha Varadkar 


> On May 19, 2016, 5:32 p.m., Don Bosco Durai wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 990
> > 
> >
> > How is Ranger KMS service handled?

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/#review133990
---


On May 20, 2016, 6:21 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47605/
> ---
> 
> (Updated May 20, 2016, 6:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16446
> https://issues.apache.org/jira/browse/AMBARI-16446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
> instance.
> Enable Audit to Solr and populate Ranger Audit properties with that Solr 
> instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  d4418e0 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  fabe2fb 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  ef05604 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  43975af 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 59451b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
>  bfa0fd2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
> b6d7d5b 
> 
> Diff: https://reviews.apache.org/r/47605/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation with Logsearch on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-20 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/
---

(Updated May 20, 2016, 6:21 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Added logic for Ranger Kms service.


Bugs: AMBARI-16446
https://issues.apache.org/jira/browse/AMBARI-16446


Repository: ambari


Description
---

>From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
>instance.
Enable Audit to Solr and populate Ranger Audit properties with that Solr 
instance.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 d4418e0 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 fabe2fb 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 ef05604 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
 43975af 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
59451b2 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
 bfa0fd2 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
11aac72 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
b6d7d5b 

Diff: https://reviews.apache.org/r/47605/diff/


Testing
---

Tested Ranger installation with Logsearch on centos 6.


Thanks,

Mugdha Varadkar

Re: Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/#review133983
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 (line 78)


Why not always do the import?


- Alejandro Fernandez


On May 19, 2016, 5:22 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47605/
> ---
> 
> (Updated May 19, 2016, 5:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16446
> https://issues.apache.org/jira/browse/AMBARI-16446
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
> instance.
> Enable Audit to Solr and populate Ranger Audit properties with that Solr 
> instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  2e18443 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9e9cadc 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  408418c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  fabe2fb 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  ef05604 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  43975af 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 59451b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  3ec5d05 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 11aac72 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
> b6d7d5b 
> 
> Diff: https://reviews.apache.org/r/47605/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation with Logsearch on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 47605: AMBARI-16446 Ranger audit properties should be configured to use Ambari installed Solr (LogSearch)

2016-05-19 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47605/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jaimin Jetly, Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-16446
https://issues.apache.org/jira/browse/AMBARI-16446


Repository: ambari


Description
---

>From stack 2.5 onwards Ranger Service is dependent on Logsearch for Solr 
>instance.
Enable Audit to Solr and populate Ranger Audit properties with that Solr 
instance.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 408418c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 fabe2fb 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 ef05604 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
 43975af 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
59451b2 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
11aac72 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 
b6d7d5b 

Diff: https://reviews.apache.org/r/47605/diff/


Testing
---

Tested Ranger installation with Logsearch on centos 6.


Thanks,

Mugdha Varadkar