Re: Review Request 47858: Cache service advisors when stack advisor is loaded
> On June 1, 2016, 8:55 p.m., Jayush Luniya wrote: > > Ship It! Lav, can you close the review if the patch is already committed? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135854 --- On May 27, 2016, 7:11 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47858/ > --- > > (Updated May 27, 2016, 7:11 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16665 > https://issues.apache.org/jira/browse/AMBARI-16665 > > > Repository: ambari > > > Description > --- > > With the current implementation, service advisors for the same service are > loaded multiple times in the stack advisor. > > The service advisors should be cached when the stack advisor is loaded and > used where necessary. > > > Diffs > - > > ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 1d6a85c > > Diff: https://reviews.apache.org/r/47858/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ServiceAdvisor implementation for service PXF > was loaded > ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ServiceAdvisor implementation for service > PXF was loaded > ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ServiceAdvisor implementation for > service PXF was loaded > ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ServiceAdvisor implementation for service PXF was loaded > ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135854 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 7:11 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47858/ > --- > > (Updated May 27, 2016, 7:11 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16665 > https://issues.apache.org/jira/browse/AMBARI-16665 > > > Repository: ambari > > > Description > --- > > With the current implementation, service advisors for the same service are > loaded multiple times in the stack advisor. > > The service advisors should be cached when the stack advisor is loaded and > used where necessary. > > > Diffs > - > > ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 1d6a85c > > Diff: https://reviews.apache.org/r/47858/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ServiceAdvisor implementation for service PXF > was loaded > ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ServiceAdvisor implementation for service > PXF was loaded > ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ServiceAdvisor implementation for > service PXF was loaded > ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ServiceAdvisor implementation for service PXF was loaded > ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ServiceAdvisor implementation
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135321 --- Ship it! Ship It! - Matt On May 27, 2016, 12:11 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47858/ > --- > > (Updated May 27, 2016, 12:11 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16665 > https://issues.apache.org/jira/browse/AMBARI-16665 > > > Repository: ambari > > > Description > --- > > With the current implementation, service advisors for the same service are > loaded multiple times in the stack advisor. > > The service advisors should be cached when the stack advisor is loaded and > used where necessary. > > > Diffs > - > > ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 1d6a85c > > Diff: https://reviews.apache.org/r/47858/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ServiceAdvisor implementation for service PXF > was loaded > ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ServiceAdvisor implementation for service > PXF was loaded > ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ServiceAdvisor implementation for > service PXF was loaded > ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ServiceAdvisor implementation for service PXF was loaded > ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ServiceAdvisor implementation for
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135294 --- Ship it! Ship It! - Tim Thorpe On May 27, 2016, 7:11 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47858/ > --- > > (Updated May 27, 2016, 7:11 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16665 > https://issues.apache.org/jira/browse/AMBARI-16665 > > > Repository: ambari > > > Description > --- > > With the current implementation, service advisors for the same service are > loaded multiple times in the stack advisor. > > The service advisors should be cached when the stack advisor is loaded and > used where necessary. > > > Diffs > - > > ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 1d6a85c > > Diff: https://reviews.apache.org/r/47858/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ServiceAdvisor implementation for service PXF > was loaded > ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ServiceAdvisor implementation for service > PXF was loaded > ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ServiceAdvisor implementation for > service PXF was loaded > ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ServiceAdvisor implementation for service PXF was loaded > ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ServiceAdvisor implementation for
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/ --- (Updated May 27, 2016, 7:11 p.m.) Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-16665 https://issues.apache.org/jira/browse/AMBARI-16665 Repository: ambari Description --- With the current implementation, service advisors for the same service are loaded multiple times in the stack advisor. The service advisors should be cached when the stack advisor is loaded and used where necessary. Diffs (updated) - ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 1d6a85c Diff: https://reviews.apache.org/r/47858/diff/ Testing --- Lavs-MacBook-Pro:common ljain$ python -m discover -v test_createComponentLayoutRecommendations_hawq_1_Host (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when HAWQ has already been installed ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, when HAWQ is selected for installation ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, when HAWQ is selected for installation ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_no_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF does not get recommended during Add Service Wizard, when PXF has already been installed ... ServiceAdvisor implementation for service PXF was loaded ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Add Service Wizard, when PXF is selected for installation ... ServiceAdvisor implementation for service PXF was loaded ok test_createComponentLayoutRecommendations_pxf_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Cluster Install Wizard, when PXF is selected for installation ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test layout validations for HAWQ components on a 3-node cluster ... ServiceAdvisor implementation for service HAWQ was loaded ok test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode (test_stack_advisor.TestHDP23StackAdvisor) Test validation warning for HAWQ segment not colocated with DATANODE ... ServiceAdvisor implementation for service HAWQ was loaded ok test_getComponentLayoutValidations_nohawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components on a 3-node cluster ... ok test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_stack_advisor.TestHDP23StackAdvisor) Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok
Re: Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135049 --- Ship it! Ship It! - Tim Thorpe On May 26, 2016, 6:50 p.m., Lav Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47858/ > --- > > (Updated May 26, 2016, 6:50 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16665 > https://issues.apache.org/jira/browse/AMBARI-16665 > > > Repository: ambari > > > Description > --- > > With the current implementation, service advisors for the same service are > loaded multiple times in the stack advisor. > > The service advisors should be cached when the stack advisor is loaded and > used where necessary. > > > Diffs > - > > ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47858/diff/ > > > Testing > --- > > Lavs-MacBook-Pro:common ljain$ python -m discover -v > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation > for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ServiceAdvisor implementation for > service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ServiceAdvisor > implementation for service HAWQ was loaded > ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ServiceAdvisor implementation for service PXF > was loaded > ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ServiceAdvisor implementation for service > PXF was loaded > ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ServiceAdvisor implementation for > service PXF was loaded > ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... > ServiceAdvisor implementation for service HAWQ was loaded > ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ServiceAdvisor implementation for service PXF was loaded > ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ServiceAdvisor implementation for
Review Request 47858: Cache service advisors when stack advisor is loaded
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush Luniya, Matt, and Tim Thorpe. Bugs: AMBARI-16665 https://issues.apache.org/jira/browse/AMBARI-16665 Repository: ambari Description (updated) --- With the current implementation, service advisors for the same service are loaded multiple times in the stack advisor. The service advisors should be cached when the stack advisor is loaded and used where necessary. Diffs (updated) - ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 53c5574 Diff: https://reviews.apache.org/r/47858/diff/ Testing (updated) --- Lavs-MacBook-Pro:common ljain$ python -m discover -v test_createComponentLayoutRecommendations_hawq_1_Host (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when HAWQ has already been installed ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, when HAWQ is selected for installation ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_hawqsegment_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, when HAWQ is selected for installation ... ServiceAdvisor implementation for service HAWQ was loaded ok test_createComponentLayoutRecommendations_no_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF does not get recommended during Add Service Wizard, when PXF has already been installed ... ServiceAdvisor implementation for service PXF was loaded ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Add Service Wizard, when PXF is selected for installation ... ServiceAdvisor implementation for service PXF was loaded ok test_createComponentLayoutRecommendations_pxf_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Cluster Install Wizard, when PXF is selected for installation ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test layout validations for HAWQ components on a 3-node cluster ... ServiceAdvisor implementation for service HAWQ was loaded ok test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode (test_stack_advisor.TestHDP23StackAdvisor) Test validation warning for HAWQ segment not colocated with DATANODE ... ServiceAdvisor implementation for service HAWQ was loaded ok test_getComponentLayoutValidations_nohawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components on a 3-node cluster ... ok test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_stack_advisor.TestHDP23StackAdvisor) Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE ... ServiceAdvisor implementation for service PXF was loaded ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ServiceAdvisor implementation for service PXF was loaded ok
