Re: Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

2016-06-14 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47954/#review137506
---


Ship it!




Ship It!

- Andrew Onischuk


On June 13, 2016, 2:39 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47954/
> ---
> 
> (Updated June 13, 2016, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush 
> Luniya, and Vinod Kumar Vavilapalli.
> 
> 
> Bugs: AMBARI-16907
> https://issues.apache.org/jira/browse/AMBARI-16907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The document here mentioned five properties that need to be updated when the 
> CGroups with Yarn feature is enabled via Ambari web UI. 
> http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/NodeManagerCgroups.html
> 
> Right now, however, only one is auto-changed – 
> "yarn.nodemanager.container-executor.class".
> 
> This is due to a mix of yarn-site.xml metainfo change and the properties name 
> used in the stack_advisor.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  905383a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 03e8150 
> 
> Diff: https://reviews.apache.org/r/47954/diff/
> 
> 
> Testing
> ---
> 
> manually patch a trunk cluster with changes and tested that with the changes, 
> all CGroup required properties are changed when I enabled CPU isolation on 
> the Yarn config tab.
> 
> 
> Thanks,
> 
> Di Li
> 
>



Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

2016-05-27 Thread Di Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47954/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-16907
https://issues.apache.org/jira/browse/AMBARI-16907


Repository: ambari


Description
---

The document here mentioned five properties that need to be updated when the 
CGroups with Yarn feature is enabled via Ambari web UI. 
http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/NodeManagerCgroups.html

Right now, however, only one is auto-changed – 
"yarn.nodemanager.container-executor.class".

This is due to a mix of yarn-site.xml metainfo change and the properties name 
used in the stack_advisor.py


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 905383a 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
03e8150 

Diff: https://reviews.apache.org/r/47954/diff/


Testing
---

manually patch a trunk cluster with changes and tested that with the changes, 
all CGroup required properties are changed when I enabled CPU isolation on the 
Yarn config tab.


Thanks,

Di Li