Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47984/#review135731 --- Ship it! Ship It! - Srimanth Gunturi On May 28, 2016, 5:15 a.m., Sivaguru Chendamaraikannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47984/ > --- > > (Updated May 28, 2016, 5:15 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Tom Beerbower. > > > Bugs: AMBARI-16915 > https://issues.apache.org/jira/browse/AMBARI-16915 > > > Repository: ambari > > > Description > --- > > The commit, > https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a > which accidentally made the storm.topology.submission.notifier.plugin > property mandatory. If the storm defaults yaml config does not set the > property a " " value is set for the property. This causes storm startup to > fail with a Class Not Found exception when starting with Ambari. This change > fixes the stack advisor to not set the property when no value is specified > for it through command line or storm defaults. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 79314f5 > > Diff: https://reviews.apache.org/r/47984/diff/ > > > Testing > --- > > mvn test > > > Thanks, > > Sivaguru Chendamaraikannan > >
Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47984/#review135635 --- Ship it! Ship It! - Tom Beerbower On May 28, 2016, 5:15 a.m., Sivaguru Chendamaraikannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47984/ > --- > > (Updated May 28, 2016, 5:15 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Tom Beerbower. > > > Bugs: AMBARI-16915 > https://issues.apache.org/jira/browse/AMBARI-16915 > > > Repository: ambari > > > Description > --- > > The commit, > https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a > which accidentally made the storm.topology.submission.notifier.plugin > property mandatory. If the storm defaults yaml config does not set the > property a " " value is set for the property. This causes storm startup to > fail with a Class Not Found exception when starting with Ambari. This change > fixes the stack advisor to not set the property when no value is specified > for it through command line or storm defaults. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 79314f5 > > Diff: https://reviews.apache.org/r/47984/diff/ > > > Testing > --- > > mvn test > > > Thanks, > > Sivaguru Chendamaraikannan > >
Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47984/ --- (Updated May 28, 2016, 5:15 a.m.) Review request for Ambari, Srimanth Gunturi and Tom Beerbower. Bugs: AMBARI-16915 https://issues.apache.org/jira/browse/AMBARI-16915 Repository: ambari Description --- The commit, https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a which accidentally made the storm.topology.submission.notifier.plugin property mandatory. If the storm defaults yaml config does not set the property a " " value is set for the property. This causes storm startup to fail with a Class Not Found exception when starting with Ambari. This change fixes the stack advisor to not set the property when no value is specified for it through command line or storm defaults. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 79314f5 Diff: https://reviews.apache.org/r/47984/diff/ Testing (updated) --- mvn test Thanks, Sivaguru Chendamaraikannan
Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47984/ --- Review request for Ambari, Srimanth Gunturi and Tom Beerbower. Bugs: AMBARI-16915 https://issues.apache.org/jira/browse/AMBARI-16915 Repository: ambari Description --- The commit, https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a which accidentally made the storm.topology.submission.notifier.plugin property mandatory. If the storm defaults yaml config does not set the property a " " value is set for the property. This causes storm startup to fail with a Class Not Found exception when starting with Ambari. This change fixes the stack advisor to not set the property when no value is specified for it through command line or storm defaults. Diffs - ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 79314f5 Diff: https://reviews.apache.org/r/47984/diff/ Testing --- Thanks, Sivaguru Chendamaraikannan
