Re: Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48155/#review135863 --- Ship it! Ship It! - bhuvnesh chaudhary On June 1, 2016, 9:02 p.m., Matt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48155/ > --- > > (Updated June 1, 2016, 9:02 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav > Jain. > > > Bugs: AMBARI-16992 > https://issues.apache.org/jira/browse/AMBARI-16992 > > > Repository: ambari > > > Description > --- > > Set hawq_rm_nvcore_limit_perseg as the lowest cpu_count across all HAWQ hosts > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 94e1854 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 6fbdf45 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b931dc6 > > Diff: https://reviews.apache.org/r/48155/diff/ > > > Testing > --- > > Manually tested. > > Added unit test: > ``` > test_createComponentLayoutRecommendations_hawq_1_Host > (test_stack_advisor.TestHDP23StackAdvisor) ... ok > test_createComponentLayoutRecommendations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT does not get recommended during Add Service Wizard, > when HAWQ has already been installed ... ok > test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, > when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_hawqsegment_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that HAWQSEGMENT gets recommended correctly during Cluster Install > Wizard, when HAWQ is selected for installation ... ok > test_createComponentLayoutRecommendations_no_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF does not get recommended during Add Service Wizard, when PXF > has already been installed ... ok > test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Add Service Wizard, when PXF > is selected for installation ... ok > test_createComponentLayoutRecommendations_pxf_cluster_install > (test_stack_advisor.TestHDP23StackAdvisor) > Test that PXF gets recommended correctly during Cluster Install Wizard, when > PXF is selected for installation ... ok > test_getComponentLayoutValidations_hawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test layout validations for HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode > (test_stack_advisor.TestHDP23StackAdvisor) > Test validation warning for HAWQ segment not colocated with DATANODE ... ok > test_getComponentLayoutValidations_nohawq_3_Hosts > (test_stack_advisor.TestHDP23StackAdvisor) > Test no failures when there are no HAWQ components on a 3-node cluster ... ok > test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test NO warning is generated when PXF is co-located with NAMENODE and > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE ... ok > test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn > (test_stack_advisor.TestHDP23StackAdvisor) > Test warning is generated when PXF is not co-located with NAMENODE or > DATANODE ... ok > test_getComponentLayoutValidations_sparkts_no_hive > (test_stack_advisor.TestHDP23StackAdvisor) > Test SparkTS is picked when Hive is not installed ... ok > test_getComponentLayoutValidations_sparkts_with_hive > (test_stack_advisor.TestHDP23StackAdvisor) > Test SparkTS is picked when Hive is installed ... ok > test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor)
Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48155/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain. Bugs: AMBARI-16992 https://issues.apache.org/jira/browse/AMBARI-16992 Repository: ambari Description --- Set hawq_rm_nvcore_limit_perseg as the lowest cpu_count across all HAWQ hosts Diffs - ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 94e1854 ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 6fbdf45 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b931dc6 Diff: https://reviews.apache.org/r/48155/diff/ Testing --- Manually tested. Added unit test: ``` test_createComponentLayoutRecommendations_hawq_1_Host (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_createComponentLayoutRecommendations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when HAWQ has already been installed ... ok test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, when HAWQ is selected for installation ... ok test_createComponentLayoutRecommendations_hawqsegment_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, when HAWQ is selected for installation ... ok test_createComponentLayoutRecommendations_no_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF does not get recommended during Add Service Wizard, when PXF has already been installed ... ok test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Add Service Wizard, when PXF is selected for installation ... ok test_createComponentLayoutRecommendations_pxf_cluster_install (test_stack_advisor.TestHDP23StackAdvisor) Test that PXF gets recommended correctly during Cluster Install Wizard, when PXF is selected for installation ... ok test_getComponentLayoutValidations_hawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test layout validations for HAWQ components on a 3-node cluster ... ok test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode (test_stack_advisor.TestHDP23StackAdvisor) Test validation warning for HAWQ segment not colocated with DATANODE ... ok test_getComponentLayoutValidations_nohawq_3_Hosts (test_stack_advisor.TestHDP23StackAdvisor) Test no failures when there are no HAWQ components on a 3-node cluster ... ok test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn (test_stack_advisor.TestHDP23StackAdvisor) Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE ... ok test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn (test_stack_advisor.TestHDP23StackAdvisor) Test warning is generated when PXF is not co-located with NAMENODE or DATANODE ... ok test_getComponentLayoutValidations_sparkts_no_hive (test_stack_advisor.TestHDP23StackAdvisor) Test SparkTS is picked when Hive is not installed ... ok test_getComponentLayoutValidations_sparkts_with_hive (test_stack_advisor.TestHDP23StackAdvisor) Test SparkTS is picked when Hive is installed ... ok test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendHiveConfigurations_with_atlas (test_stack_advisor.TestHDP23StackAdvisor) ... ok test_recommendKAFKAConfigurations
