Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-16 Thread Daniel Gergely
> On jún. 15, 2016, 3:49 du, Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java, > > line 87 > > > > > > The member annotated with @TestSubject is

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-16 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 16, 2016, 8:24 de) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137749 ---

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137713 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:33

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-15 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 15, 2016, 11:33 de) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-14 Thread Daniel Gergely
> On jún. 14, 2016, 10:28 de, Sandor Magyari wrote: > > Hi Bob, Summit! > > > > Using events instead of polling continusly seems to be a better solution, > > may be would be better to listen to already existing events like > > ActionFinalReportReceivedEvent which is fired when a command

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-14 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137477 --- Hi Bob, Summit! Using events instead of polling continusly seems

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-14 Thread Daniel Gergely
> On jún. 13, 2016, 9:23 du, Sumit Mohanty wrote: > > Does this handle UI based cluster deployments? > > Probably there is no good way for UI based deplyments to know if a specific > > request is a cluster create request or not. > > > > What happens after cluster creation is over - does the

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-14 Thread Daniel Gergely
> On jún. 13, 2016, 4:51 du, Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java, > > line 191 > > > > > > I'm a little concerned that this approach could

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137384 --- Does this handle UI based cluster deployments? Probably there is

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Robert Nettleton
> On June 13, 2016, 4:51 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java, > > line 191 > > > > > > I'm a little concerned that this approach

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137326 --- Thanks for providing this patch. Most of the changes seem

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137133 --- Ship it! Ship It! - Sebastian Toader On June 11, 2016, 8:43

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-11 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review137122 --- Ship it! Ship It! - Sandor Magyari On June 11, 2016, 6:43

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136799 ---

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 9, 2016, 12:54 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 9, 2016, 12:12 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-07 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136446 --- Wouldn't better to fire these events only on component state

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-07 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 7, 2016, 7:47 de) Review request for Ambari, Laszlo Puskas,

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136244 ---

Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-06 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton,