Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-12 Thread Masahiro Tanaka
> On July 12, 2016, 5:02 p.m., Andrew Onischuk wrote: > > Committed the patch. Please close the reviewboard. thann you! - Masahiro --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review141866 --- Committed the patch. Please close the reviewboard. - Andrew

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-06 Thread Andrew Onischuk
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! > > Masahiro Tanaka wrote: > Could you commit it? > > Andrew Onischuk wrote: > Done. Please close the reviewboard now. reverted the patch, apache jira - Andrew

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-06 Thread Andrew Onischuk
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! > > Masahiro Tanaka wrote: > Could you commit it? Done. Please close the reviewboard now. - Andrew --- This is an

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-16 Thread Masahiro Tanaka
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit it? - Masahiro --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137293 --- Ship it! Ship It! - Andrew Onischuk On June 7, 2016, 11:11

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Masahiro Tanaka
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Masahiro Tanaka
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Masahiro Tanaka
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? > >

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Masahiro Tanaka
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > > > > > Can you please explain why did we remove the check for firewalld? Thank you

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137283 --- ambari-common/src/main/python/ambari_commons/firewall.py (line

Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-06 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Florian Barca.