Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-22 Thread Prajwal Rao
> On June 22, 2016, 6:32 a.m., Prajwal Rao wrote: > > Ship It! Datasource changes look good to me. - Prajwal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review139022

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-22 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review139022 --- Ship it! Ship It! - Prajwal Rao On June 22, 2016, 2:09

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-21 Thread Jungtaek Lim
> On 6 21, 2016, 4:40 오후, Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html, > > line 112 > > > > > > Visually, I think it makes more sense to add this after

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-21 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/ --- (Updated 6 22, 2016, 2:09 오전) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-21 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review138870 ---

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-20 Thread Jungtaek Lim
> On 6 15, 2016, 6:16 오후, Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js, line 40 > > > > > > There seems to be no way to disable Series Aggregation. We need to have > > a

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-20 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/ --- (Updated 6 21, 2016, 3:06 오전) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-20 Thread Jungtaek Lim
> On 6 15, 2016, 6:16 오후, Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js, line 40 > > > > > > There seems to be no way to disable Series Aggregation. We need to have > > a

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-15 Thread Jungtaek Lim
> On 6 15, 2016, 6:16 오후, Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js, line 40 > > > > > > There seems to be no way to disable Series Aggregation. We need to have > > a

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-15 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review137790 ---

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-14 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review137656 --- Ship it! Backend changes look ok. I would recommend a 'Ship

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-12 Thread Jungtaek Lim
> On 6 10, 2016, 11:56 오후, Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java, > > line 257 > >

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-12 Thread Jungtaek Lim
> On 6 10, 2016, 11:56 오후, Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java, > > line 73 > >

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-10 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review137086 ---

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Jungtaek Lim
> On 6 9, 2016, 5:42 오후, Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks > > Jungtaek Lim wrote: > Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. > > Aravindan Vijayan wrote: > dsen I just found it. His name is registered as 'Dmytro Sen' so

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
> On June 9, 2016, 5:42 p.m., Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks > > Jungtaek Lim wrote: > Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. dsen - Aravindan --- This is an

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Jungtaek Lim
> On 6 9, 2016, 5:42 오후, Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. - Jungtaek --- This is an automatically generated e-mail. To reply,

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review136855 --- Please add Dmitry Sen as well. Thanks - Aravindan Vijayan On

Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-08 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/ --- Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid