Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/ --- (Updated June 21, 2016, 4:03 p.m.) Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and Sebastian Toader. Changes --- Update as trunk has changed Bugs: AMBARI-17117 https://issues.apache.org/jira/browse/AMBARI-17117 Repository: ambari Description --- Variables/properties holding zookeeper connect strings are misnamed as zk_host, or zk_hosts, which may be misleading. Variable / property names fixed. Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java 4240b86 ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java c945ed7 ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java 31fbded ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 b6301ca ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties b4655cc ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2 a485600 ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java 3014ed8 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java 03ff0ff ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 14125bc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java 4564752 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java edf1dcc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java 21c010f ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2 0a94186 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java ad5d789 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 32a1821 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java 50204c4 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java f814678 ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java c382c14 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 31c252a ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 0bbba0f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 b31f39b ambari-server/src/test/python/stacks/2.4/configs/default.json ff548e0 Diff: https://reviews.apache.org/r/48413/diff/ Testing --- Tested on local cluster ambari-logsearch-logfeeder: Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 Thanks, Miklos Gergely
Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/ --- (Updated June 21, 2016, 2:19 p.m.) Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and Sebastian Toader. Changes --- Include the changes since so the patch is up-to-date. Bugs: AMBARI-17117 https://issues.apache.org/jira/browse/AMBARI-17117 Repository: ambari Description --- Variables/properties holding zookeeper connect strings are misnamed as zk_host, or zk_hosts, which may be misleading. Variable / property names fixed. Diffs (updated) - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java f2d074a ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java a7202e7 ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java 29feef7 ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 b6301ca ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 6cba826 ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2 a485600 ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java afbccca ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java 03ff0ff ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 14125bc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java 4564752 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java edf1dcc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java 21c010f ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2 0a94186 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java ad5d789 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 32a1821 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java 50204c4 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java f814678 ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java c382c14 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 9887e76 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 0bbba0f ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 b31f39b ambari-server/src/test/python/stacks/2.4/configs/default.json ff548e0 Diff: https://reviews.apache.org/r/48413/diff/ Testing --- Tested on local cluster ambari-logsearch-logfeeder: Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 Thanks, Miklos Gergely
Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/#review137708 --- Ship it! Ship It! - Daniel Gergely On jún. 15, 2016, 9:24 de, Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48413/ > --- > > (Updated jún. 15, 2016, 9:24 de) > > > Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17117 > https://issues.apache.org/jira/browse/AMBARI-17117 > > > Repository: ambari > > > Description > --- > > Variables/properties holding zookeeper connect strings are misnamed as > zk_host, or zk_hosts, which may be misleading. Variable / property names > fixed. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java > 1f86dd0 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 6fb0b0e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java > 200a603 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 > b6301ca > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2 > a485600 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > afbccca > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java > 03ff0ff > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java > 14125bc > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 147e148 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java > edf1dcc > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java > 21c010f > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2 > 0a94186 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java > f814678 > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java > c382c14 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > 9ada5bf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 > b31f39b > ambari-server/src/test/python/stacks/2.4/configs/default.json c3aecff > > Diff: https://reviews.apache.org/r/48413/diff/ > > > Testing > --- > > Tested on local cluster > > ambari-logsearch-logfeeder: > Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/#review137705 --- Ship it! The patch looks good to me. Also I think it worth making property names string costants in the java code. - Sebastian Toader On June 15, 2016, 11:24 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48413/ > --- > > (Updated June 15, 2016, 11:24 a.m.) > > > Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17117 > https://issues.apache.org/jira/browse/AMBARI-17117 > > > Repository: ambari > > > Description > --- > > Variables/properties holding zookeeper connect strings are misnamed as > zk_host, or zk_hosts, which may be misleading. Variable / property names > fixed. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java > 1f86dd0 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 6fb0b0e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java > 200a603 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 > b6301ca > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2 > a485600 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > afbccca > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java > 03ff0ff > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java > 14125bc > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 147e148 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java > edf1dcc > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java > 21c010f > > ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2 > 0a94186 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java > a2da737 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > 2805b0b > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java > 0813221 > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java > f814678 > > ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java > c382c14 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 > 9ada5bf > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 > b31f39b > ambari-server/src/test/python/stacks/2.4/configs/default.json c3aecff > > Diff: https://reviews.apache.org/r/48413/diff/ > > > Testing > --- > > Tested on local cluster > > ambari-logsearch-logfeeder: > Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/ --- (Updated June 9, 2016, 11:04 p.m.) Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Summary (updated) - Fix misnamed Zookeeper connect strings in Log Search Bugs: AMBARI-17117 https://issues.apache.org/jira/browse/AMBARI-17117 Repository: ambari Description --- Variables/properties holding zookeeper connect strings are misnamed as zk_host, or zk_hosts, which may be misleading. Variable / property names fixed. Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java 1f86dd0 ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java 6fb0b0e ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java 200a603 ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 b6301ca ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 076c09c ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2 a485600 ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java afbccca ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java 03ff0ff ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java 14125bc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java 147e148 ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java edf1dcc ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java 21c010f ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2 0a94186 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java a2da737 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java 2805b0b ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java 0813221 ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java f814678 ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java c382c14 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 6a52708 ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2 9ada5bf ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 b31f39b ambari-server/src/test/python/stacks/2.4/configs/default.json c3aecff Diff: https://reviews.apache.org/r/48413/diff/ Testing --- Tested on local cluster ambari-logsearch-logfeeder: Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 Thanks, Miklos Gergely
