subject:"Review Request 48487\: Capacity Scheduler View \- Node label to queue mapping implementation"

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-07-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review140616
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  24f6938 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.
> 
> Sreenath Somarajapuram wrote:
> Well, as-per your patch there are only 1252 line in application.less!
> 
> Akhil PB wrote:
> line:1239 has css for versionPanel, but not complete. This would not 
> break old UI since there is seperate css at line:216.

class "versions-table-wrap" is not used as of now.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.
> 
> Sreenath Somarajapuram wrote:
> Well, as-per your patch there are only 1252 line in application.less!

line:1239 has css for versionPanel, but not complete. This would not break old 
UI since there is seperate css at line:216.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Sreenath Somarajapuram



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?
> 
> Akhil PB wrote:
> queues.hbs has id="versions-table-wrap" and css also (line:217 in 
> application.less).
> versionPanel.hbs has class="versions-table-wrap" and css are defined at 
> line:1259.
> So the new changes would not break old code.

Well, as-per your patch there are only 1252 line in application.less!


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-29 Thread Akhil PB



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.
> 
> Sreenath Somarajapuram wrote:
> "versions-table-wrap is used for styling and styles are defined in 
> application.less" > Can you share the line number in application.less?

queues.hbs has id="versions-table-wrap" and css also (line:217 in 
application.less).
versionPanel.hbs has class="versions-table-wrap" and css are defined at 
line:1259.
So the new changes would not break old code.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 27, 2016, 5:36 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 27, 2016, 5:36 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-26 Thread Akhil PB


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/
---

(Updated June 27, 2016, 5:36 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Changes
---

Patch updated with review comments.


Bugs: AMBARI-17137
https://issues.apache.org/jira/browse/AMBARI-17137


Repository: ambari


Description
---

Capacity Scheduler View - Node label to queue mappings and save integration for 
all tabs


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
7f7bc3b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 bbf0cab 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 113ad13 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 7af45bb 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 1ee7a6b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 518b677 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 93f6645 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 c0c56b6 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
3dfe363 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
45146ef 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a32e02c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
7fef4be 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 9952045 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
17b279a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 1eead4b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 e54e14b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 55910ee 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 ee9616b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b81474e 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 aad16c2 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 f11b786 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 24f6938 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 759c0f3 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/saveConfigDialog.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 f252005 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 b2ae1d5 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
0dde62b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
5cef8e5 

Diff:

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-24 Thread Akhil PB



> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js,
> >  line 45
> > 
> >
> > Where is isNotOperator used?

I guess its not used, just defined thinking that it might be useful in future.


> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js, line 
> > 290
> > 
> >
> > Where is the values of store passed?

Intended to pass store to getNodeLabels api in adapter. But it is not used 
inside this api. I guess i can remove it.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139046
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-24 Thread Akhil PB



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js,
> >  line 25
> > 
> >
> > Trailing space must be removed.

Will remove the spaces.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139051
---



- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  24f6938 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  759c0f3

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?
> 
> Akhil PB wrote:
> versionPanel.hbs itself is a new file and class "versions-table-wrap" is 
> used for styling and styles are defined in application.less.
> views/queues.js would not break since queues.js uses above as id and 
> versionPanel uses as class name.

"versions-table-wrap is used for styling and styles are defined in 
application.less" > Can you share the line number in application.less?


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139046
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 43)


Where is isNotOperator used?



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)


Where is the values of store passed?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB



> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs,
> >  line 26
> > 
> >
> > Where is the versions-table-wrap class defined?
> > Wouldnt it cause the views/queues.js code to break?

versionPanel.hbs itself is a new file and class "versions-table-wrap" is used 
for styling and styles are defined in application.less.
views/queues.js would not break since queues.js uses above as id and 
versionPanel uses as class name.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139036
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 (line 25)


Trailing space must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js (line 290)


Technically, store must be a generic implementation without any 
entity/model specific code.
But as this is existing code, guess there is no other alternative.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 26)


Where is the versions-table-wrap class defined?
Wouldnt it cause the views/queues.js code to break?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram



> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?
> 
> Akhil PB wrote:
> Converting string number to integer number.
> 
> Akhil PB wrote:
> + is for properties[cp]. ie +properties[cp]

Would have been better to use parseFloat. But as it is from an old code, lets 
leave it for the time being.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB



> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?
> 
> Akhil PB wrote:
> Converting string number to integer number.

+ is for properties[cp]. ie +properties[cp]


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Akhil PB



> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, 
> > line 164
> > 
> >
> > Why are we having the + after ?

Converting string number to integer number.


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-22 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/#review139032
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js (line 
164)


Why are we having the + after ?


- Sreenath Somarajapuram


On June 9, 2016, 12:05 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48487/
> ---
> 
> (Updated June 9, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-17137
> https://issues.apache.org/jira/browse/AMBARI-17137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler View - Node label to queue mappings and save integration 
> for all tabs
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 7f7bc3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  bbf0cab 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  113ad13 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  7af45bb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  1ee7a6b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  518b677 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  93f6645 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  c0c56b6 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 3dfe363 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 45146ef 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a32e02c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
> 7fef4be 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  9952045 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 17b279a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  1eead4b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  e54e14b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  55910ee 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  ee9616b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  b81474e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  aad16c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  f11b786 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
>  PRE-CREATION 
>   
>

Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-09 Thread Akhil PB


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48487/
---

Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath 
Somarajapuram.


Bugs: AMBARI-17137
https://issues.apache.org/jira/browse/AMBARI-17137


Repository: ambari


Description
---

Capacity Scheduler View - Node label to queue mappings and save integration for 
all tabs


Diffs
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
7f7bc3b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 bbf0cab 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 113ad13 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 7af45bb 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 1ee7a6b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 518b677 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 93f6645 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 c0c56b6 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
3dfe363 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
45146ef 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a32e02c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 
7fef4be 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 9952045 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
17b279a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 1eead4b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 e54e14b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 55910ee 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 ee9616b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 b81474e 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 aad16c2 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 f11b786 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 24f6938 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 759c0f3 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/saveConfigDialog.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 f252005 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 b2ae1d5 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
0dde62b 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
5cef8e5 

Diff: https://reviews.apache.org/r/48487/diff/


Testing
---

Manual Unit Testing


Thanks,

Akhil PB

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

18 matches

Site Navigation

Mail list logo

Footer information