Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48498/#review136870
---


Ship it!




Ship It!

- Jonathan Hurley


On June 9, 2016, 12:49 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48498/
> ---
> 
> (Updated June 9, 2016, 12:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17130
> https://issues.apache.org/jira/browse/AMBARI-17130
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI needs to be able to specify a display_name when creating a Version 
> Definition.  This is to avoid a name collision when installing default stack 
> repos.
> 
> In addition, add a validation object to the dry_run endpoint to catch errors 
> without POSTing "for real"
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py 79181f1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  049c4a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  75427ff 
> 
> Diff: https://reviews.apache.org/r/48498/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.  Automated (failure not related to patch):
> 
> Failed tests:
>   ViewPrivilegeEventCreatorTest.putTest:85 expected:<...missions(
> Permission[1:
>   Users: testuser
>   Groups: testgroup
> Permission2:
>   Users: testuser2])> but was:<...missions(
> Permission[2:
>   Users: testuser2
> Permission1:
>   Users: testuser
>   Groups: testgroup])>
> 
> Tests run: 4462, Failures: 1, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 42:33.638s
> [INFO] Finished at: Thu Jun 09 12:40:14 EDT 2016
> [INFO] Final Memory: 33M/689M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48498/#review136835
---




ambari-agent/src/main/python/ambari_agent/NetUtil.py (line 64)


This was an annoyance as I tried to run an agent that was upgraded after I 
changed ambari.ini.


- Nate Cole


On June 9, 2016, 12:49 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48498/
> ---
> 
> (Updated June 9, 2016, 12:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17130
> https://issues.apache.org/jira/browse/AMBARI-17130
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI needs to be able to specify a display_name when creating a Version 
> Definition.  This is to avoid a name collision when installing default stack 
> repos.
> 
> In addition, add a validation object to the dry_run endpoint to catch errors 
> without POSTing "for real"
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py 79181f1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  049c4a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  75427ff 
> 
> Diff: https://reviews.apache.org/r/48498/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.  Automated (failure not related to patch):
> 
> Failed tests:
>   ViewPrivilegeEventCreatorTest.putTest:85 expected:<...missions(
> Permission[1:
>   Users: testuser
>   Groups: testgroup
> Permission2:
>   Users: testuser2])> but was:<...missions(
> Permission[2:
>   Users: testuser2
> Permission1:
>   Users: testuser
>   Groups: testgroup])>
> 
> Tests run: 4462, Failures: 1, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 42:33.638s
> [INFO] Finished at: Thu Jun 09 12:40:14 EDT 2016
> [INFO] Final Memory: 33M/689M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48498/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17130
https://issues.apache.org/jira/browse/AMBARI-17130


Repository: ambari


Description
---

UI needs to be able to specify a display_name when creating a Version 
Definition.  This is to avoid a name collision when installing default stack 
repos.

In addition, add a validation object to the dry_run endpoint to catch errors 
without POSTing "for real"


Diffs
-

  ambari-agent/src/main/python/ambari_agent/NetUtil.py 79181f1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 049c4a7 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
 75427ff 

Diff: https://reviews.apache.org/r/48498/diff/


Testing
---

Manual testing.  Automated (failure not related to patch):

Failed tests:
  ViewPrivilegeEventCreatorTest.putTest:85 expected:<...missions(
Permission[1:
  Users: testuser
  Groups: testgroup
Permission2:
  Users: testuser2])> but was:<...missions(
Permission[2:
  Users: testuser2
Permission1:
  Users: testuser
  Groups: testgroup])>

Tests run: 4462, Failures: 1, Errors: 0, Skipped: 34

[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 42:33.638s
[INFO] Finished at: Thu Jun 09 12:40:14 EDT 2016
[INFO] Final Memory: 33M/689M
[INFO] 


Thanks,

Nate Cole