Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

[Jayush Luniya]

> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
> Thank you! Could you commit this ?

Committed, thanks for your contribution. Can you close the review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48523/#review137073
---


On June 9, 2016, 11:49 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48523/
> ---
> 
> (Updated June 9, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav 
> Kulshreshtha, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17145
> https://issues.apache.org/jira/browse/AMBARI-17145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we just installed Zeppelin Notebook, /etc/zeppelin/conf/zeppelin-env.sh 
> is like this
> 
> ```
> # Spark master url. eg. spark://master_addr:7077. Leave empty if you want to 
> use local mode
> export MASTER=yarn-client
> export SPARK_YARN_JAR={spark_jar_dir}/zeppelin-spark-0.5.5-SNAPSHOT.jar
> 
> (snip)
> ```
> 
> It maybe 
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  doesn't import from resource_management.libraries.functions.format import 
> format
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  a4efd72 
> 
> Diff: https://reviews.apache.org/r/48523/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test && manual test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

[Masahiro Tanaka]

> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote:
> > Ship It!

Thank you! Could you commit this ?


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48523/#review137073
---


On June 9, 2016, 11:49 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48523/
> ---
> 
> (Updated June 9, 2016, 11:49 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav 
> Kulshreshtha, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17145
> https://issues.apache.org/jira/browse/AMBARI-17145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When we just installed Zeppelin Notebook, /etc/zeppelin/conf/zeppelin-env.sh 
> is like this
> 
> ```
> # Spark master url. eg. spark://master_addr:7077. Leave empty if you want to 
> use local mode
> export MASTER=yarn-client
> export SPARK_YARN_JAR={spark_jar_dir}/zeppelin-spark-0.5.5-SNAPSHOT.jar
> 
> (snip)
> ```
> 
> It maybe 
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  doesn't import from resource_management.libraries.functions.format import 
> format
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  a4efd72 
> 
> Diff: https://reviews.apache.org/r/48523/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test && manual test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48523/
---

Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav Kulshreshtha, 
and Sumit Mohanty.


Bugs: AMBARI-17145
https://issues.apache.org/jira/browse/AMBARI-17145


Repository: ambari


Description
---

When we just installed Zeppelin Notebook, /etc/zeppelin/conf/zeppelin-env.sh is 
like this

```
# Spark master url. eg. spark://master_addr:7077. Leave empty if you want to 
use local mode
export MASTER=yarn-client
export SPARK_YARN_JAR={spark_jar_dir}/zeppelin-spark-0.5.5-SNAPSHOT.jar

(snip)
```

It maybe 
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 doesn't import from resource_management.libraries.functions.format import 
format


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 a4efd72 

Diff: https://reviews.apache.org/r/48523/diff/


Testing
---

mvn clean test && manual test


Thanks,

Masahiro Tanaka