Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez 


> On June 10, 2016, 8:07 p.m., Sowmya Ramesh wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 147
> > 
> >
> > I think path before was "/apps/data-mirroring/" and not 
> > "/apps/falcon/data-mirroring/" ?

My mistake, code was correct but comment was not.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/#review137067
---


On June 10, 2016, 9 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48561/
> ---
> 
> (Updated June 10, 2016, 9 p.m.)
> 
> 
> Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17171
> https://issues.apache.org/jira/browse/AMBARI-17171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Falcon extensions is supported, Ambari still needs to create the 
> /apps/data-mirroring directory in HDFS.
> Also, RU/EU does not need to explicitly create the extensions directory in 
> the pre_upgrade_restart function since the start function will create it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  0d2cd8e 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  41954a5 
> 
> Diff: https://reviews.apache.org/r/48561/diff/
> 
> 
> Testing
> ---
> 
> Ran python unit tests,
> 
> Total run:1055
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/
---

(Updated June 10, 2016, 9 p.m.)


Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
Luniya, Nate Cole, and Tim Thorpe.


Bugs: AMBARI-17171
https://issues.apache.org/jira/browse/AMBARI-17171


Repository: ambari


Description (updated)
---

If Falcon extensions is supported, Ambari still needs to create the 
/apps/data-mirroring directory in HDFS.
Also, RU/EU does not need to explicitly create the extensions directory in the 
pre_upgrade_restart function since the start function will create it.


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 b5b3a34 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 0d2cd8e 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 41954a5 

Diff: https://reviews.apache.org/r/48561/diff/


Testing
---

Ran python unit tests,

Total run:1055
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Sowmya Ramesh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/#review137067
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (line 147)


I think path before was "/apps/data-mirroring/" and not 
"/apps/falcon/data-mirroring/" ?


- Sowmya Ramesh


On June 10, 2016, 6:13 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48561/
> ---
> 
> (Updated June 10, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17171
> https://issues.apache.org/jira/browse/AMBARI-17171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Falcon extensions is supported, Ambari still needs to create the 
> /apps/falcon/data-mirroring directory in HDFS.
> Also, RU/EU does not need to explicitly create the extensions directory in 
> the pre_upgrade_restart function since the start function will create it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  0d2cd8e 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  41954a5 
> 
> Diff: https://reviews.apache.org/r/48561/diff/
> 
> 
> Testing
> ---
> 
> Ran python unit tests,
> 
> Total run:1055
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/#review137066
---


Ship it!




Ship It!

- Tim Thorpe


On June 10, 2016, 6:13 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48561/
> ---
> 
> (Updated June 10, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17171
> https://issues.apache.org/jira/browse/AMBARI-17171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Falcon extensions is supported, Ambari still needs to create the 
> /apps/falcon/data-mirroring directory in HDFS.
> Also, RU/EU does not need to explicitly create the extensions directory in 
> the pre_upgrade_restart function since the start function will create it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  0d2cd8e 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  41954a5 
> 
> Diff: https://reviews.apache.org/r/48561/diff/
> 
> 
> Testing
> ---
> 
> Ran python unit tests,
> 
> Total run:1055
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/#review137059
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (lines 146 - 149)


Instead of executing this under "supports_falcon_extensions" should it be 
under an 

`if not params.supports_data_mirroring:`


- Jonathan Hurley


On June 10, 2016, 2:13 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48561/
> ---
> 
> (Updated June 10, 2016, 2:13 p.m.)
> 
> 
> Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
> Luniya, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17171
> https://issues.apache.org/jira/browse/AMBARI-17171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Falcon extensions is supported, Ambari still needs to create the 
> /apps/falcon/data-mirroring directory in HDFS.
> Also, RU/EU does not need to explicitly create the extensions directory in 
> the pre_upgrade_restart function since the start function will create it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  0d2cd8e 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  41954a5 
> 
> Diff: https://reviews.apache.org/r/48561/diff/
> 
> 
> Testing
> ---
> 
> Ran python unit tests,
> 
> Total run:1055
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 48561: Falcon to create data-mirroring directory in HDFS if extensions is supported

2016-06-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/
---

Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush 
Luniya, Nate Cole, and Tim Thorpe.


Bugs: AMBARI-17171
https://issues.apache.org/jira/browse/AMBARI-17171


Repository: ambari


Description
---

If Falcon extensions is supported, Ambari still needs to create the 
/apps/falcon/data-mirroring directory in HDFS.
Also, RU/EU does not need to explicitly create the extensions directory in the 
pre_upgrade_restart function since the start function will create it.


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 b5b3a34 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 0d2cd8e 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 41954a5 

Diff: https://reviews.apache.org/r/48561/diff/


Testing
---

Ran python unit tests,

Total run:1055
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez