Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137710 --- Ship it! Ship It! - Sebastian Toader On June 15, 2016, 1:41 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48642/ > --- > > (Updated June 15, 2016, 1:41 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-17196 > https://issues.apache.org/jira/browse/AMBARI-17196 > > > Repository: ambari > > > Description > --- > > When creating a cluster with kerberos, ambari-server.out contains > NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not > belong to logical tasks. > NPE source is a Long->long conversion when logical task id is null when > AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. > > The fix is a NPE check that skips the registerPhysicalTaskId method. I added > it also to the StartHostsTask class. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 00ecb98 > > Diff: https://reviews.apache.org/r/48642/diff/ > > > Testing > --- > > Changes are done in private classes, so they cannot be accessed from unit > tests. > > > Thanks, > > Daniel Gergely > >
Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/ --- (Updated jún. 15, 2016, 11:41 de) Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Comment and log message fix Bugs: AMBARI-17196 https://issues.apache.org/jira/browse/AMBARI-17196 Repository: ambari Description --- When creating a cluster with kerberos, ambari-server.out contains NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not belong to logical tasks. NPE source is a Long->long conversion when logical task id is null when AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. The fix is a NPE check that skips the registerPhysicalTaskId method. I added it also to the StartHostsTask class. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 00ecb98 Diff: https://reviews.apache.org/r/48642/diff/ Testing --- Changes are done in private classes, so they cannot be accessed from unit tests. Thanks, Daniel Gergely
Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/ --- (Updated jún. 15, 2016, 8:50 de) Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Changes --- Adding comments and skipping log mesage in case of AMBARI_SERVER_ACTION Bugs: AMBARI-17196 https://issues.apache.org/jira/browse/AMBARI-17196 Repository: ambari Description --- When creating a cluster with kerberos, ambari-server.out contains NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not belong to logical tasks. NPE source is a Long->long conversion when logical task id is null when AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. The fix is a NPE check that skips the registerPhysicalTaskId method. I added it also to the StartHostsTask class. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 00ecb98 Diff: https://reviews.apache.org/r/48642/diff/ Testing --- Changes are done in private classes, so they cannot be accessed from unit tests. Thanks, Daniel Gergely
Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137312 --- Ship it! Ship It! - Robert Levas On June 13, 2016, 11:04 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48642/ > --- > > (Updated June 13, 2016, 11:04 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-17196 > https://issues.apache.org/jira/browse/AMBARI-17196 > > > Repository: ambari > > > Description > --- > > When creating a cluster with kerberos, ambari-server.out contains > NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not > belong to logical tasks. > NPE source is a Long->long conversion when logical task id is null when > AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. > > The fix is a NPE check that skips the registerPhysicalTaskId method. I added > it also to the StartHostsTask class. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 00ecb98 > > Diff: https://reviews.apache.org/r/48642/diff/ > > > Testing > --- > > Changes are done in private classes, so they cannot be accessed from unit > tests. > > > Thanks, > > Daniel Gergely > >
Re: Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/#review137308 --- Ship it! Ship It! - Oliver Szabo On June 13, 2016, 3:04 p.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48642/ > --- > > (Updated June 13, 2016, 3:04 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-17196 > https://issues.apache.org/jira/browse/AMBARI-17196 > > > Repository: ambari > > > Description > --- > > When creating a cluster with kerberos, ambari-server.out contains > NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not > belong to logical tasks. > NPE source is a Long->long conversion when logical task id is null when > AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. > > The fix is a NPE check that skips the registerPhysicalTaskId method. I added > it also to the StartHostsTask class. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 00ecb98 > > Diff: https://reviews.apache.org/r/48642/diff/ > > > Testing > --- > > Changes are done in private classes, so they cannot be accessed from unit > tests. > > > Thanks, > > Daniel Gergely > >
Review Request 48642: NPE in ambari-server.out when cluster with kerberos is installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48642/ --- Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-17196 https://issues.apache.org/jira/browse/AMBARI-17196 Repository: ambari Description --- When creating a cluster with kerberos, ambari-server.out contains NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not belong to logical tasks. NPE source is a Long->long conversion when logical task id is null when AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap. The fix is a NPE check that skips the registerPhysicalTaskId method. I added it also to the StartHostsTask class. Diffs - ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 00ecb98 Diff: https://reviews.apache.org/r/48642/diff/ Testing --- Changes are done in private classes, so they cannot be accessed from unit tests. Thanks, Daniel Gergely
