Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137721 --- Ship it! Ship It! - Di Li On June 14, 2016, 11:12 p.m.,

Re: Review Request 48702: Add ability to set GET request directives

2016-06-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137720 --- Ship it! Ship It! - Nate Cole On June 14, 2016, 7:12 p.m.,

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137621 --- Ship it! Ship It! - Alejandro Fernandez On June 14, 2016,

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/ --- (Updated June 14, 2016, 7:12 p.m.) Review request for Ambari, Ajit Kumar, Di

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Nate Cole
> On June 14, 2016, 3:24 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java, > > line 69 > > > > > > createReadRequest() ? > > Robert Levas wrote: >

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
> On June 14, 2016, 3:24 p.m., Nate Cole wrote: > > Can you give an example of a read directive? This is for a future enhancement I need to make. With the addition of the `when` clause for a Kerberos descriptor identity, we are able to optionally include Kerberos identities depending on what

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
> On June 14, 2016, 3:24 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java, > > line 69 > > > > > > createReadRequest() ? This is consistent with

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/#review137568 --- Can you give an example of a read directive?

Re: Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/ --- (Updated June 14, 2016, 2:57 p.m.) Review request for Ambari, Ajit Kumar, Di

Review Request 48702: Add ability to set GET request directives

2016-06-14 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48702/ --- Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.