Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/ --- (Updated June 15, 2016, 7:15 p.m.) Review request for Ambari, Robert Nettleton, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-17251 https://issues.apache.org/jira/browse/AMBARI-17251 Repository: ambari Description --- Problem: Component dependencies from stack definitions are automatically added to blueprint deployments even the services components belong to are not listed in the blueprint. eg.: SPARK_CLIENT/TEZ_CLIENT components that are listed as dependencies of the ATS and RESOURCEMANAGER in the stack definitions are always added to blueprints. Solution: Component dependencies defined in stack definitions are only added to blueprints if services belonging to the listed components are part of the blueprint Diffs - ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 432c6f8 ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java f78d86d Diff: https://reviews.apache.org/r/48732/diff/ Testing (updated) --- Unit tests succeeded Manually tested on local env. Thanks, Laszlo Puskas
Re: Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/#review137745 --- Ship it! - Robert Nettleton On June 15, 2016, 3:04 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48732/ > --- > > (Updated June 15, 2016, 3:04 p.m.) > > > Review request for Ambari, Robert Nettleton, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-17251 > https://issues.apache.org/jira/browse/AMBARI-17251 > > > Repository: ambari > > > Description > --- > > Problem: > Component dependencies from stack definitions are automatically added to > blueprint deployments even the services components belong to are not listed > in the blueprint. > eg.: SPARK_CLIENT/TEZ_CLIENT components that are listed as dependencies of > the ATS and RESOURCEMANAGER in the stack definitions are always added to > blueprints. > > Solution: > Component dependencies defined in stack definitions are only added to > blueprints if services belonging to the listed components are part of the > blueprint > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 432c6f8 > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > f78d86d > > Diff: https://reviews.apache.org/r/48732/diff/ > > > Testing > --- > > Unit tests running; > Manually tested on local env. > > > Thanks, > > Laszlo Puskas > >
Review Request 48732: (Client) components that are dependencies of services in the stack definitions are always added to blueprint deployments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48732/ --- Review request for Ambari, Robert Nettleton, Sandor Magyari, and Sebastian Toader. Bugs: AMBARI-17251 https://issues.apache.org/jira/browse/AMBARI-17251 Repository: ambari Description --- Problem: Component dependencies from stack definitions are automatically added to blueprint deployments even the services components belong to are not listed in the blueprint. eg.: SPARK_CLIENT/TEZ_CLIENT components that are listed as dependencies of the ATS and RESOURCEMANAGER in the stack definitions are always added to blueprints. Solution: Component dependencies defined in stack definitions are only added to blueprints if services belonging to the listed components are part of the blueprint Diffs - ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 432c6f8 ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java f78d86d Diff: https://reviews.apache.org/r/48732/diff/ Testing --- Unit tests running; Manually tested on local env. Thanks, Laszlo Puskas
