Re: Review Request 48739: Remove CascadeType in ServiceComponentHistoryEntity for ServiceComponentDesiredStateEntity

2016-06-15 Thread Nahappan Somasundaram

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48739/#review137903
---


Ship it!




Ship It!

- Nahappan Somasundaram


On June 15, 2016, 2:19 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48739/
> ---
> 
> (Updated June 15, 2016, 2:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Gupta.
> 
> 
> Bugs: AMBARI-17260
> https://issues.apache.org/jira/browse/AMBARI-17260
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove CascadeType in ServiceComponentHistoryEntity for 
> ServiceComponentDesiredStateEntity
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java
>  e7fef71 
> 
> Diff: https://reviews.apache.org/r/48739/diff/
> 
> 
> Testing
> ---
> 
> Tested manually by deleting service
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>



Re: Review Request 48739: Remove CascadeType in ServiceComponentHistoryEntity for ServiceComponentDesiredStateEntity

2016-06-15 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48739/#review137891
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java
 (line 40)


This is a new table, should we make it consistent, 
service_component_history?


- Alejandro Fernandez


On June 15, 2016, 9:19 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48739/
> ---
> 
> (Updated June 15, 2016, 9:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Gupta.
> 
> 
> Bugs: AMBARI-17260
> https://issues.apache.org/jira/browse/AMBARI-17260
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove CascadeType in ServiceComponentHistoryEntity for 
> ServiceComponentDesiredStateEntity
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentHistoryEntity.java
>  e7fef71 
> 
> Diff: https://reviews.apache.org/r/48739/diff/
> 
> 
> Testing
> ---
> 
> Tested manually by deleting service
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>