Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread Tom Beerbower


> On June 16, 2016, 6:11 p.m., John Speidel wrote:
> > Curious, how does the Hive hook work now that the Atlas config isn't in 
> > it's classpath?

Ambari now writes the atlas configuration file into the Hive conf folder.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48743/#review138038
---


On June 15, 2016, 6:13 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48743/
> ---
> 
> (Updated June 15, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-17262
> https://issues.apache.org/jira/browse/AMBARI-17262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Hive configuration ‘Advanced hive-env’ :
> 
> 
> export 
> HADOOP_CLASSPATH={{atlas_conf_dir}}:{{atlas_home_dir}}/hook/hive:${HADOOP_CLASSPATH}
> 
> 
> remove 
> 
> 
> {{atlas_conf_dir}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  0c9aeaf 
> 
> Diff: https://reviews.apache.org/r/48743/diff/
> 
> 
> Testing
> ---
> 
> Manual test.  Verify configuration.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread Tom Beerbower


> On June 16, 2016, 6:11 p.m., John Speidel wrote:
> > Curious, how does the Hive hook work now that the Atlas config isn't in 
> > it's classpath?
> 
> Tom Beerbower wrote:
> Ambari now writes the atlas configuration file into the Hive conf folder.

Thanks for the review.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48743/#review138038
---


On June 15, 2016, 6:13 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48743/
> ---
> 
> (Updated June 15, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-17262
> https://issues.apache.org/jira/browse/AMBARI-17262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Hive configuration ‘Advanced hive-env’ :
> 
> 
> export 
> HADOOP_CLASSPATH={{atlas_conf_dir}}:{{atlas_home_dir}}/hook/hive:${HADOOP_CLASSPATH}
> 
> 
> remove 
> 
> 
> {{atlas_conf_dir}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  0c9aeaf 
> 
> Diff: https://reviews.apache.org/r/48743/diff/
> 
> 
> Testing
> ---
> 
> Manual test.  Verify configuration.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Re: Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-16 Thread John Speidel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48743/#review138038
---


Ship it!




Curious, how does the Hive hook work now that the Atlas config isn't in it's 
classpath?

- John Speidel


On June 15, 2016, 6:13 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48743/
> ---
> 
> (Updated June 15, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-17262
> https://issues.apache.org/jira/browse/AMBARI-17262
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Hive configuration ‘Advanced hive-env’ :
> 
> 
> export 
> HADOOP_CLASSPATH={{atlas_conf_dir}}:{{atlas_home_dir}}/hook/hive:${HADOOP_CLASSPATH}
> 
> 
> remove 
> 
> 
> {{atlas_conf_dir}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
>  0c9aeaf 
> 
> Diff: https://reviews.apache.org/r/48743/diff/
> 
> 
> Testing
> ---
> 
> Manual test.  Verify configuration.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>



Review Request 48743: Remove {{atlas_conf_dir}} from HADOOP_CLASSPATH in hive-env.

2016-06-15 Thread Tom Beerbower

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48743/
---

Review request for Ambari and John Speidel.


Bugs: AMBARI-17262
https://issues.apache.org/jira/browse/AMBARI-17262


Repository: ambari


Description
---

In Hive configuration ‘Advanced hive-env’ :


export 
HADOOP_CLASSPATH={{atlas_conf_dir}}:{{atlas_home_dir}}/hook/hive:${HADOOP_CLASSPATH}


remove 


{{atlas_conf_dir}}


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml
 0c9aeaf 

Diff: https://reviews.apache.org/r/48743/diff/


Testing
---

Manual test.  Verify configuration.

mvn clean test


Thanks,

Tom Beerbower