Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48750/
---

(Updated June 15, 2016, 8:59 p.m.)


Review request for Ambari, Ajit Kumar, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17150
https://issues.apache.org/jira/browse/AMBARI-17150


Repository: ambari


Description
---

In December 2015 changes were made such that Ambari metrics project's parent is 
Ambari. This change was done to make sure the surefire plugin library is 
inherited. 

However, AMS pom.xml did not have any Vendor (organization) information, and 
hence it inherited from Ambari project ('Apache Software Foundation'). Hence, 
the released AMS packages have no Vendor and the new ones will have it thus 
causing upgrade command to fail 

suse1101:~ # zypper up ambari-metrics-hadoop-sink
Loading repository data...
Reading installed packages...
There is an update candidate for 'ambari-metrics-hadoop-sink', but it is from 
different vendor. Use 'zypper install 
ambari-metrics-hadoop-sink-2.4.0.0-569.x86_64' to install this candidate.
Resolving package dependencies...
Nothing to do.

Fix
Remove the hierarchy and add surefire plugin dependency in Ambari metrics 
project.

Related review board
https://reviews.apache.org/r/41269


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml af37d28 
  ambari-metrics/pom.xml 36d817e 

Diff: https://reviews.apache.org/r/48750/diff/


Testing
---

mvn clean package

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [9.364s]
[INFO] Apache Ambari Project POM . SUCCESS [0.028s]
[INFO] Ambari Web  SUCCESS [24.758s]
[INFO] Ambari Views .. SUCCESS [1.338s]
[INFO] Ambari Admin View . SUCCESS [9.822s]
[INFO] ambari-metrics  SUCCESS [0.586s]
[INFO] Ambari Metrics Common . SUCCESS [1.081s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [0.955s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.453s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.562s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.389s]
[INFO] Ambari Metrics Collector .. SUCCESS [2:17.967s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.207s]
[INFO] Ambari Metrics Grafana  SUCCESS [54.849s]
[INFO] Ambari Metrics Assembly ... SUCCESS [2:22.821s]
[INFO] Ambari Server . SUCCESS [1:31.407s]
[INFO] Ambari Functional Tests ... SUCCESS [1.977s]
[INFO] Ambari Agent .. SUCCESS [23.784s]
[INFO] Ambari Client . SUCCESS [0.032s]
[INFO] Ambari Python Client .. SUCCESS [0.618s]
[INFO] Ambari Groovy Client .. SUCCESS [1.972s]
[INFO] Ambari Shell .. SUCCESS [0.044s]
[INFO] Ambari Python Shell ... SUCCESS [0.463s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.830s]
[INFO] ambari-logsearch .. SUCCESS [0.233s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.316s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.024s]
[INFO] Ambari Logsearch Portal ... SUCCESS [5.953s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.429s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.047s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 8:38.840s
[INFO] Finished at: Wed Jun 15 13:13:20 PDT 2016
[INFO] Final Memory: 206M/1529M
[INFO] 


Thanks,

Aravindan Vijayan



Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Ajit Kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48750/#review137834
---


Ship it!




Please make sure while building metrics, no other version of surefire is being 
linked.


ambari-metrics/ambari-metrics-timelineservice/pom.xml (line 711)


As far as I remember, I had changed pom.version to project.version because 
of a build warning. Can you please check if you are not getting any warning 
because of this revert?


- Ajit Kumar


On June 15, 2016, 8:29 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48750/
> ---
> 
> (Updated June 15, 2016, 8:29 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Dmytro Sen, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17150
> https://issues.apache.org/jira/browse/AMBARI-17150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In December 2015 changes were made such that Ambari metrics project's parent 
> is Ambari. This change was done to make sure the surefire plugin library is 
> inherited. 
> 
> However, AMS pom.xml did not have any Vendor (organization) information, and 
> hence it inherited from Ambari project ('Apache Software Foundation'). Hence, 
> the released AMS packages have no Vendor and the new ones will have it thus 
> causing upgrade command to fail 
> 
> suse1101:~ # zypper up ambari-metrics-hadoop-sink
> Loading repository data...
> Reading installed packages...
> There is an update candidate for 'ambari-metrics-hadoop-sink', but it is from 
> different vendor. Use 'zypper install 
> ambari-metrics-hadoop-sink-2.4.0.0-569.x86_64' to install this candidate.
> Resolving package dependencies...
> Nothing to do.
> 
> Fix
> Remove the hierarchy and add surefire plugin dependency in Ambari metrics 
> project.
> 
> Related review board
> https://reviews.apache.org/r/41269
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml af37d28 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml ed612cc 
>   ambari-metrics/pom.xml 36d817e 
> 
> Diff: https://reviews.apache.org/r/48750/diff/
> 
> 
> Testing
> ---
> 
> mvn clean package
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [9.364s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.028s]
> [INFO] Ambari Web  SUCCESS [24.758s]
> [INFO] Ambari Views .. SUCCESS [1.338s]
> [INFO] Ambari Admin View . SUCCESS [9.822s]
> [INFO] ambari-metrics  SUCCESS [0.586s]
> [INFO] Ambari Metrics Common . SUCCESS [1.081s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [0.955s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.453s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.562s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.389s]
> [INFO] Ambari Metrics Collector .. SUCCESS [2:17.967s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.207s]
> [INFO] Ambari Metrics Grafana  SUCCESS [54.849s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [2:22.821s]
> [INFO] Ambari Server . SUCCESS [1:31.407s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.977s]
> [INFO] Ambari Agent .. SUCCESS [23.784s]
> [INFO] Ambari Client . SUCCESS [0.032s]
> [INFO] Ambari Python Client .. SUCCESS [0.618s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.972s]
> [INFO] Ambari Shell .. SUCCESS [0.044s]
> [INFO] Ambari Python Shell ... SUCCESS [0.463s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.830s]
> [INFO] ambari-logsearch .. SUCCESS [0.233s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.316s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.024s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [5.953s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.429s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.047s]
> [INFO] 
> 

Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears

2016-06-15 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48750/
---

Review request for Ambari, Ajit Kumar, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17150
https://issues.apache.org/jira/browse/AMBARI-17150


Repository: ambari


Description
---

In December 2015 changes were made such that Ambari metrics project's parent is 
Ambari. This change was done to make sure the surefire plugin library is 
inherited. 

However, AMS pom.xml did not have any Vendor (organization) information, and 
hence it inherited from Ambari project ('Apache Software Foundation'). Hence, 
the released AMS packages have no Vendor and the new ones will have it thus 
causing upgrade command to fail 

suse1101:~ # zypper up ambari-metrics-hadoop-sink
Loading repository data...
Reading installed packages...
There is an update candidate for 'ambari-metrics-hadoop-sink', but it is from 
different vendor. Use 'zypper install 
ambari-metrics-hadoop-sink-2.4.0.0-569.x86_64' to install this candidate.
Resolving package dependencies...
Nothing to do.

Fix
Remove the hierarchy and add surefire plugin dependency in Ambari metrics 
project.

Related review board
https://reviews.apache.org/r/41269


Diffs
-

  ambari-metrics/ambari-metrics-common/pom.xml af37d28 
  ambari-metrics/ambari-metrics-timelineservice/pom.xml ed612cc 
  ambari-metrics/pom.xml 36d817e 

Diff: https://reviews.apache.org/r/48750/diff/


Testing
---

mvn clean package

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [9.364s]
[INFO] Apache Ambari Project POM . SUCCESS [0.028s]
[INFO] Ambari Web  SUCCESS [24.758s]
[INFO] Ambari Views .. SUCCESS [1.338s]
[INFO] Ambari Admin View . SUCCESS [9.822s]
[INFO] ambari-metrics  SUCCESS [0.586s]
[INFO] Ambari Metrics Common . SUCCESS [1.081s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [0.955s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.453s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.562s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.389s]
[INFO] Ambari Metrics Collector .. SUCCESS [2:17.967s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.207s]
[INFO] Ambari Metrics Grafana  SUCCESS [54.849s]
[INFO] Ambari Metrics Assembly ... SUCCESS [2:22.821s]
[INFO] Ambari Server . SUCCESS [1:31.407s]
[INFO] Ambari Functional Tests ... SUCCESS [1.977s]
[INFO] Ambari Agent .. SUCCESS [23.784s]
[INFO] Ambari Client . SUCCESS [0.032s]
[INFO] Ambari Python Client .. SUCCESS [0.618s]
[INFO] Ambari Groovy Client .. SUCCESS [1.972s]
[INFO] Ambari Shell .. SUCCESS [0.044s]
[INFO] Ambari Python Shell ... SUCCESS [0.463s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.830s]
[INFO] ambari-logsearch .. SUCCESS [0.233s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.316s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.024s]
[INFO] Ambari Logsearch Portal ... SUCCESS [5.953s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.429s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.047s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 8:38.840s
[INFO] Finished at: Wed Jun 15 13:13:20 PDT 2016
[INFO] Final Memory: 206M/1529M
[INFO] 


Thanks,

Aravindan Vijayan