----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49256/#review139944 -----------------------------------------------------------
Ship it! Ship It! - Gaurav Nagar On June 27, 2016, 9:49 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49256/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 9:49 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17421 > https://issues.apache.org/jira/browse/AMBARI-17421 > > > Repository: ambari > > > Description > ------- > > Ealier user defined delimiters in CSV were not supported : > In this patch : > Following support has been added to upload feature. > 1. when "File type" is selected there will be a settings button which can be > clicked to open following CSV specific configurations > Column delimiter: select from dropdown : printable and non printable ascii > characters supported. > Escape Character: select from dropdown : printable and non printable ascii > characters supported. > Quote Character: select from dropdown : printable and non printable ascii > characters supported. > Is first row header ?: checkbox to specify if the first row of CSV is header > 2. when "Stored As" is TEXTFILE the setting button next to it will be enabled > for further settings > Fields Terminated By: the field terminator for hive table > Escape By: the escape character for hive table. > 3. When "Stored As" is not TEXTFILE a field called "Contains endlines?" will > be visible. > User has to check this field if the they field values contains endline (\n) > characters. If this is checked the temporary table is created with Hex > encoding of fields with datatype STRING, VARCHAR and CHAR to preserve endline > characters properly. If user does not select this and fields contain endline > characters then behaviour of upload is unexpected. Endline characters are not > supported in TEXTFILE hive storage type. > > > Diffs > ----- > > contrib/views/hive/pom.xml 444cd98 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java > 5164a4d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java > a540ca0 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java > 2e5f0f7 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/CSVParams.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableDataReader.java > e9bdb92 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/TableInput.java > f7fbbba > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadFromHdfsInput.java > 14bd27a > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > ad10751 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java > d03dd7e > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java > 8b75c04 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java > e592b5f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java > 49f47c7 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/RowIterator.java > 69fe864 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVIterator.java > 3342f49 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java > a48041c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVIterator.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/commonscsv/CSVParser.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/InsertFromQueryInput.java > 5befc51 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/QueryGenerator.java > 6bab229 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/RowFormat.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/query/TableInfo.java > 903e5b0 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 6fa6cfd > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > a00f0b4 > contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss > aeddaf6 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > 5e3a519 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java > c548d23 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java > a367375 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java > 6b2f6a33 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java > e5fddc7 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java > PRE-CREATION > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java > PRE-CREATION > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/QueryGeneratorTest.java > 5941aaaa > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/TableDataReaderTest.java > d94eace > > Diff: https://reviews.apache.org/r/49256/diff/ > > > Testing > ------- > > Unit test cases added existing test cases modified to handle these changes. > > > Thanks, > > Nitiraj Rathore > >
